public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io
Cc: Chasel Chiu <chasel.chiu@intel.com>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Eric Dong <eric.dong@intel.com>,
	Ankit Sinha <ankit.sinha@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs
Date: Tue, 17 May 2022 00:24:34 -0400	[thread overview]
Message-ID: <d78269a4-455b-9731-8541-acd80cf80cab@linux.microsoft.com> (raw)
In-Reply-To: <142e5fc2-1efd-14c3-df6f-7c8b71160845@linux.microsoft.com>

Can someone seriously respond?

This was approved over 3 weeks ago and sent 5 weeks ago. I know Ankit 
now has a similar change out but I'd like to see if this can get in and 
that be rebased on it since this has been out for so long and has the 
primary change needed for our integration.

Thanks,
Michael

On 5/13/2022 1:42 PM, Michael Kubacki wrote:
> Reminder
> 
> On 5/10/2022 1:34 PM, Michael Kubacki wrote:
>> Another reminder to look at this patch.
>>
>> Thanks,
>> Michael
>>
>>
>> On 4/29/2022 4:07 PM, Michael Kubacki wrote:
>>> Another reminder to merge this series. Chasel has added his review 
>>> and that is in this branch:
>>>
>>> https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1 
>>>
>>>
>>> Thanks,
>>> Michael
>>>
>>> On 4/22/2022 10:04 AM, Michael Kubacki wrote:
>>>> Reminder to review this series.
>>>>
>>>> Ankit Sinha has reviewed it but need a maintainer to review and merge.
>>>>
>>>> On 4/11/2022 4:58 PM, Michael Kubacki wrote:
>>>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>>>>
>>>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543
>>>>>
>>>>> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
>>>>> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE
>>>>> values in their build files.
>>>>>
>>>>> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to
>>>>> keep the change in sync with the source MinPlatformPkg module.
>>>>>
>>>>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>>>>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>>>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>>>> Cc: Eric Dong <eric.dong@intel.com>
>>>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>>>>
>>>>> Michael Kubacki (3):
>>>>>    MinPlatformPkg: Add FADT duty offset and duty width PCDs
>>>>>    MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>>>>>    SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width 
>>>>> PCDs
>>>>>
>>>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c |  3 +++
>>>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c |  4 ++--
>>>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c 
>>>>> |  3 +++
>>>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c 
>>>>> |  4 ++--
>>>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf |  2 ++
>>>>> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 15 +++++++++++++++
>>>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf 
>>>>> |  2 ++
>>>>>   7 files changed, 29 insertions(+), 4 deletions(-)
>>>>>

  reply	other threads:[~2022-05-17  4:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <16E4F328A12CE1E2.27279@groups.io>
2022-04-22 14:04 ` [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs Michael Kubacki
2022-04-29 20:07   ` Michael Kubacki
2022-05-10 17:34     ` Michael Kubacki
2022-05-13 17:42       ` Michael Kubacki
2022-05-17  4:24         ` Michael Kubacki [this message]
2022-04-11 20:58 Michael Kubacki
2022-04-11 23:31 ` [edk2-devel] " Sinha, Ankit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d78269a4-455b-9731-8541-acd80cf80cab@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox