From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.3299.1652761476609168748 for ; Mon, 16 May 2022 21:24:36 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=hsKzkFHb; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 6134520F3D15; Mon, 16 May 2022 21:24:35 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6134520F3D15 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1652761476; bh=4Urd9dhpEJTN2L90RANVcqWzv5FYMV2p2B4sHGaStg0=; h=Date:Subject:From:To:Cc:Reply-To:References:In-Reply-To:From; b=hsKzkFHbjw3iXUAoys/AkCjBdVFQoKUkbx2figrrKNxgHjZQ9G61aNX8ay/rQ4L4c IwE4hHiUfnUTtqX+5OMFZWSuYsAhIV8YCQeVNWZbaba/5A5TDne+aZ9vJjL8ZHFBNj JD7BH2Ptf1nfuCx8J39txh/oMf6sCLgIuoGWsxys= Message-ID: Date: Tue, 17 May 2022 00:24:34 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Liming Gao , Eric Dong , Ankit Sinha , Michael D Kinney Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com References: <16E4F328A12CE1E2.27279@groups.io> <5a877d28-27c7-492c-0370-7e7f0f4679e9@linux.microsoft.com> <142e5fc2-1efd-14c3-df6f-7c8b71160845@linux.microsoft.com> In-Reply-To: <142e5fc2-1efd-14c3-df6f-7c8b71160845@linux.microsoft.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Can someone seriously respond? This was approved over 3 weeks ago and sent 5 weeks ago. I know Ankit=20 now has a similar change out but I'd like to see if this can get in and=20 that be rebased on it since this has been out for so long and has the=20 primary change needed for our integration. Thanks, Michael On 5/13/2022 1:42 PM, Michael Kubacki wrote: > Reminder >=20 > On 5/10/2022 1:34 PM, Michael Kubacki wrote: >> Another reminder to look at this patch. >> >> Thanks, >> Michael >> >> >> On 4/29/2022 4:07 PM, Michael Kubacki wrote: >>> Another reminder to merge this series. Chasel has added his review=20 >>> and that is in this branch: >>> >>> https://github.com/makubacki/edk2-platforms/commits/active/add_duty_p= cds_minplatformpkg_v1_rb1=20 >>> >>> >>> Thanks, >>> Michael >>> >>> On 4/22/2022 10:04 AM, Michael Kubacki wrote: >>>> Reminder to review this series. >>>> >>>> Ankit Sinha has reviewed it but need a maintainer to review and merg= e. >>>> >>>> On 4/11/2022 4:58 PM, Michael Kubacki wrote: >>>>> From: Michael Kubacki >>>>> >>>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3543 >>>>> >>>>> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumer= s >>>>> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE >>>>> values in their build files. >>>>> >>>>> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to >>>>> keep the change in sync with the source MinPlatformPkg module. >>>>> >>>>> Cc: Chasel Chiu >>>>> Cc: Nate DeSimone >>>>> Cc: Liming Gao >>>>> Cc: Eric Dong >>>>> Signed-off-by: Michael Kubacki >>>>> >>>>> Michael Kubacki (3): >>>>> =C2=A0=C2=A0 MinPlatformPkg: Add FADT duty offset and duty width PC= Ds >>>>> =C2=A0=C2=A0 MinPlatformPkg/AcpiPlatform: Use FADT duty offset and = width PCDs >>>>> =C2=A0=C2=A0 SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset = and width=20 >>>>> PCDs >>>>> >>>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c |=C2=A0= 3 +++ >>>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c |=C2=A0 4= ++-- >>>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/= AcpiPlatform.c=20 >>>>> |=C2=A0 3 +++ >>>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/= Fadt/Fadt.c=20 >>>>> |=C2=A0 4 ++-- >>>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf |=C2= =A0 2 ++ >>>>> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 15 +++++++++++++= ++ >>>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/= AcpiPlatform.inf=20 >>>>> |=C2=A0 2 ++ >>>>> =C2=A0 7 files changed, 29 insertions(+), 4 deletions(-) >>>>>