From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0262D21CFA60E for ; Wed, 16 Aug 2017 14:55:13 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EE0983D959; Wed, 16 Aug 2017 21:57:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EE0983D959 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-59.phx2.redhat.com [10.3.116.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 591A960F87; Wed, 16 Aug 2017 21:57:37 +0000 (UTC) To: Brijesh Singh , edk2-devel@lists.01.org Cc: Jordan Justen , Tom Lendacky , Ard Biesheuvel References: <1502710605-8058-1-git-send-email-brijesh.singh@amd.com> <1502710605-8058-15-git-send-email-brijesh.singh@amd.com> From: Laszlo Ersek Message-ID: Date: Wed, 16 Aug 2017 23:57:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502710605-8058-15-git-send-email-brijesh.singh@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 16 Aug 2017 21:57:39 +0000 (UTC) Subject: Re: [PATCH v2 14/23] OvmfPkg/Virtio10Dxe: add the RingBaseShift offset X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Aug 2017 21:55:13 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/14/17 13:36, Brijesh Singh wrote: > virtio drivers uses VirtioRingMap() to map the ring buffer host address (1) Please replace "drivers uses VirtioRingMap()" with "drivers use VIRTIO_DEVICE_PROTOCOL.MapSharedBuffer()" The rest looks fine, thanks! Laszlo > to a device address. If an IOMMU is present then RingBaseShift contains > the offset from the host address. > > Suggested-by: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Tom Lendacky > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Brijesh Singh > --- > OvmfPkg/Virtio10Dxe/Virtio10.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/OvmfPkg/Virtio10Dxe/Virtio10.c b/OvmfPkg/Virtio10Dxe/Virtio10.c > index d102e1fd8551..e9041dec91a4 100644 > --- a/OvmfPkg/Virtio10Dxe/Virtio10.c > +++ b/OvmfPkg/Virtio10Dxe/Virtio10.c > @@ -498,11 +498,10 @@ Virtio10SetQueueAddress ( > UINT64 Address; > UINT16 Enable; > > - ASSERT (RingBaseShift == 0); > - > Dev = VIRTIO_1_0_FROM_VIRTIO_DEVICE (This); > > Address = (UINTN)Ring->Desc; > + Address += RingBaseShift; > Status = Virtio10Transfer (Dev->PciIo, &Dev->CommonConfig, TRUE, > OFFSET_OF (VIRTIO_PCI_COMMON_CFG, QueueDesc), > sizeof Address, &Address); > @@ -511,6 +510,7 @@ Virtio10SetQueueAddress ( > } > > Address = (UINTN)Ring->Avail.Flags; > + Address += RingBaseShift; > Status = Virtio10Transfer (Dev->PciIo, &Dev->CommonConfig, TRUE, > OFFSET_OF (VIRTIO_PCI_COMMON_CFG, QueueAvail), > sizeof Address, &Address); > @@ -519,6 +519,7 @@ Virtio10SetQueueAddress ( > } > > Address = (UINTN)Ring->Used.Flags; > + Address += RingBaseShift; > Status = Virtio10Transfer (Dev->PciIo, &Dev->CommonConfig, TRUE, > OFFSET_OF (VIRTIO_PCI_COMMON_CFG, QueueUsed), > sizeof Address, &Address); >