From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mx.groups.io with SMTP id smtpd.web10.10672.1607005723424133393 for ; Thu, 03 Dec 2020 06:28:43 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=GKR81hlV; spf=pass (domain: linux.ibm.com, ip: 148.163.156.1, mailfrom: jejb@linux.ibm.com) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0B3EIK8m044954; Thu, 3 Dec 2020 09:28:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : reply-to : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=pBljE9RFlIA2IvEZIUcrfucG0D+HOnl5qkQVTg4/mdc=; b=GKR81hlVfiByJUm0zsvf/DZOPwZOLk+7sC14ddZiubGPqM4V/ImyE/P3TBMUUdb9QC2T M4Mf2LjmCpMsruHJu0YU/lNtEFkJuOgIvig1CQ50kEXit0LEqFxRw6eorBCQYlYqYaAf S7T5+q8CXrIYLq5TD4AmjHuBaVwSXspDFFO0DooCf+Od3VRiO5JTz2S848ssVqzqjXyt jCSB9iRbGOb2M79bIoboDGy+Uo5khFqJ2D2QC0nVMgaRuDyjuonKPS3zAMDU/ukjbdN1 r5Vu3vD15BTpC+E0yCx9clSLPtIqCDJgY3IS8bjkipmojqSRnKG+yKfQOm+lxBwMj1AN +w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3571nsrbwb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Dec 2020 09:28:37 -0500 Received: from m0098396.ppops.net (m0098396.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0B3EK4p5058546; Thu, 3 Dec 2020 09:28:37 -0500 Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com with ESMTP id 3571nsrbvp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Dec 2020 09:28:37 -0500 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0B3EKpGC032004; Thu, 3 Dec 2020 14:28:36 GMT Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by ppma01wdc.us.ibm.com with ESMTP id 355vrg1jjy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Dec 2020 14:28:35 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0B3ERHY920447742 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 Dec 2020 14:27:17 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D4E4B7805F; Thu, 3 Dec 2020 14:27:17 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6FEB278063; Thu, 3 Dec 2020 14:27:15 +0000 (GMT) Received: from jarvis.int.hansenpartnership.com (unknown [9.80.201.242]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 3 Dec 2020 14:27:15 +0000 (GMT) Message-ID: Subject: Re: [edk2-devel] [PATCH v3 0/6] SEV Encrypted Boot for Ovmf From: "James Bottomley" Reply-To: jejb@linux.ibm.com To: devel@edk2.groups.io, lersek@redhat.com Cc: dovmurik@linux.vnet.ibm.com, Dov.Murik1@il.ibm.com, ashish.kalra@amd.com, brijesh.singh@amd.com, tobin@ibm.com, david.kaplan@amd.com, jon.grimm@amd.com, thomas.lendacky@amd.com, frankeh@us.ibm.com, "Dr . David Alan Gilbert" , Jordan Justen , Ard Biesheuvel Date: Thu, 03 Dec 2020 06:27:14 -0800 In-Reply-To: <0805f171-b5c2-a556-3e64-c700aaf06d85@redhat.com> References: <20201130202819.3910-1-jejb@linux.ibm.com> <0805f171-b5c2-a556-3e64-c700aaf06d85@redhat.com> User-Agent: Evolution 3.34.4 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-12-03_07:2020-12-03,2020-12-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxlogscore=990 bulkscore=0 clxscore=1015 priorityscore=1501 adultscore=0 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012030085 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Thu, 2020-12-03 at 13:26 +0100, Laszlo Ersek wrote: > Hi James, > > On 11/30/20 21:28, James Bottomley wrote: > > v3: > > > > - More grub and boot stripping (I think I got everything out, but > > there may be something that strayed in the boot panic > > resolution). > > - grub.sh tidy up with tabs->spaces. > > - Move the reset vector GUIDisation patch to the front so it can be > > applied independently > > - Update the .dsc and .fdf files for variable policy > > In preparation for submitting the github PR for merging this series, > I first ran PatchCheck.py locally. > > It doesn't like that I converted "OvmfPkg/AmdSev/Grub/grub.cfg" to > LF, in addition to "OvmfPkg/AmdSev/Grub/grub.sh". > > PatchCheck.py recognizes the ".sh" suffix, so it's not complaining > about "OvmfPkg/AmdSev/Grub/grub.sh". But, the config file is a > problem. > > Can you please confirm that grub works fine if the config file has > CRLF line terminators? Because then I'll just convert the config file > back to CRLF, and merge the series. I converted the entire file with unix2dos and grub does seem to be fine with the CRLF line endings (probably because it wants to be a boot loader beyond linux), so I think converting the file to CRLF is the right way to go. James