* PATCH [1/1] ArmPkg: Fix GicV2 BaseAddress types
@ 2023-05-11 12:52 neiljay
2023-05-12 18:28 ` [edk2-devel] " Pedro Falcato
2023-05-24 10:48 ` Sami Mujawar
0 siblings, 2 replies; 5+ messages in thread
From: neiljay @ 2023-05-11 12:52 UTC (permalink / raw)
To: devel
[-- Attachment #1: Type: text/plain, Size: 870 bytes --]
The GIC v2 base addresses can be 64bit, don't limit to 32 on 64bit
machines.
Signed-off-by: Neil Jones <neil.jones@blaize.com>
---
ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c
index 25290342bd..b990bf3a8a 100644
--- a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c
+++ b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c
@@ -25,8 +25,8 @@ Abstract:
extern EFI_HARDWARE_INTERRUPT_PROTOCOL gHardwareInterruptV2Protocol;
extern EFI_HARDWARE_INTERRUPT2_PROTOCOL gHardwareInterrupt2V2Protocol;
-STATIC UINT32 mGicInterruptInterfaceBase;
-STATIC UINT32 mGicDistributorBase;
+STATIC UINTN mGicInterruptInterfaceBase;
+STATIC UINTN mGicDistributorBase;
/**
Enable interrupt source Source.
--
2.39.2
[-- Attachment #2: Type: text/html, Size: 1048 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-devel] PATCH [1/1] ArmPkg: Fix GicV2 BaseAddress types
2023-05-11 12:52 PATCH [1/1] ArmPkg: Fix GicV2 BaseAddress types neiljay
@ 2023-05-12 18:28 ` Pedro Falcato
2023-05-24 10:48 ` Sami Mujawar
1 sibling, 0 replies; 5+ messages in thread
From: Pedro Falcato @ 2023-05-12 18:28 UTC (permalink / raw)
To: devel, neiljay; +Cc: Leif Lindholm, Ard Biesheuvel, Sami Mujawar
(+CC maintainers)
On Thu, May 11, 2023 at 5:47 PM <neiljay@gmail.com> wrote:
>
> The GIC v2 base addresses can be 64bit, don't limit to 32 on 64bit
> machines.
>
> Signed-off-by: Neil Jones <neil.jones@blaize.com>
> ---
> ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c
> index 25290342bd..b990bf3a8a 100644
> --- a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c
> +++ b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c
> @@ -25,8 +25,8 @@ Abstract:
> extern EFI_HARDWARE_INTERRUPT_PROTOCOL gHardwareInterruptV2Protocol;
> extern EFI_HARDWARE_INTERRUPT2_PROTOCOL gHardwareInterrupt2V2Protocol;
>
> -STATIC UINT32 mGicInterruptInterfaceBase;
> -STATIC UINT32 mGicDistributorBase;
> +STATIC UINTN mGicInterruptInterfaceBase;
> +STATIC UINTN mGicDistributorBase;
>
> /**
> Enable interrupt source Source.
> --
> 2.39.2
LGTM, particularly as the PCDs are 64-bit already.
Reviewed-by: Pedro Falcato <pedro.falcato@gmail.com>
but CC'ing the proper maintainers (please do so in the future!)
--
Pedro
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] PATCH [1/1] ArmPkg: Fix GicV2 BaseAddress types
2023-05-11 12:52 PATCH [1/1] ArmPkg: Fix GicV2 BaseAddress types neiljay
2023-05-12 18:28 ` [edk2-devel] " Pedro Falcato
@ 2023-05-24 10:48 ` Sami Mujawar
2023-05-29 11:44 ` Ard Biesheuvel
1 sibling, 1 reply; 5+ messages in thread
From: Sami Mujawar @ 2023-05-24 10:48 UTC (permalink / raw)
To: neiljay, devel
[-- Attachment #1: Type: text/plain, Size: 151 bytes --]
Hi Neil,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
[-- Attachment #2: Type: text/html, Size: 193 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] PATCH [1/1] ArmPkg: Fix GicV2 BaseAddress types
2023-05-24 10:48 ` Sami Mujawar
@ 2023-05-29 11:44 ` Ard Biesheuvel
2023-06-01 16:09 ` Ard Biesheuvel
0 siblings, 1 reply; 5+ messages in thread
From: Ard Biesheuvel @ 2023-05-29 11:44 UTC (permalink / raw)
To: devel, sami.mujawar; +Cc: neiljay
On Wed, 24 May 2023 at 12:48, Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> Hi Neil,
>
> Thank you for this patch.
> These changes look good to me.
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
I cannot apply this. Please resend this (with me on cc) using git send-email
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] PATCH [1/1] ArmPkg: Fix GicV2 BaseAddress types
2023-05-29 11:44 ` Ard Biesheuvel
@ 2023-06-01 16:09 ` Ard Biesheuvel
0 siblings, 0 replies; 5+ messages in thread
From: Ard Biesheuvel @ 2023-06-01 16:09 UTC (permalink / raw)
To: devel, sami.mujawar; +Cc: neiljay
On Mon, 29 May 2023 at 13:44, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Wed, 24 May 2023 at 12:48, Sami Mujawar <sami.mujawar@arm.com> wrote:
> >
> > Hi Neil,
> >
> > Thank you for this patch.
> > These changes look good to me.
> >
> > Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> >
>
>
Merged as #4465
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-01 16:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-11 12:52 PATCH [1/1] ArmPkg: Fix GicV2 BaseAddress types neiljay
2023-05-12 18:28 ` [edk2-devel] " Pedro Falcato
2023-05-24 10:48 ` Sami Mujawar
2023-05-29 11:44 ` Ard Biesheuvel
2023-06-01 16:09 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox