[Patch 0/2] Disable EBC for unit tests

[Patch 0/2] Disable EBC for unit tests

[Michael D Kinney]

https://bugzilla.tianocore.org/show_bug.cgi?id=2514

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Michael D Kinney (2):
  UnitTestFrameworkPkg: Disable EBC in DSC file
  MdePkg: Disable EBC for unit tests in MdePkg.dsc

 MdePkg/MdePkg.dsc                             | 1 +
 UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
2.21.0.windows.1

[Patch 1/2] UnitTestFrameworkPkg: Disable EBC in DSC file

[Michael D Kinney]

https://bugzilla.tianocore.org/show_bug.cgi?id=2514

Remove EBC as one of the supported architectures
in the UnitTestFrameworkPkg DSC file.  The EBC
compiler does not support cararg macros and the
UnitTestLib class uses this feature.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
index 0ad4482273..53d8f52754 100644
--- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
+++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
@@ -13,7 +13,7 @@ [Defines]
   PLATFORM_VERSION        = 1.00
   DSC_SPECIFICATION       = 0x00010005
   OUTPUT_DIRECTORY        = Build/UnitTestFrameworkPkg
-  SUPPORTED_ARCHITECTURES = IA32|X64|EBC|ARM|AARCH64
+  SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64
   BUILD_TARGETS           = DEBUG|RELEASE|NOOPT
   SKUID_IDENTIFIER        = DEFAULT
 
-- 
2.21.0.windows.1

Re: [edk2-devel] [Patch 1/2] UnitTestFrameworkPkg: Disable EBC in DSC file

[Laszlo Ersek]

On 02/10/20 21:24, Michael D Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2514
> 
> Remove EBC as one of the supported architectures
> in the UnitTestFrameworkPkg DSC file.  The EBC
> compiler does not support cararg macros and the

small typo: s/cararg/vararg/

Thanks
Laszlo

> UnitTestLib class uses this feature.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
> index 0ad4482273..53d8f52754 100644
> --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
> +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
> @@ -13,7 +13,7 @@ [Defines]
>    PLATFORM_VERSION        = 1.00
>    DSC_SPECIFICATION       = 0x00010005
>    OUTPUT_DIRECTORY        = Build/UnitTestFrameworkPkg
> -  SUPPORTED_ARCHITECTURES = IA32|X64|EBC|ARM|AARCH64
> +  SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64
>    BUILD_TARGETS           = DEBUG|RELEASE|NOOPT
>    SKUID_IDENTIFIER        = DEFAULT
>  
> 

Re: [EXTERNAL] Re: [edk2-devel] [Patch 1/2] UnitTestFrameworkPkg: Disable EBC in DSC file

[Bret Barkelew]

[-- Attachment #1: Type: text/plain, Size: 2030 bytes --]

Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>

- Bret

________________________________
From: Laszlo Ersek <lersek@redhat.com>
Sent: Tuesday, February 11, 2020 1:02:17 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] Re: [edk2-devel] [Patch 1/2] UnitTestFrameworkPkg: Disable EBC in DSC file

On 02/10/20 21:24, Michael D Kinney wrote:
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2514&amp;data=02%7C01%7Cbret.barkelew%40microsoft.com%7Cabce6dc4e8984e69faae08d7aed12330%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637170085571112419&amp;sdata=J40%2BxMF1CTlCdsZMK4%2Fjtp2jKkSdunF1b07tU34BIk4%3D&amp;reserved=0
>
> Remove EBC as one of the supported architectures
> in the UnitTestFrameworkPkg DSC file.  The EBC
> compiler does not support cararg macros and the

small typo: s/cararg/vararg/

Thanks
Laszlo

> UnitTestLib class uses this feature.
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
> index 0ad4482273..53d8f52754 100644
> --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
> +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
> @@ -13,7 +13,7 @@ [Defines]
>    PLATFORM_VERSION        = 1.00
>    DSC_SPECIFICATION       = 0x00010005
>    OUTPUT_DIRECTORY        = Build/UnitTestFrameworkPkg
> -  SUPPORTED_ARCHITECTURES = IA32|X64|EBC|ARM|AARCH64
> +  SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64
>    BUILD_TARGETS           = DEBUG|RELEASE|NOOPT
>    SKUID_IDENTIFIER        = DEFAULT
>
>


[-- Attachment #2: Type: text/html, Size: 4495 bytes --]

Re: [EXTERNAL] [edk2-devel] [Patch 1/2] UnitTestFrameworkPkg: Disable EBC in DSC file

[Bret Barkelew]

[-- Attachment #1: Type: text/plain, Size: 1953 bytes --]

Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>

- Bret

________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Michael D Kinney via Groups.Io <michael.d.kinney=intel.com@groups.io>
Sent: Monday, February 10, 2020 12:24:40 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] [edk2-devel] [Patch 1/2] UnitTestFrameworkPkg: Disable EBC in DSC file

https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2514&amp;data=02%7C01%7Cbret.barkelew%40microsoft.com%7C9e9da4e9e08b40dca06308d7ae67455a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637169630879174350&amp;sdata=ye%2FQPMZgnrj8BE3spu07pO5optLKsh%2F%2Fa8YRZruZZ94%3D&amp;reserved=0

Remove EBC as one of the supported architectures
in the UnitTestFrameworkPkg DSC file.  The EBC
compiler does not support cararg macros and the
UnitTestLib class uses this feature.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
index 0ad4482273..53d8f52754 100644
--- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
+++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
@@ -13,7 +13,7 @@ [Defines]
   PLATFORM_VERSION        = 1.00
   DSC_SPECIFICATION       = 0x00010005
   OUTPUT_DIRECTORY        = Build/UnitTestFrameworkPkg
-  SUPPORTED_ARCHITECTURES = IA32|X64|EBC|ARM|AARCH64
+  SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64
   BUILD_TARGETS           = DEBUG|RELEASE|NOOPT
   SKUID_IDENTIFIER        = DEFAULT

--
2.21.0.windows.1





[-- Attachment #2: Type: text/html, Size: 4426 bytes --]

[Patch 2/2] MdePkg: Disable EBC for unit tests in MdePkg.dsc

[Michael D Kinney]

https://bugzilla.tianocore.org/show_bug.cgi?id=2514

Update the target unit tests in MdePkg.dsc to only
build for IA32, X64, ARM, AARCH64.  This disables
EBC for these components.  The UnitTestLib class
uses vararg macros that the EBC compiler does not
support.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 MdePkg/MdePkg.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc
index 87af740853..2b2d5981e8 100644
--- a/MdePkg/MdePkg.dsc
+++ b/MdePkg/MdePkg.dsc
@@ -120,6 +120,7 @@ [Components]
   MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.inf
   MdePkg/Library/StandaloneMmServicesTableLib/StandaloneMmServicesTableLib.inf
 
+[Components.IA32, Components.X64, Components.ARM, Components.AARCH64]
   #
   # Add UEFI Target Based Unit Tests
   #
-- 
2.21.0.windows.1

Re: [EXTERNAL] [edk2-devel] [Patch 0/2] Disable EBC for unit tests

[Bret Barkelew]

[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]

Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>

- Bret

________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Michael D Kinney via Groups.Io <michael.d.kinney=intel.com@groups.io>
Sent: Monday, February 10, 2020 12:24:39 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] [edk2-devel] [Patch 0/2] Disable EBC for unit tests

https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2514&amp;data=02%7C01%7Cbret.barkelew%40microsoft.com%7C63ad9885002b4558953a08d7ae6744e3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637169630884257799&amp;sdata=OYyaAI0jpK0TfrHA9G9mqZf8Nsp%2BYQoDjMWNAKBh3AA%3D&amp;reserved=0

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Michael D Kinney (2):
  UnitTestFrameworkPkg: Disable EBC in DSC file
  MdePkg: Disable EBC for unit tests in MdePkg.dsc

 MdePkg/MdePkg.dsc                             | 1 +
 UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

--
2.21.0.windows.1





[-- Attachment #2: Type: text/html, Size: 3613 bytes --]