From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DS1heANx; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: philmd@redhat.com) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by groups.io with SMTP; Tue, 01 Oct 2019 03:20:09 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1569925208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=teENnYd+FLx17QCc/7hc1h0gQj8hBO8PKKJzVpB/29k=; b=DS1heANxJk97YJgRXACLk1LG6VSPS3EF8REtPStkQMyqCxZOy1lTADVSCLmS1gGxxLhspc rWiQ2/Py01sd5lLUx3SKNtZeYK38zBxSZNqY4vQ9N5Is9R1DnC3WOhEPzGiFi8QXxuJS4s YJgfF0pBPtF9+2X9250uh5qY/yvBShY= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-258-A1jBzzoIPG-IYOu84yeYjg-1; Tue, 01 Oct 2019 06:20:06 -0400 Received: by mail-wr1-f71.google.com with SMTP id a4so5773705wrg.8 for ; Tue, 01 Oct 2019 03:20:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MCddTWvaTsjASXlwc92LSCw8iU5gY7VWyWxNU4fRYY4=; b=BSOzh9FqNBH1Qrkz9gNNc+hdilvwLNS5vu0h5hC0FbIsb49KgLymV6bqfjmy9WWotl BK2q53F/HEplJYPscqVaORovR99VIcZoHSj6/RgwyRwq3XTbx0syZWO+B3IS0ILEspIK ltg6inPP/fQ1KrFjoMK5eWP3eDOAfmGbnWNcTVsT7Bd++umMNTvBNAuYdQgotbSD1fQF S56FLLzMdwLhh7jHySabl+Cudv5Vf4edSdTYUoJ0WRRgs+DYzeBX4qELBMt/TQ+wPINw 4ghX/rOQfu/rNa6QCUnYzWILGbdvQegFomcgbdMvxM/V3MVCJRiXDpUcN5GByNgUFYuN KY0w== X-Gm-Message-State: APjAAAUzhFO5a1ASao3K7DcU76WjReefYWaYI6xqgXWclj0ABnsbdwvb ToScZTEL7fWQoAMeYsbXvBKVldEJeFedJ6rNbNRxTgWB09dvzb4ADDhuNWlD5+QumIszs2AbcNv a9W07lF95qUztaw== X-Received: by 2002:a1c:2c3:: with SMTP id 186mr2883749wmc.172.1569925204764; Tue, 01 Oct 2019 03:20:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqxgzGgql82TMhzhrG1oYVdQLnbD+z/DYrEdCD9SGwko1GRzJ7D2ArZFFW0wEbqmqqbmoPAk7Q== X-Received: by 2002:a1c:2c3:: with SMTP id 186mr2883729wmc.172.1569925204464; Tue, 01 Oct 2019 03:20:04 -0700 (PDT) Return-Path: Received: from [192.168.1.35] (240.red-88-21-68.staticip.rima-tde.net. [88.21.68.240]) by smtp.gmail.com with ESMTPSA id l13sm2106016wmj.25.2019.10.01.03.20.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Oct 2019 03:20:03 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/1] Platforms/RPi3: DisplayDxe virtual resolution improvements To: devel@edk2.groups.io, pete@akeo.ie, leif.lindholm@linaro.org Cc: ard.biesheuvel@linaro.org References: <20190927092016.5604-1-pete@akeo.ie> <20190927174923.GP25504@bivouac.eciton.net> <471e60ec-2fe4-7d6f-619c-f35b2ec29bf9@redhat.com> <8cd1da3e-86b4-c8c8-1737-01fd8c728402@akeo.ie> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Tue, 1 Oct 2019 12:20:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <8cd1da3e-86b4-c8c8-1737-01fd8c728402@akeo.ie> X-MC-Unique: A1jBzzoIPG-IYOu84yeYjg-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Pete, On 9/27/19 10:41 PM, Pete Batard wrote: > Try this after making sure that you have edk2/, edk2-platforms/ and=20 > edk-non-osi/ in /home/phil/source: >=20 > cd /home/phil/source > export GCC5_AARCH64_PREFIX=3Daarch64-linux-gnu- > export WORKSPACE=3D$PWD > export=20 > PACKAGES_PATH=3D$WORKSPACE/edk2:$WORKSPACE/edk2-platforms:$WORKSPACE/edk2= -non-osi=20 >=20 > source edk2/edksetup.sh --reconfig > build -a AARCH64 -t GCC5 -p=20 > edk2-platforms/Platform/RaspberryPi/RPi3/RPi3.dsc -b DEBUG [note for other readers: I'm answering to Pete top-posted comment, start of the discussion can be followed below my reply] I'm confused because this works like charm. I always used: WORKSPACE =3D /home/phil/source/edk2 PACKAGES_PATH =3D /home/phil/source/edk2:/home/phil/source/edk2-platforms and built into my edk2/ folder (my $WORKSPACE). Leif noticed I was missing edk2-non-osi, so I added it (this reply below): PACKAGES_PATH =3D /home/phil/source/edk2:/home/phil/source/edk2-platforms:/home/phil/source/e= dk2-non-osi=20 I don't understand why modifying $WORKSPACE out of edk2/ this changes=20 the behavior into failure, I thought it was would mostly change the=20 Build/ folder location, and the packages were only searched into=20 $PACKAGES_PATH (which did not change). Anyhow I'll adapt my setup and not use edk2/ as $WORKSPACE anymore. Thanks for the pointers, Phil. > On 2019.09.27 21:23, Philippe Mathieu-Daud=C3=A9 wrote: >> On 9/27/19 7:49 PM, Leif Lindholm wrote: >>> On Fri, Sep 27, 2019 at 06:38:07PM +0200, Philippe Mathieu-Daud=C3=A9 w= rote: >>>> Hi Pete, >>>> >>>> On 9/27/19 11:20 AM, Pete Batard wrote: >>>>> From: Andrei Warkentin >>>>> >>>>> The Pi GPU decouples requested resolution from actual physical=20 >>>>> resolution >>>>> and can perform scaling of virtual resolutions. This enables=20 >>>>> platform users >>>>> to do something like ask for 1024x768 and get a framebuffer of that= =20 >>>>> size, >>>>> regardless of the actual output (which could be a very blurry SDTV). >>>>> >>>>> Specifically, this patch allows selecting which specific virtual >>>>> resolutions to enable, thus replacing the old all-or-nothing behaviou= r >>>>> with either all virtual resolutions supported, or just the native one= . >>>>> >>>>> This patch also adds enables the common 7" Pi (800x480) screen to=20 >>>>> be used >>>>> at 800x600 resolution, instead of forcing 640x480 as the only usable >>>>> resolution. >>>> >>>> I tried to build the RPi3 platform but I get errors because it seems t= o >>>> use an older edk2 repository. What tag should I use? >>> >>> edk2-platforms master should always build against edk2 - if it does >>> not, that's a bug. But I can't see any issues when building rpi3 with >>> the current master branches. >>> Any platform that is not willing to commit to this state of things can >>> live on stable- or devel- branches in the edk-platforms repository. >>> This process is described in >>> https://github.com/tianocore/edk2-platforms/blob/about/Readme.md >>> >>> But please provide some more information than "I get errors". It is a >>> much better use of maintainer time than sending me off verifying that >>> something I expected to work still works (for me). >> >> Yes, sorry :/ >> >> So the first error was: >> >> : error 000E: File/directory not found in workspace >> =C2=A0=C2=A0 Platform/RaspberryPi/RPi3/Drivers/LogoDxe/LogoDxe.inf is no= t found in >> packages path: >> >> And as you noted on IRC, I was missing edk2-non-osi, silly me :S >> >> Using it I now get: >> >> /home/phil/source/edk2$ GCC5_AARCH64_PREFIX=3Daarch64-linux-gnu- build -= a >> AARCH64 -t GCC5 -b DEBUG -p Platform/RaspberryPi/RPi3/RPi3.dsc -D >> ATF_BUILD_DIR=3D$ATF_BUILD_DIR -n 1 >> Build environment: >> Linux-5.2.11-100.fc29.x86_64-x86_64-with-Ubuntu-16.04-xenial >> Build start time: 20:10:25, Sep.27 2019 >> >> WORKSPACE=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D /home/phil/sourc= e/edk2 >> PACKAGES_PATH=C2=A0=C2=A0=C2=A0 =3D >> /home/phil/source/edk2:/home/phil/source/edk2-platforms:/home/phil/sourc= e/edk2-non-osi=20 >> >> EDK_TOOLS_PATH=C2=A0=C2=A0 =3D /home/phil/source/edk2/BaseTools >> CONF_PATH=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D /home/phil/sourc= e/edk2/Conf >> >> >> Architecture(s)=C2=A0 =3D AARCH64 >> Build target=C2=A0=C2=A0=C2=A0=C2=A0 =3D DEBUG >> >> Processing meta-data .Toolchain=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 =3D GCC5 >> >> Active Platform=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = =3D >> /home/phil/source/edk2-platforms/Platform/RaspberryPi/RPi3/RPi3.dsc >> ..... done! >> Building ... >> /home/phil/source/edk2/ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntr= insicsLib.inf=20 >> >> [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... >> /home/phil/source/edk2/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLi= b.inf=20 >> >> [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... >> /home/phil/source/edk2/MdePkg/Library/UefiDriverEntryPoint/UefiDriverEnt= ryPoint.inf=20 >> >> [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... /home/phil/source/edk2/MdePkg/Library/UefiLib/UefiLib.inf >> [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... >> /home/phil/source/edk2/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLi= b.inf=20 >> >> [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... >> /home/phil/source/edk2/MdePkg/Library/UefiRuntimeServicesTableLib/UefiRu= ntimeServicesTableLib.inf=20 >> >> [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... >> /home/phil/source/edk2/MdePkg/Library/UefiMemoryAllocationLib/UefiMemory= AllocationLib.inf=20 >> >> [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... >> /home/phil/source/edk2/MdePkg/Library/UefiBootServicesTableLib/UefiBootS= ervicesTableLib.inf=20 >> >> [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... >> /home/phil/source/edk2/MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLi= bSerialPort.inf=20 >> >> [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... >> /home/phil/source/edk2/MdeModulePkg/Library/BaseSerialPortLib16550/BaseS= erialPortLib16550.inf=20 >> >> [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... >> /home/phil/source/edk2/MdePkg/Library/BasePrintLib/BasePrintLib.inf >> [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... >> /home/phil/source/edk2/MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDe= bugPrintErrorLevelLib.inf=20 >> >> [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... >> /home/phil/source/edk2/MdeModulePkg/Library/BasePlatformHookLibNull/Base= PlatformHookLibNull.inf=20 >> >> [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... >> /home/phil/source/edk2/MdePkg/Library/BasePciLibCf8/BasePciLibCf8.inf >> [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... >> /home/phil/source/edk2/MdePkg/Library/BasePciCf8Lib/BasePciCf8Lib.inf >> [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... >> /home/phil/source/edk2/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrin= sic.inf=20 >> >> [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... >> /home/phil/source/edk2/MdePkg/Library/DxePcdLib/DxePcdLib.inf [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... /home/phil/source/edk2/MdePkg/Library/BaseLib/BaseLib.inf >> [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... >> /home/phil/source/edk2/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibO= ptDxe.inf=20 >> >> [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... >> /home/phil/source/edk2/MdeModulePkg/Universal/DevicePathDxe/DevicePathDx= e.inf=20 >> >> [AARCH64] >> make: Nothing to be done for 'tbuild'. >> Building ... >> /home/phil/source/edk2-platforms/Platform/RaspberryPi/RPi3/Drivers/Platf= ormSmbiosDxe/PlatformSmbiosDxe.inf=20 >> >> [AARCH64] >> test -f >> /home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/AARCH64/Platform/RaspberryP= i/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe/OUTPUT/PlatformSmbiosDxe= .map=20 >> >> && cp -f >> /home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/AARCH64/Platform/RaspberryP= i/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe/OUTPUT/PlatformSmbiosDxe= .map=20 >> >> /home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/FV/Ffs/BAD0554E-22E9-4D83-9= AFD-CC87727A1A45PlatformSmbiosDxe/BAD0554E-22E9-4D83-9AFD-CC87727A1A45.map= =20 >> >> GNUmakefile:476: recipe for target >> '/home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/FV/Ffs/BAD0554E-22E9-4D83-= 9AFD-CC87727A1A45PlatformSmbiosDxe/BAD0554E-22E9-4D83-9AFD-CC87727A1A45.map= '=20 >> >> failed >> make: *** >> [/home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/FV/Ffs/BAD0554E-22E9-4D83-= 9AFD-CC87727A1A45PlatformSmbiosDxe/BAD0554E-22E9-4D83-9AFD-CC87727A1A45.map= ]=20 >> >> Error 1 >> >> >> build.py... >> =C2=A0 : error 7000: Failed to execute command >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 make tbuild >> [/home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/AARCH64/edk2-platforms/Pla= tform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe]=20 >> >> >> >> build.py... >> =C2=A0 : error F002: Failed to build module >> >> /home/phil/source/edk2-platforms/Platform/RaspberryPi/RPi3/Drivers/Platf= ormSmbiosDxe/PlatformSmbiosDxe.inf=20 >> >> [AARCH64, GCC5, DEBUG] >> >> However I do have this file generated: >> >> /home/phil/source/edk2$ find -name PlatformSmbiosDxe.map >> ./Build/RPi3/DEBUG_GCC5/AARCH64/edk2-platforms/Platform/RaspberryPi/RPi3= /Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe/OUTPUT/PlatformSmbiosDxe.map= =20 >> >> ./Build/RPi3/DEBUG_GCC5/AARCH64/edk2-platforms/Platform/RaspberryPi/RPi3= /Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe/DEBUG/PlatformSmbiosDxe.map=20 >> >> >> Let's try dumb symlink: >> >> edk2@x1w:/home/phil/source/edk2$ ln -s >> /home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/AARCH64/edk2-platforms/Plat= form=20 >> >> /home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/AARCH64/Platform >> >> >> Building ... >> /home/phil/source/edk2-non-osi/Platform/RaspberryPi/RPi3/Drivers/LogoDxe= /LogoDxe.inf=20 >> >> [AARCH64] >> test -f >> /home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/AARCH64/Platform/RaspberryP= i/RPi3/Drivers/LogoDxe/LogoDxe/OUTPUT/LogoDxe.map=20 >> >> && cp -f >> /home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/AARCH64/Platform/RaspberryP= i/RPi3/Drivers/LogoDxe/LogoDxe/OUTPUT/LogoDxe.map=20 >> >> /home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/FV/Ffs/F74D20EE-37E7-48FC-9= 7F7-9B1047749C69LogoDxe/F74D20EE-37E7-48FC-97F7-9B1047749C69.map=20 >> >> make: *** >> [/home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/FV/Ffs/F74D20EE-37E7-48FC-= 97F7-9B1047749C69LogoDxe/F74D20EE-37E7-48FC-97F7-9B1047749C69.map]=20 >> >> Error 1 >> GNUmakefile:455: recipe for target >> '/home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/FV/Ffs/F74D20EE-37E7-48FC-= 97F7-9B1047749C69LogoDxe/F74D20EE-37E7-48FC-97F7-9B1047749C69.map'=20 >> >> failed >> >> Hmmm it seems something is wrong with my paths... >> >> I rm'ed -rf ./Build and retried but still the same result. >> >> I'll try somewhere else. >> >>>>> Signed-off-by: Pete Batard >>>> >>>> Hmm shouldn't this patch have a S-o-b from Andrei Warkentin too? >>> >>> No. Andrei is the author, he is not the person upstreaming. And the >>> From: tag retains his authorship. >> >> Oh, this is new to me. >> >>> Adding a S-o-b in that situation equates to putting in the commit >>> message that "Oh, and Andrei says he's cool with >>> https://developercertificate.org/". >> >> OK :) >> >> Thanks, >> >> Phil. >> >> [...]