From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from spamsz.greatwall.com.cn (spamsz.greatwall.com.cn [58.60.186.99]) by mx.groups.io with SMTP id smtpd.web12.43668.1609146715835263639 for ; Mon, 28 Dec 2020 01:11:57 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: greatwall.com.cn, ip: 58.60.186.99, mailfrom: gechao@greatwall.com.cn) X-ASG-Debug-ID: 1609146708-0ec572118a37430001-xsgHyH Received: from greatwall.com.cn (mail.greatwall.com.cn [10.11.120.1]) by spamsz.greatwall.com.cn with ESMTP id rgHwAV8ThUyAUkgG for ; Mon, 28 Dec 2020 17:11:48 +0800 (CST) X-Barracuda-Envelope-From: gechao@greatwall.com.cn X-Barracuda-RBL-Trusted-Forwarder: 10.11.120.1 Received: from DESKTOP-8UEJ5KU.greatwall.com.cn (unknown [10.11.15.76]) by mailsz.greatwall.com.cn (Coremail) with SMTP id AXgLCgD315QRoelfCwoAAA--.31S2; Mon, 28 Dec 2020 17:10:41 +0800 (CST) From: gechao@greatwall.com.cn X-Barracuda-RBL-Trusted-Forwarder: 10.11.15.76 To: dandan.bi@intel.com, eric.dong@intel.com Cc: devel@edk2.groups.io, jian.j.wang@intel.com, hao.a.wu@intel.com, gechao Subject: [PATCH] MdeModulePkg/DisplayEngineDxe: Fix Help information shadow problem Date: Mon, 28 Dec 2020 17:11:41 +0800 X-ASG-Orig-Subj: [PATCH] MdeModulePkg/DisplayEngineDxe: Fix Help information shadow problem Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: AXgLCgD315QRoelfCwoAAA--.31S2 X-Coremail-Antispam: 1UD129KBjvJXoW7tryUtryrWr1xKr15trWxXrb_yoW8tFW5p3 9xCr1qy345JasI9r9xW340qF43K34rG3s3Aw13J3WFk3yUKan7tws8Krn3JrZ8Ca17Cwn5 Xr1agr4Fgr4UK3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkv14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26rxl 6s0DM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lw4CEc2x0rVAKj4xx MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr 0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0E wIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJV W8JwCI42IY6xAIw20EY4v20xvaj40_WFyUJVCq3wCI42IY6I8E87Iv67AKxVWUJVW8JwCI 42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x0JU6CJPUUUUU= X-CM-SenderInfo: xjhfxtvr6j2vpdwztz3oof0zgofq/ X-Barracuda-Connect: mail.greatwall.com.cn[10.11.120.1] X-Barracuda-Start-Time: 1609146708 X-Barracuda-URL: https://spamfw.greatwall.com.cn:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at greatwall.com.cn X-Barracuda-Scan-Msg-Size: 2789 X-Barracuda-BRTS-Status: 1 X-Barracuda-Bayes: INNOCENT GLOBAL 0.3996 1.0000 -0.0010 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests=BSF_SC0_MISMATCH_TO, NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.86846 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name 0.00 BSF_SC0_MISMATCH_TO Envelope rcpt doesn't match header Content-Transfer-Encoding: quoted-printable From: gechao Fix residual display problem in help information section with different length string. When switching between different items, the help inform- ation part may remain the last displayed help information content. Example: Last: ABCDEFGH, New: 1234567 Result: 1234567H Signed-off-by: gechao --- .../Universal/DisplayEngineDxe/FormDisplay.c | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c b/MdeMod= ulePkg/Universal/DisplayEngineDxe/FormDisplay.c index a3898dc2ec..abb4843a73 100644 --- a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c +++ b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c @@ -3061,6 +3061,15 @@ UiDisplayMenu ( //=0D if (!MultiHelpPage) {=0D for (Index =3D 0; Index < HelpLine; Index++) {=0D + //=0D + // Clear whole line first, Clear the last displayed information.= =0D + //=0D + PrintStringAtWithWidth (=0D + gStatementDimensions.RightColumn - gHelpBlockWidth,=0D + Index + TopRow,=0D + gEmptyString,=0D + gHelpBlockWidth=0D + );=0D PrintStringAtWithWidth (=0D gStatementDimensions.RightColumn - gHelpBlockWidth,=0D Index + TopRow,=0D @@ -3080,6 +3089,15 @@ UiDisplayMenu ( } else {=0D if (HelpPageIndex =3D=3D 0) {=0D for (Index =3D 0; Index < RowCount - HelpBottomLine; Index++) {= =0D + //=0D + // Clear whole line first, Clear the last displayed informatio= n.=0D + //=0D + PrintStringAtWithWidth (=0D + gStatementDimensions.RightColumn - gHelpBlockWidth,=0D + Index + TopRow,=0D + gEmptyString,=0D + gHelpBlockWidth=0D + );=0D PrintStringAtWithWidth (=0D gStatementDimensions.RightColumn - gHelpBlockWidth,=0D Index + TopRow,=0D @@ -3090,6 +3108,15 @@ UiDisplayMenu ( } else {=0D for (Index =3D 0; (Index < RowCount - HelpBottomLine - HelpHeade= rLine) &&=0D (Index + HelpPageIndex * (RowCount - 2) + 1 < HelpLine); Ind= ex++) {=0D + //=0D + // Clear whole line first, Clear the last displayed informatio= n.=0D + //=0D + PrintStringAtWithWidth (=0D + gStatementDimensions.RightColumn - gHelpBlockWidth,=0D + Index + TopRow + HelpHeaderLine,=0D + gEmptyString,=0D + gHelpBlockWidth=0D + );=0D PrintStringAtWithWidth (=0D gStatementDimensions.RightColumn - gHelpBlockWidth,=0D Index + TopRow + HelpHeaderLine,=0D --=20 2.25.1