public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [PATCH] OvmfPkg/PlatformPei: debug log "etc/reserved-memory-end" from fw_cfg
Date: Wed, 28 Mar 2018 15:09:15 +0200	[thread overview]
Message-ID: <d8061746-d5cb-d6de-ff5c-b73a0ad96c4d@redhat.com> (raw)
In-Reply-To: <CAKv+Gu_toSZTdAJgdsT0K_tK5vQUEQcW_hxZX=i66ebWxToR7Q@mail.gmail.com>

On 03/28/18 14:57, Ard Biesheuvel wrote:
> On 28 March 2018 at 13:38, Laszlo Ersek <lersek@redhat.com> wrote:
>> QEMU calculates the UINT64 value in "etc/reserved-memory-end" in a quite
>> complex way, in the pc_memory_init() function. Log the value as a
>> DEBUG_VERBOSE message to support debugging.
>>
>> Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1353591
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> 
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks Ard! Commit c27c0003c10f.
Laszlo


>> ---
>>  OvmfPkg/PlatformPei/MemDetect.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/OvmfPkg/PlatformPei/MemDetect.c b/OvmfPkg/PlatformPei/MemDetect.c
>> index 2b2f3e4bec55..2f9e83551364 100644
>> --- a/OvmfPkg/PlatformPei/MemDetect.c
>> +++ b/OvmfPkg/PlatformPei/MemDetect.c
>> @@ -358,6 +358,8 @@ GetFirstNonAddress (
>>    if (!EFI_ERROR (Status) && FwCfgSize == sizeof HotPlugMemoryEnd) {
>>      QemuFwCfgSelectItem (FwCfgItem);
>>      QemuFwCfgReadBytes (FwCfgSize, &HotPlugMemoryEnd);
>> +    DEBUG ((DEBUG_VERBOSE, "%a: HotPlugMemoryEnd=0x%Lx\n", __FUNCTION__,
>> +      HotPlugMemoryEnd));
>>
>>      ASSERT (HotPlugMemoryEnd >= FirstNonAddress);
>>      FirstNonAddress = HotPlugMemoryEnd;
>> --
>> 2.14.1.3.gb7cf6e02401b
>>



      reply	other threads:[~2018-03-28 13:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28 11:38 [PATCH] OvmfPkg/PlatformPei: debug log "etc/reserved-memory-end" from fw_cfg Laszlo Ersek
2018-03-28 12:57 ` Ard Biesheuvel
2018-03-28 13:09   ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8061746-d5cb-d6de-ff5c-b73a0ad96c4d@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox