From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Jeff Brasen <jbrasen@nvidia.com>, devel@edk2.groups.io
Cc: pierre.gondois@arm.com, swatisrik@nvidia.com,
ashishsingha@nvidia.com, "nd@arm.com" <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v4 3/4] DynamicTablesPkg: Add support to add Strings to\r package
Date: Thu, 21 Sep 2023 17:49:38 +0100 [thread overview]
Message-ID: <d81dd962-e834-9130-6704-257065d2c01e@arm.com> (raw)
In-Reply-To: <0b3876f84e0044990f18f81f4128de548797ff53.1695049337.git.jbrasen@nvidia.com>
Hi Jeff,
Thank you for this patch.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 18/09/2023 04:46 pm, Jeff Brasen wrote:
> Add API to add a String to a package created with NamedPackage API.
>
>
>
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
>
> ---
>
> .../Include/Library/AmlLib/AmlLib.h | 17 ++++
>
> .../Common/AmlLib/CodeGen/AmlCodeGen.c | 88 +++++++++++++++++++
>
> 2 files changed, 105 insertions(+)
>
>
>
> diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
>
> index b82c7a3ce8..f4a4908753 100644
>
> --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
>
> +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
>
> @@ -1472,4 +1472,21 @@ AmlCreateCpcNode (
>
> OUT AML_OBJECT_NODE_HANDLE *NewCpcNode OPTIONAL
>
> );
>
>
>
> +/** AML code generation to add a NameString to the package in a named node.
>
> +
>
> +
>
> + @param [in] NameString NameString to add
>
> + @param [in] NamedNode Node to add the string to the included package.
>
> +
>
> + @retval EFI_SUCCESS Success.
>
> + @retval EFI_INVALID_PARAMETER Invalid parameter.
>
> + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory.
>
> +**/
>
> +EFI_STATUS
>
> +EFIAPI
>
> +AmlAddNameStringToNamedPackage (
>
> + IN CHAR8 *NameString,
>
> + IN AML_OBJECT_NODE_HANDLE NamedNode
>
> + );
>
> +
>
> #endif // AML_LIB_H_
>
> diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
>
> index ea519d1aa8..2afd405750 100644
>
> --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
>
> +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
>
> @@ -3685,3 +3685,91 @@ error_handler:
>
> AmlDeleteTree ((AML_NODE_HANDLE)CpcNode);
>
> return Status;
>
> }
>
> +
>
> +/** AML code generation to add a NameString to the package in a named node.
>
> +
>
> +
>
> + @param [in] NameString NameString to add
>
> + @param [in] NamedNode Node to add the string to the included package.
>
> +
>
> + @retval EFI_SUCCESS Success.
>
> + @retval EFI_INVALID_PARAMETER Invalid parameter.
>
> + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory.
>
> +**/
>
> +EFI_STATUS
>
> +EFIAPI
>
> +AmlAddNameStringToNamedPackage (
>
> + IN CHAR8 *NameString,
>
> + IN AML_OBJECT_NODE_HANDLE NamedNode
>
> + )
>
> +{
>
> + EFI_STATUS Status;
>
> + AML_DATA_NODE *DataNode;
>
> + CHAR8 *AmlNameString;
>
> + UINT32 AmlNameStringSize;
>
> + AML_OBJECT_NODE_HANDLE PackageNode;
>
> +
>
> + DataNode = NULL;
>
> +
>
> + if ((NamedNode == NULL) ||
>
> + (AmlGetNodeType ((AML_NODE_HANDLE)NamedNode) != EAmlNodeObject) ||
>
> + (!AmlNodeHasOpCode (NamedNode, AML_NAME_OP, 0)))
>
> + {
>
> + ASSERT (0);
>
> + return EFI_INVALID_PARAMETER;
>
> + }
>
> +
>
> + PackageNode = (AML_OBJECT_NODE_HANDLE)AmlGetFixedArgument (
>
> + NamedNode,
>
> + EAmlParseIndexTerm1
>
> + );
>
> + if ((PackageNode == NULL) ||
>
> + (AmlGetNodeType ((AML_NODE_HANDLE)PackageNode) != EAmlNodeObject) ||
>
> + (!AmlNodeHasOpCode (PackageNode, AML_PACKAGE_OP, 0)))
>
> + {
>
> + ASSERT (0);
>
> + return EFI_INVALID_PARAMETER;
>
> + }
>
> +
>
> + Status = ConvertAslNameToAmlName (NameString, &AmlNameString);
>
> + if (EFI_ERROR (Status)) {
>
> + ASSERT (0);
>
> + return Status;
>
> + }
>
> +
>
> + Status = AmlGetNameStringSize (AmlNameString, &AmlNameStringSize);
>
> + if (EFI_ERROR (Status)) {
>
> + ASSERT (0);
>
> + goto exit_handler;
>
> + }
>
> +
>
> + Status = AmlCreateDataNode (
>
> + EAmlNodeDataTypeNameString,
>
> + (UINT8 *)AmlNameString,
>
> + AmlNameStringSize,
>
> + &DataNode
>
> + );
>
> + if (EFI_ERROR (Status)) {
>
> + ASSERT (0);
>
> + goto exit_handler;
>
> + }
>
> +
>
> + Status = AmlVarListAddTail (
>
> + (AML_NODE_HANDLE)PackageNode,
>
> + (AML_NODE_HANDLE)DataNode
>
> + );
>
> + ASSERT_EFI_ERROR (Status);
>
> +
>
> +exit_handler:
>
> + if (AmlNameString != NULL) {
>
> + FreePool (AmlNameString);
>
> + }
>
> +
[SAMI] I think the error handling code below can be moved after
AmlVarListAddTail() above and ASSERT_EFI_ERROR() can me removed. If you
agree, I will make this change before merging the series.
>
> + if (EFI_ERROR (Status)) {
>
> + if (DataNode != NULL) {
>
> + AmlDeleteTree ((AML_NODE_HANDLE)DataNode);
>
> + }
>
> + }
>
> +
>
> + return Status;
>
> +}
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108956): https://edk2.groups.io/g/devel/message/108956
Mute This Topic: https://groups.io/mt/101436338/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-09-21 16:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 15:46 [edk2-devel] [PATCH v4 0/4] Add support for generating ACPI ThermalZones Jeff Brasen via groups.io
2023-09-18 15:46 ` [edk2-devel] [PATCH v4 1/4] DynamicTablesPkg: Add ThermalZone CodeGen function Jeff Brasen via groups.io
2023-09-18 15:46 ` [edk2-devel] [PATCH v4 2/4] DynamicTablesPkg: Add support for simple method invocation Jeff Brasen via groups.io
2023-09-21 16:49 ` Sami Mujawar
2023-09-21 17:38 ` Jeff Brasen via groups.io
2023-09-21 20:07 ` Sami Mujawar
2023-09-21 20:48 ` Jeff Brasen via groups.io
2023-09-23 4:22 ` Attar, AbdulLateef (Abdul Lateef) via groups.io
2023-09-27 15:07 ` PierreGondois
2023-09-18 15:46 ` [edk2-devel] [PATCH v4 3/4] DynamicTablesPkg: Add support to add Strings to package Jeff Brasen via groups.io
2023-09-21 16:49 ` Sami Mujawar [this message]
2023-09-21 16:52 ` Jeff Brasen via groups.io
2023-09-18 15:47 ` [edk2-devel] [PATCH v4 4/4] DynamicTablesPkg: Add Aml NameUnicodeString API Jeff Brasen via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d81dd962-e834-9130-6704-257065d2c01e@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox