From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1A7A921197B32 for ; Wed, 12 Dec 2018 03:51:45 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 84E6B811D7; Wed, 12 Dec 2018 11:51:44 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-211.rdu2.redhat.com [10.10.120.211]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D18D19748; Wed, 12 Dec 2018 11:51:42 +0000 (UTC) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: Michael D Kinney , Liming Gao , Bob Feng , Leif Lindholm References: <20181212103308.8099-1-ard.biesheuvel@linaro.org> <20181212103308.8099-4-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: Date: Wed, 12 Dec 2018 12:51:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181212103308.8099-4-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 12 Dec 2018 11:51:44 +0000 (UTC) Subject: Re: [PATCH 3/3] ArmVirtPkg/PrePi ARM CLANG35: drop incompatible command line option X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2018 11:51:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/12/18 11:33, Ard Biesheuvel wrote: > Drop the -mno-movt command line option override, which is no longer > needed, and actually incompatible with versions of Clang before 3.6. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 ----- > ArmVirtPkg/ArmVirtXen.dsc | 5 ----- > 2 files changed, 10 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc > index c4324a9e264b..df125cfef646 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -69,11 +69,6 @@ [LibraryClasses.common.UEFI_DRIVER] > UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > > [BuildOptions.common.EDKII.SEC, BuildOptions.common.EDKII.BASE] > - # Avoid MOVT/MOVW instruction pairs in code that may end up in the PIE > - # executable we build for the relocatable PrePi. They are not runtime > - # relocatable in ELF. > - *_CLANG35_ARM_CC_FLAGS = -mno-movt > - > # > # CLANG38 with LTO support enabled uses the GNU GOLD linker, which insists > # on emitting GOT based symbol references when running in shared mode, unless > diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc > index e083666f54ea..a29d8a4ae717 100644 > --- a/ArmVirtPkg/ArmVirtXen.dsc > +++ b/ArmVirtPkg/ArmVirtXen.dsc > @@ -58,11 +58,6 @@ [LibraryClasses.common.UEFI_DRIVER] > UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > > [BuildOptions.common.EDKII.SEC, BuildOptions.common.EDKII.BASE] > - # Avoid MOVT/MOVW instruction pairs in code that may end up in the PIE > - # executable we build for the relocatable PrePi. They are not runtime > - # relocatable in ELF. > - *_CLANG35_ARM_CC_FLAGS = -mno-movt > - > # > # CLANG38 with LTO support enabled uses the GNU GOLD linker, which insists > # on emitting GOT based symbol references when running in shared mode, unless > Acked-by: Laszlo Ersek