From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: philmd@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 23 Sep 2019 02:49:16 -0700 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E017189AC2 for ; Mon, 23 Sep 2019 09:49:15 +0000 (UTC) Received: by mail-wm1-f69.google.com with SMTP id 190so6403209wme.4 for ; Mon, 23 Sep 2019 02:49:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=V0m1xidjpm7bhycNzh0i1Yo+Qpc04nILPUM2lPnfgcI=; b=p7TmSKYta+Voxy0JJ94mkhSOqK8FZs2QqKYTreBfq6mpNh1DD0pZ4hE9yJKjOYYdIz Oc5o4tYVWGCc7usiyEzzBHfec+Qk5/u4gnuZEmZe68BZeFpM4osPfqJEzb8/gOHh3C8U vo0bMphbxHf0A3M89/xQ9XpmFp33sVYCP4t9YP+XOnHfus/q5Oukv7AlCvfTefCdSFHG BoBd3gjxIFJuNZSaHQ3VgHElCz3Cq+FVKZhHvCNeL7L/glMm++Q1TFVFr3AfCTtI4V/L niXWLpyBsz/u7OL48vuhHK0lDhOwPiN/c3Y7Dd1IxqnfSuc8sDnRbZC/ZddKLFTXM0Sd Iodg== X-Gm-Message-State: APjAAAXERcAKp2F0guHtN3tV4alZS4BnEKyPClrrze3tteZ8Xx7BwlT2 mmQ5kEEt44KyX09LPC25clZXEVmGfRmGaKzO0XN35h5QE1MQbMSfrrx/mSAQ4ETl3FJU6miy0hZ aGudYBQ4S4A4MQA== X-Received: by 2002:adf:e908:: with SMTP id f8mr20387929wrm.210.1569232154672; Mon, 23 Sep 2019 02:49:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqxKZ4XJyZldhxAM2NTvKmsPnJrdf/xIGVNaE5AWp6kBFmDf3YWcUD172WwBqmojgsQSPLXfIA== X-Received: by 2002:adf:e908:: with SMTP id f8mr20387922wrm.210.1569232154500; Mon, 23 Sep 2019 02:49:14 -0700 (PDT) Received: from [192.168.1.40] (240.red-88-21-68.staticip.rima-tde.net. [88.21.68.240]) by smtp.gmail.com with ESMTPSA id e3sm5365280wme.39.2019.09.23.02.49.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Sep 2019 02:49:13 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 6/7] OvmfPkg: strip trailing whitespace To: devel@edk2.groups.io, leif.lindholm@linaro.org, Laszlo Ersek References: <20190919180625.29150-1-leif.lindholm@linaro.org> <20190919180625.29150-7-leif.lindholm@linaro.org> <20190920102436.GD28454@bivouac.eciton.net> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Mon, 23 Sep 2019 11:49:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190920102436.GD28454@bivouac.eciton.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/20/19 12:24 PM, Leif Lindholm wrote: > > On Fri, Sep 20, 2019 at 08:13:36AM +0200, Laszlo Ersek wrote: >> On 09/19/19 20:06, Leif Lindholm wrote: >>> Cc: Jordan Justen >>> Cc: Laszlo Ersek >>> Cc: Ard Biesheuvel >>> Cc: Anthony Perard >>> Cc: Julien Grall >>> Cc: David Woodhouse >>> Signed-off-by: Leif Lindholm >>> --- >>> OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c | 4 ++-- >>> OvmfPkg/AcpiPlatformDxe/Xen.c | 8 ++++---- >>> OvmfPkg/AcpiTables/Facs.aslc | 6 +++--- >>> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.Vfr | 18 +++++++++--------- >>> OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_32.h | 4 ++-- >>> OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_64.h | 4 ++-- >>> OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen.h | 4 ++-- >>> OvmfPkg/Include/IndustryStandard/Xen/hvm/params.h | 2 +- >>> OvmfPkg/Include/IndustryStandard/Xen/io/protocols.h | 2 +- >>> OvmfPkg/Include/IndustryStandard/Xen/io/ring.h | 34 +++++++++++++++++----------------- >>> OvmfPkg/Include/IndustryStandard/Xen/memory.h | 4 ++-- >>> OvmfPkg/Include/IndustryStandard/Xen/xen-compat.h | 4 ++-- >>> OvmfPkg/Include/IndustryStandard/Xen/xen.h | 10 +++++----- >>> OvmfPkg/Include/Register/QemuSmramSaveStateMap.h | 2 +- >>> OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c | 12 ++++++------ >>> OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 2 +- >>> OvmfPkg/Library/LockBoxLib/LockBoxLib.c | 2 +- >>> OvmfPkg/Library/LockBoxLib/LockBoxLib.h | 2 +- >>> OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.c | 4 ++-- >>> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 2 +- >>> OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.c | 2 +- >>> OvmfPkg/PlatformPei/Xen.c | 2 +- >>> OvmfPkg/SataControllerDxe/ComponentName.c | 6 +++--- >>> OvmfPkg/SataControllerDxe/SataController.c | 214 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------------------------------------------------- >>> OvmfPkg/SataControllerDxe/SataController.h | 208 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------------------------------------- >> >> (did you forget --stat-graph-width=20?) > > Hmm... > *scratches head* > First of all, I saw that before sending out and didn't even reflect on > it. Clearly past git-send-email-o-clock. > > Secondly, I have > [diff] > statGraphWidth = 20 > in .git/config from running SetupGit.py. > > Oh, rubbish. From git-diff manpage: > --- > The width of the graph part can be limited by using > --stat-graph-width= (affects all commands generating a stat > graph) or by setting diff.statGraphWidth= (does not affect git > format-patch). TIL this doesn't affect git-format-patch... Odd. > --- > I had missed that bit. So yeah, that setting in SetupGit.py is > completely meaningless. > (Why would you give those two different code paths?!?) > > Which given we already can't set --stat ... > Do you think it might be a good idea to set up a few standard aliases? > >>> OvmfPkg/SataControllerDxe/SataControllerDxe.inf | 6 +++--- >>> OvmfPkg/Sec/SecMain.c | 34 +++++++++++++++++----------------- >>> 27 files changed, 301 insertions(+), 301 deletions(-) >> >> I've checked this patch with "git show -b" (--> nothing) and "git show >> --word-diff" (--> output consists purely of context). >> >> Reviewed-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daude