From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.5668.1624443599044421314 for ; Wed, 23 Jun 2021 03:19:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=D67nGlvE; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624443598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QLETP1I9T6WXC8KHDml8xToyVy51SVkbfmnskbd2OSk=; b=D67nGlvE1xKwwjUMsIAEJR06ogSWclxtSJDvYcnfJJWYGvIrCv2RxxtTBCQ5yAWbszLBqW GeO2zsj/oz8KkP7mYdXZ50nGj07F0eYz0g7LE79iZLGsvhqGJ/ceEYTO8UkkfpSrZGm+jO Ah4IFkm2nvLHRMJH6iXwbWGy+xhwjFc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-548-u3Lrl60wPWmNfSKTUx56Kw-1; Wed, 23 Jun 2021 06:19:54 -0400 X-MC-Unique: u3Lrl60wPWmNfSKTUx56Kw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3FC62100C660; Wed, 23 Jun 2021 10:19:53 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-200.ams2.redhat.com [10.36.112.200]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0810C19C66; Wed, 23 Jun 2021 10:19:51 +0000 (UTC) Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSF0gTWRlTW9kdWxlUGtnL0J1cy9QY2kvUGNpQnVzRHhlOiBJbmNyZWFzZSB0aGUgd2lkdGggb2YgdGhlIGRhdGEgcmVhZCBkdXJpbmcgb3Byb20gc2hhZG93?= To: devel@edk2.groups.io, gaoliming@byosoft.com.cn, sumana.venur@intel.com, "'Ni, Ray'" , "'Wu, Hao A'" References: <20210611163744.19368-1-sumana.venur@intel.com> <004501d76318$c76fd940$564f8bc0$@byosoft.com.cn> From: "Laszlo Ersek" Message-ID: Date: Wed, 23 Jun 2021 12:19:50 +0200 MIME-Version: 1.0 In-Reply-To: <004501d76318$c76fd940$564f8bc0$@byosoft.com.cn> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 06/17/21 03:33, gaoliming wrote: > Create PR https://github.com/tianocore/edk2/pull/1728 for it. > > This patch has been reviewed by Ray Ni. Yes, here: https://edk2.groups.io/g/devel/message/70091 https://listman.redhat.com/archives/edk2-devel-archive/2021-January/msg00578.html msgid (FWIW, the repost should have included Ray's R-b.) Thanks Laszlo > > Thanks > Liming >> -----邮件原件----- >> 发件人: devel@edk2.groups.io 代表 Sumana >> Venur >> 发送时间: 2021年6月12日 1:02 >> 收件人: Ni, Ray ; Wu, Hao A >> 抄送: devel@edk2.groups.io >> 主题: Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase >> the width of the data read during oprom shadow >> >> Hello Maintainers >> >> This patch is for MdeModulePkg/Bus. Please review and help with merging to >> master >> It was sent a few months ago, might have been reviewed already. But due to >> CI failures and low importance it was lost. >> >> Gerrit link - https://git-amr-7.devtools.intel.com/gerrit/#/c/117842/ >> >> Thanks >> Sumana >> >> -----Original Message----- >> From: Venur, Sumana >> Sent: Friday, June 11, 2021 9:38 AM >> To: devel@edk2.groups.io >> Cc: Venur, Sumana >> Subject: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of >> the data read during oprom shadow >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2989 >> >> Long times spent on shadowing oprom from graphics card to system memory. >> We are currently using 8 bit read cycles. >> This needs to be wider, at least 32bit reads to reduce the time for oprom >> shadow >> >> Signed-off-by: Sumana Venur >> --- >> MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c >> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c >> index c994ed5fe3..a981f93f43 100644 >> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c >> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c >> @@ -521,9 +521,9 @@ LoadOpRomImage ( >> // >> PciDevice->PciRootBridgeIo->Mem.Read ( >> PciDevice->PciRootBridgeIo, >> - EfiPciWidthUint8, >> + EfiPciWidthUint32, >> RomBar, >> - (UINT32) RomImageSize, >> + (UINT32) >> RomImageSize/sizeof(UINT32), >> Image >> ); >> RomInMemory = Image; >> -- >> 2.16.2.windows.1 >> >> >> >> >> > > > > > > > >