From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.40]) by mx.groups.io with SMTP id smtpd.web11.22150.1590182309193230773 for ; Fri, 22 May 2020 14:18:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=FguhyOX8; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.236.40, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HlNSdc7f/ceC3XRNySMienFGH/NRF0QP7Tlj+t4r1qT/a/K25dwOMcY9C4CYwUyJ8LJ2s1x+/CzOdvJ+6QS6zkTc2V9NxbfOAepXoY5stPe+y/zQZufLVESCvF1ikFxXjovb/8kvPiJ2Z8c9Uf4ZXR4zZfy03q2kAE4eieFRrfeKCIKOTjPyMtSr2iRbeHWFtLg/4ZPDJuc2OBM+9W+siXQ73I1Py+h2BKluZdaZ8pa2oMzJMb36IYD+rkX6wnnacYRtem6YvQfoC/jaIDnenqmTU/Y8/w/Ai9rqiuzUQ3v5FATNsnkzQAeToJNKJa1/1AaOxR7I59UpuYM48Uv+gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iw11X+wxsT3BhWNNjmPr2a02+HiMH+0kXlOHY/df8V8=; b=fTWXwcO4HE7WsJ8XyTEK0l8uB4TJplUI92QLpw2Um87XWheF3sWrjhqruSvl4Vlhh8jSupRLCoe6jSu858aV0V9GjZDCPTcFp/KIYYP2eOnmjZudKOvRVt4mVLCZDmETx2RNS08aB/0npn9PVlRuFr2tTxd/aKRnYRSeTwrESYivl509DaSaC5x61WdumYYYbv804CBNozt0g3akE17ylBKdWNybl6ZTCNK7HaUC/NCDojk9lHGVjAlOk62xV+r8G4K82Ahh/14MCGKqTd8Km/PsX83mziinVqUFnqcZGSTQDOcs1MupmJJKB8HBhgT8IHOAU9Bl2lm5u+gvu8dO9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iw11X+wxsT3BhWNNjmPr2a02+HiMH+0kXlOHY/df8V8=; b=FguhyOX80ccDDJslLnydDGaS2U5L0z7UMzU+2EWujPmVN3kQ3taSMFExt0H69mP1opUxMAookMuWDaNQM7oRhZ+/TpDwjCMmRBgqbEO8mX9uM1+0L3gEulsHYi/Ceuihm0rjD9qtCbhZ/e/iS3sQByqIbB/5vnnP+N0/F9aJBg8= Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM5PR12MB1916.namprd12.prod.outlook.com (2603:10b6:3:112::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20; Fri, 22 May 2020 21:18:27 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::4ce1:9947:9681:c8b1]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::4ce1:9947:9681:c8b1%10]) with mapi id 15.20.3000.034; Fri, 22 May 2020 21:18:27 +0000 Subject: Re: [edk2-devel] [PATCH v8 22/46] OvmfPkg/VmgExitLib: Add support for VMMCALL NAE events To: devel@edk2.groups.io, lersek@redhat.com Cc: Jordan Justen , Ard Biesheuvel , Michael D Kinney , Liming Gao , Eric Dong , Ray Ni , Brijesh Singh , Ard Biesheuvel References: <0b9f13ded4d404ffee90a73848fc67b91010269f.1589925074.git.thomas.lendacky@amd.com> From: "Lendacky, Thomas" Message-ID: Date: Fri, 22 May 2020 16:18:24 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 In-Reply-To: X-ClientProxiedBy: SN1PR12CA0101.namprd12.prod.outlook.com (2603:10b6:802:21::36) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from office-linux.texastahm.com (67.79.209.213) by SN1PR12CA0101.namprd12.prod.outlook.com (2603:10b6:802:21::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23 via Frontend Transport; Fri, 22 May 2020 21:18:26 +0000 X-Originating-IP: [67.79.209.213] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 22d4a0e1-a889-4f72-e959-08d7fe95ab09 X-MS-TrafficTypeDiagnostic: DM5PR12MB1916: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-Forefront-PRVS: 04111BAC64 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qK3heMoVTKDfRv/0PTOVriUPpq4cSfceUQr4aVWzVDwRiYxkDJfjMOFzw1khWj/Y37krhktHEtqUkH8SF1U3TSFE1K4ScSaZjbSYAOwXBu7w+bCv4WHtMgbBFiTFkyFNgClhXEzOnwvTuXz5Db1rziDkmTdaB1qKlQnIQPOmjFet/vjvTNl79QZRlrrlN4LE89E1RvKbz8jC0Qgr/PG6ZjKOM3y6GDbWdtxZLA3R1VIQgBztb8M7z4ZkV7WU+NqgKDCPXTSg61qz8O9FuMIpyNYjax0ZcHRZZzZJbAZpUa0Cp0HZ4bu9nkMVM30OEOUFp4yV6bRWX10iV2/0j+gs0uDQnph6ZXWT5Bx2ENxhtXQFn8Wh2diZ0QkelHlzFw4vr/khlGwHlBI9lRQ0paMe5Ab4VsqQohQq06fBgduFyShgpTfU32CjGi+mkolhOYzMr31Z1J39vXDl6RM8/MFy8oWizz1PBbJYdTTjMSclC+VK47iVjWcDm2zrYgV55kyIN40YAFfqEqJXQhLUY+M5Lj3MoXmFocDcU3u8RJPMxd9PP4TXo5R4yGtK0Ydt66gEEqsRfNPIsRBqkenq4wKwvQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(376002)(346002)(136003)(366004)(39860400002)(4326008)(966005)(26005)(6512007)(6506007)(53546011)(66556008)(186003)(66476007)(316002)(6486002)(16526019)(66946007)(5660300002)(36756003)(45080400002)(54906003)(2906002)(478600001)(31696002)(86362001)(52116002)(2616005)(956004)(8676002)(19627235002)(31686004)(8936002)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: Y29PsnKl2Z+mNpPSGvoSsdPCvdfCNeyh6iFg7PnFGp0Isk2wla0ktAL/Sy3oWZRobnu6l7cxi3qRHDB1hY3Otr/elmX7BgARRsRPd0Pr4RPIVYlm0ivLTyBEbGwDTcznj0KKp07Xoc/TZo6RB0vdjCJiyRGDgLXFVI6k5RXkQmfhIRXLH/bJGWTLDmnQ8lzzKSzQJ2JBSXtE56W+/f8CnxW+DSe9VEOaXEukV6qOBkzX5MxuTmON/op+WC0KRf7cEdQNTEXEVj2XXA/AR6Gw2+WP2cr5t0dAduvnaA/5+Dpd29F6E4iLzE1jQJwdfbVXAe/aiPkzYal2ZVrhf6VRavgM9N3lR5vMJpQi1ym6Jbkojcpn6XTJXAz/WcLil4KQK05UT9Bpt/Gxr2itUeaxN/zv665kHPC81HGQED4z91Xnhfldao/Np6M4tWVMyhcFZCaLnYLQSF8HNO7VvBJJPOkNvWZU5nSrG+bb4VGGptw= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22d4a0e1-a889-4f72-e959-08d7fe95ab09 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2020 21:18:27.2298 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h6t9mQTlCvIepsRX3IHuvZ2jqBlV6rR1rsN2lD69qPA5CmMtFJUOhJrw07wqTkg+6GX85X7ohZTvZi8M8idbEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1916 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 5/22/20 9:50 AM, Laszlo Ersek via groups.io wrote: > On 05/22/20 16:48, Laszlo Ersek wrote: >> On 05/19/20 23:50, Lendacky, Thomas wrote: >>> BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=02%7C01%7Cthomas.lendacky%40amd.com%7Cba73e0d6ccb9488ab10608d7fe5f7c8f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637257558381229776&sdata=kwjA9Hgo1KKgY%2FarqEiQFDg5QVpx60Kfoh1AWqSuock%3D&reserved=0 >>> >>> Under SEV-ES, a VMMCALL intercept generates a #VC exception. VMGEXIT must >>> be used to allow the hypervisor to handle this intercept. >>> >>> Cc: Jordan Justen >>> Cc: Laszlo Ersek >>> Cc: Ard Biesheuvel >>> Signed-off-by: Tom Lendacky >>> --- >>> .../Library/VmgExitLib/X64/VmgExitVcHandler.c | 48 +++++++++++++++++++ >>> 1 file changed, 48 insertions(+) >>> >>> diff --git a/OvmfPkg/Library/VmgExitLib/X64/VmgExitVcHandler.c b/OvmfPkg/Library/VmgExitLib/X64/VmgExitVcHandler.c >>> index 0b7f24fd962c..bf1555234d69 100644 >>> --- a/OvmfPkg/Library/VmgExitLib/X64/VmgExitVcHandler.c >>> +++ b/OvmfPkg/Library/VmgExitLib/X64/VmgExitVcHandler.c >>> @@ -875,6 +875,50 @@ WbinvdExit ( >>> return 0; >>> } >>> >>> +/** >>> + Handle a VMMCALL event. >>> + >>> + Use the VMGEXIT instruction to handle either a VMMCALL event. > > (2) pls drop the word "either". I have this in a couple of places, so I'll take care of all of them. Thanks! TOm > > Thanks > Laszlo > >>> + >>> + @param[in, out] Ghcb Pointer to the Guest-Hypervisor Communication >>> + Block >>> + @param[in, out] Regs x64 processor context >>> + @param[in] InstructionData Instruction parsing context >>> + >>> + @retval 0 Event handled successfully >>> + @retval Others New exception value to propagate >>> + >>> +**/ >>> +STATIC >>> +UINT64 >>> +VmmCallExit ( >>> + IN OUT GHCB *Ghcb, >>> + IN OUT EFI_SYSTEM_CONTEXT_X64 *Regs, >>> + IN SEV_ES_INSTRUCTION_DATA *InstructionData >>> + ) >>> +{ >>> + UINT64 Status; >>> + >>> + DecodeModRm (Regs, InstructionData); >>> + >>> + Ghcb->SaveArea.Rax = Regs->Rax; >>> + GhcbSetRegValid (Ghcb, GhcbRax); >>> + Ghcb->SaveArea.Cpl = (UINT8) (Regs->Cs & 0x3); >>> + GhcbSetRegValid (Ghcb, GhcbCpl); >>> + >>> + Status = VmgExit (Ghcb, SVM_EXIT_VMMCALL, 0, 0); >>> + if (Status) { >> >> (1) Please write (Status > 0) or (Status != 0). >> >> Acked-by: Laszlo Ersek >> >> Thanks >> Laszlo >> >>> + return Status; >>> + } >>> + >>> + if (!GhcbIsRegValid (Ghcb, GhcbRax)) { >>> + return UnsupportedExit (Ghcb, Regs, InstructionData); >>> + } >>> + Regs->Rax = Ghcb->SaveArea.Rax; >>> + >>> + return 0; >>> +} >>> + >>> /** >>> Handle an MSR event. >>> >>> @@ -1395,6 +1439,10 @@ VmgExitHandleVc ( >>> NaeExit = MsrExit; >>> break; >>> >>> + case SVM_EXIT_VMMCALL: >>> + NaeExit = VmmCallExit; >>> + break; >>> + >>> case SVM_EXIT_WBINVD: >>> NaeExit = WbinvdExit; >>> break; >>> >> > > > >