Re: [edk2-devel] [PATCH 2/3] Maintainers.txt: mark EmbeddedPkg MmcDxe as Obsolete

["Laszlo Ersek" <lersek@redhat.com>]

On 04/29/20 18:36, Leif Lindholm wrote:
> The EmbeddedPkg MmcDxe duplicates definitions an functionality

s/ an / and /

> also available in MdeModulePkg. New platforms should not be
> making use of this, and old platforms should consider migrating -
> indicate this properly by creating a separate section in
> Maintainers.txt and marking it "Obsolete".
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Leif Lindholm <leif@nuviainc.com>
> ---
>  Maintainers.txt | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 1733225722b6..4d62e0b334f3 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -172,10 +172,17 @@ M: Alexei Fedorov <Alexei.Fedorov@arm.com>
>  
>  EmbeddedPkg
>  F: EmbeddedPkg/
> +X: EmbeddedPkg/Include/Protocol/MmcHost.h
> +X: EmbeddedPkg/Universal/MmcDxe/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg
>  M: Leif Lindholm <leif@nuviainc.com>
>  M: Ard Biesheuvel <ard.biesheuvel@arm.com>
>  
> +EmbeddedPkg obsolete code
> +F: EmbeddedPkg/Include/Protocol/MmcHost.h
> +F: EmbeddedPkg/Universal/MmcDxe/
> +S: Obsolete
> +
>  EmulatorPkg
>  F: EmulatorPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/EmulatorPkg
> 

Can't comment on EmbeddedPkg MmcDxe, but formally, the patch is pleasing.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>