From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web11.1597.1588191187193906157 for ; Wed, 29 Apr 2020 13:13:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=b6Mkdzfo; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588191186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=79bfqbH+imIos07PsOaq7OwZ+1OwZgQdWO5NVsXsnbQ=; b=b6MkdzfocO2S8/twXT0wb4D13MB+9y14HPzGw7hGWXhMxoXWP/ppoc99W6fZFiOHreJQf5 KJzxWEBeMITkiBkI9RwSI27nE9gKtD2UeUPQJwEiTmzDm+88hY/eznYLBAmIAHRNzX/GoW p2dJwvf7aRD+pIIgMc5nXOZjaDzik+c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-382-YDnbstxHN0Ko6cX5h7JJmg-1; Wed, 29 Apr 2020 16:13:02 -0400 X-MC-Unique: YDnbstxHN0Ko6cX5h7JJmg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 53A021005510; Wed, 29 Apr 2020 20:13:01 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-1.ams2.redhat.com [10.36.114.1]) by smtp.corp.redhat.com (Postfix) with ESMTP id 065891057FCB; Wed, 29 Apr 2020 20:12:59 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 2/3] Maintainers.txt: mark EmbeddedPkg MmcDxe as Obsolete To: devel@edk2.groups.io, leif@nuviainc.com Cc: Andrew Fish , Ard Biesheuvel , Michael D Kinney References: <20200429163616.5951-1-leif@nuviainc.com> <20200429163616.5951-3-leif@nuviainc.com> From: "Laszlo Ersek" Message-ID: Date: Wed, 29 Apr 2020 22:12:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200429163616.5951-3-leif@nuviainc.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 04/29/20 18:36, Leif Lindholm wrote: > The EmbeddedPkg MmcDxe duplicates definitions an functionality s/ an / and / > also available in MdeModulePkg. New platforms should not be > making use of this, and old platforms should consider migrating - > indicate this properly by creating a separate section in > Maintainers.txt and marking it "Obsolete". > > Cc: Andrew Fish > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > Cc: Michael D Kinney > Signed-off-by: Leif Lindholm > --- > Maintainers.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 1733225722b6..4d62e0b334f3 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -172,10 +172,17 @@ M: Alexei Fedorov > > EmbeddedPkg > F: EmbeddedPkg/ > +X: EmbeddedPkg/Include/Protocol/MmcHost.h > +X: EmbeddedPkg/Universal/MmcDxe/ > W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg > M: Leif Lindholm > M: Ard Biesheuvel > > +EmbeddedPkg obsolete code > +F: EmbeddedPkg/Include/Protocol/MmcHost.h > +F: EmbeddedPkg/Universal/MmcDxe/ > +S: Obsolete > + > EmulatorPkg > F: EmulatorPkg/ > W: https://github.com/tianocore/tianocore.github.io/wiki/EmulatorPkg > Can't comment on EmbeddedPkg MmcDxe, but formally, the patch is pleasing. Reviewed-by: Laszlo Ersek