public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zeng, Star" <star.zeng@intel.com>
To: Liming Gao <liming.gao@intel.com>, edk2-devel@lists.01.org
Cc: star.zeng@intel.com
Subject: Re: [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch
Date: Fri, 26 Oct 2018 11:28:37 +0800	[thread overview]
Message-ID: <d88d08af-c892-ca79-9deb-fa22dbc511dd@intel.com> (raw)
In-Reply-To: <20181026015736.21764-1-liming.gao@intel.com>

On 2018/10/26 9:57, Liming Gao wrote:
> SmmLockBoxPeiLib.inf depends on PcdDxeIplSwitchToLongMode. But, this PCD is
> defined in MdeModulePkg.dec for IA32 and X64 only.

Could we explain more in the commit log about why this change is not 
needed before but required now?

Thanks,
Star
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
>   MdeModulePkg/MdeModulePkg.dsc | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
> index 2465d39..e88516d 100644
> --- a/MdeModulePkg/MdeModulePkg.dsc
> +++ b/MdeModulePkg/MdeModulePkg.dsc
> @@ -120,6 +120,8 @@
>     HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
>     MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
>     ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
> +
> +[LibraryClasses.IA32.PEIM, LibraryClasses.X64.PEIM]
>     LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf
>   
>   [LibraryClasses.common.DXE_CORE]
> 



  reply	other threads:[~2018-10-26  3:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-26  1:57 [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch Liming Gao
2018-10-26  3:28 ` Zeng, Star [this message]
2018-10-26  3:43   ` Gao, Liming
2018-10-26  4:28     ` Zeng, Star
2018-10-26  5:05       ` Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d88d08af-c892-ca79-9deb-fa22dbc511dd@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox