From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.sgi.com [192.48.180.66]) by ml01.01.org (Postfix) with ESMTP id 040381A1E2A for ; Fri, 14 Oct 2016 12:39:32 -0700 (PDT) Received: from xmail.sgi.com (pv-excas3-dc21.corp.sgi.com [137.38.106.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id 1256E8F8035; Fri, 14 Oct 2016 12:39:30 -0700 (PDT) Received: from [128.162.232.243] (128.162.232.243) by xmail.sgi.com (137.38.106.6) with Microsoft SMTP Server (TLS) id 14.3.301.0; Fri, 14 Oct 2016 14:39:30 -0500 To: Ryan Harkin , Leif Lindholm References: <20161007155942.GD3471@bivouac.eciton.net> CC: Laszlo Ersek , Roy Franz , "edk2-devel@lists.01.org" , Feng Tian , Star Zeng From: "Brian J. Johnson" Message-ID: Date: Fri, 14 Oct 2016 14:39:29 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [128.162.232.243] Subject: Re: [PATCH 0/3] MdeModulePkg/TerminalDxe: TtyTerm improvements X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2016 19:39:32 -0000 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit On 10/12/2016 03:17 AM, Ryan Harkin wrote: > On 7 October 2016 at 16:59, Leif Lindholm wrote: >> Roy can now be found at Roy Franz (cc:d). >> >> On Fri, Oct 07, 2016 at 05:56:26PM +0200, Laszlo Ersek wrote: >>> Roy, Ryan, >>> >>> On 10/07/16 16:53, Brian J. Johnson wrote: >>>> This patch series implements some improvements to the TtyTerm terminal >>>> type in the TerminalDxe driver. It fixes an end case with cursor >>>> position tracking, and uses that to optimize cursor motion escape >>>> sequences. It also adds support for the page up, page down, insert, >>>> home, and end keys on some additional common terminal emulators. >>>> >>>> The result is improved performance, especially at the shell prompt, >>>> and better compatibility with common terminal emulators. In >>>> particular, as a side effect of the optimized cursor motion, terminal >>>> windows which are taller than the current mode setting (eg. 25 lines) >>>> work much better than before. >>>> >>>> Most of these fixes have been in production in some form on SGI's >>>> servers for years. >>>> >>>> Contributed-under: TianoCore Contribution Agreement 1.0 >>>> Signed-off-by: Brian Johnson >>>> Cc: Feng Tian >>>> Cc: Star Zeng >>>> >>>> Brian J. Johnson (3): >>>> MdeModulePkg/TerminalDxe: Improve TtyTerm cursor position tracking >>>> MdeModulePkg/TerminalDxe: Optimize TtyTerm cursor motion >>>> MdeModulePkg/TerminalDxe: Handle more keys with TtyTerm >>>> >>>> .../Universal/Console/TerminalDxe/Terminal.h | 2 + >>>> .../Universal/Console/TerminalDxe/TerminalConIn.c | 24 +++++++-- >>>> .../Universal/Console/TerminalDxe/TerminalConOut.c | 61 ++++++++++++++++++++-- >>>> 3 files changed, 79 insertions(+), 8 deletions(-) >>>> >>> >>> can you please provide feedback (testing or otherwise) on this series? >>> > > Well, they "work" for me and I'd be happy with them being submitted. > > Tested-by: Ryan Harkin > > The only curious effect I can see is the Print(L"xxx"); lines that > expect the \n to be missing will no longer "work". For example, I > carry a patch by Daniil Egranov titled > "IntelFrameworkModulePkg/BdsDxe: Show boot timeout message" and it no > longer displays the countdown on the same line each time, it prints > each message on a new line. > > However, I don't see that as a blocking point, Daniil's patch could be > changed easily and there are other advantages to this series that make > it worthwhile, IMO, eg, Shell commands with lots of output (like > "help" or "dir fs0:") no longer create an awful mess on the serial > console. > So, is this just waiting for a maintainer's review? -- Brian J. Johnson -------------------------------------------------------------------- My statements are my own, are not authorized by SGI, and do not necessarily represent SGI’s positions.