public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: <Jayanth.Raghuram@dell.com>
To: <liming.gao@intel.com>, <devel@edk2.groups.io>
Cc: <Wei.G.Liu@dell.com>
Subject: Re: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.
Date: Tue, 27 Aug 2019 18:29:58 +0000	[thread overview]
Message-ID: <d8cca8f8601442fd97f68b96bd715b34@ausx13mps324.AMER.DELL.COM> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DCA9B@SHSMSX104.ccr.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1995 bytes --]

Hi Liming,

I sent the review request based on the description in the links that you mentioned below.
I sent it in an Dell Email since I cannot use GIT SMTP to send email out from our servers.
Please let me know what is wrong and I can help rectify that.

Regards
Jayanth Raghuram
DellEMC | Server Platform BIOS
office + 1 512 723 1470

From: Gao, Liming <liming.gao@intel.com>
Sent: Monday, August 26, 2019 8:57 PM
To: devel@edk2.groups.io; Raghuram, Jayanth
Cc: Liu, Wei G
Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.


[EXTERNAL EMAIL]
Can you follow this process to send this patch again?
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

And, the commit message format is
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format

Thanks
Liming
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> [mailto:devel@edk2.groups.io] On Behalf Of Jayanth.Raghuram@dell.com<mailto:Jayanth.Raghuram@dell.com>
Sent: Tuesday, August 27, 2019 3:55 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Wei.G.Liu@dell.com<mailto:Wei.G.Liu@dell.com>
Subject: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.

Subject: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.
Added checks for return parameters of LocateHandleBuffer & GetSupportedTypes
function calls in InternalHstiFindAip to improve error handling. An issue was
observed on Dell Poweredge R740, where the Dell PERC H740P controller UEFI
driver returned InfoTypesBuffer = NULL, InfoTypesBufferCount = 0 and caused
an FreePool assert.

Signed-off-by: Jayanth Raghuram <Jayanth.Raghuram@Dell.com<mailto:Jayanth.Raghuram@Dell.com>>
Cc: Wei G Liu <Wei_G_Liu@Dell.com<mailto:Wei_G_Liu@Dell.com>>

Attached: 0001-MdePkg-DxeHstiLib-Added-checks-to-improve-error-hand.patch

Regards
Jayanth Raghuram
DellEMC | Server Platform BIOS
office + 1 512 723 1470



[-- Attachment #2: Type: text/html, Size: 8976 bytes --]

  reply	other threads:[~2019-08-27 18:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-26 19:54 [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling Jayanth.Raghuram
2019-08-27  1:56 ` Liming Gao
2019-08-27 18:29   ` Jayanth.Raghuram [this message]
2019-08-28  7:59     ` Liming Gao
2019-08-28 17:33       ` [edk2-devel] " Ni, Ray
2019-08-29  1:19         ` Jayanth.Raghuram
2019-08-29 14:28           ` Liming Gao
2019-08-29  9:49         ` Leif Lindholm
2019-08-29 14:24           ` Laszlo Ersek
2019-08-29 17:02             ` Ni, Ray
2019-08-30  2:21               ` Nate DeSimone
2019-08-30 11:52                 ` Laszlo Ersek
2019-08-30 11:49               ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8cca8f8601442fd97f68b96bd715b34@ausx13mps324.AMER.DELL.COM \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox