From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@dell.com header.s=smtpout1 header.b=DZw9ZC2b; spf=pass (domain: dell.com, ip: 148.163.133.20, mailfrom: jayanth.raghuram@dell.com) Received: from mx0a-00154904.pphosted.com (mx0a-00154904.pphosted.com [148.163.133.20]) by groups.io with SMTP; Tue, 27 Aug 2019 11:30:03 -0700 Received: from pps.filterd (m0170389.ppops.net [127.0.0.1]) by mx0a-00154904.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x7RI5ffA024269 for ; Tue, 27 Aug 2019 14:30:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=smtpout1; bh=LM9eDlbftmb62vAtVgzFnrW9ooNiQz7uWFAEi8KAeAk=; b=DZw9ZC2bJJfoWnR5wp4A+qUtbvDwj1NS/ZVtqlcn2DPiDylXNGmLT5CRnTpYvNc8cQiO rEKOtr1QxxUgcRp5h2Ywnb25AOqHXPw+bxYHfJE3GqhG3f7tN62tcAxE0IbsB9TNZMsY Yo5tYTuN4yUv8g2ba09oLOK+L2XYiJHDmxKss8+7b1z+8BKylq6CU08ZHY0LdIulQrrF cyuflqabUaVZimd+mTr3H/KSwLeci2VvswaAuvFfofErzEMhrga4NrjchgLkE1wcHAnH qEACSOr8y9HKv0ZfIOQ2IVfqf9IPYRkxeRz5qj3OGPNyhlHU4hZCcvU+IqOmRQ1TLmmb VA== Received: from mx0b-00154901.pphosted.com (mx0b-00154901.pphosted.com [67.231.157.37]) by mx0a-00154904.pphosted.com with ESMTP id 2uk2fxnanv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 27 Aug 2019 14:30:01 -0400 Received: from pps.filterd (m0134318.ppops.net [127.0.0.1]) by mx0a-00154901.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x7RIRVYk126599 for ; Tue, 27 Aug 2019 14:30:00 -0400 Received: from ausxipps301.us.dell.com (ausxipps301.us.dell.com [143.166.148.223]) by mx0a-00154901.pphosted.com with ESMTP id 2uk269sujt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 27 Aug 2019 14:30:00 -0400 X-LoopCount0: from 10.166.132.132 X-PREM-Routing: D-Outbound X-IronPort-AV: E=Sophos;i="5.60,349,1549951200"; d="scan'208,217";a="388261410" From: To: , CC: Subject: Re: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. Thread-Topic: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. Thread-Index: AdVcR+OPrxJmOcouRhWzA1r7t1m4TQAMoO6AACKbwDA= Date: Tue, 27 Aug 2019 18:29:58 +0000 Message-ID: References: <31e5cee5c49d4381bfb26a0968c11749@ausx13mps324.AMER.DELL.COM> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DCA9B@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DCA9B@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Enabled=True; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_SiteId=945c199a-83a2-4e80-9f8c-5a91be5752dd; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Owner=Jayanth_Raghuram@Dell.com; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_SetDate=2019-08-27T18:29:51.9154452Z; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Name=External Public; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Application=Microsoft Azure Information Protection; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Extended_MSFT_Method=Manual; aiplabel=External Public x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-08-27_03:2019-08-27,2019-08-27 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 phishscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 spamscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 mlxlogscore=511 adultscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1906280000 definitions=main-1908270177 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 malwarescore=0 impostorscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 mlxlogscore=651 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1906280000 definitions=main-1908240102 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_d8cca8f8601442fd97f68b96bd715b34ausx13mps324AMERDELLCOM_" --_000_d8cca8f8601442fd97f68b96bd715b34ausx13mps324AMERDELLCOM_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming, I sent the review request based on the description in the links that you m= entioned below. I sent it in an Dell Email since I cannot use GIT SMTP to send email out f= rom our servers. Please let me know what is wrong and I can help rectify that. Regards Jayanth Raghuram DellEMC | Server Platform BIOS office + 1 512 723 1470 From: Gao, Liming Sent: Monday, August 26, 2019 8:57 PM To: devel@edk2.groups.io; Raghuram, Jayanth Cc: Liu, Wei G Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error hand= ling. [EXTERNAL EMAIL] Can you follow this process to send this patch again? https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-P= rocess And, the commit message format is https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Forma= t Thanks Liming From: devel@edk2.groups.io [mailto:devel@edk2= .groups.io] On Behalf Of Jayanth.Raghuram@dell.com Sent: Tuesday, August 27, 2019 3:55 AM To: devel@edk2.groups.io Cc: Wei.G.Liu@dell.com Subject: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve e= rror handling. Subject: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling= . Added checks for return parameters of LocateHandleBuffer & GetSupportedTyp= es function calls in InternalHstiFindAip to improve error handling. An issue = was observed on Dell Poweredge R740, where the Dell PERC H740P controller UEFI driver returned InfoTypesBuffer =3D NULL, InfoTypesBufferCount =3D 0 and c= aused an FreePool assert. Signed-off-by: Jayanth Raghuram > Cc: Wei G Liu > Attached: 0001-MdePkg-DxeHstiLib-Added-checks-to-improve-error-hand.patch Regards Jayanth Raghuram DellEMC | Server Platform BIOS office + 1 512 723 1470 --_000_d8cca8f8601442fd97f68b96bd715b34ausx13mps324AMERDELLCOM_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Liming,

 

I sent the review request based on the description = in the links that you mentioned below.

I sent it in an Dell Email since I cannot use GIT S= MTP to send email out from our servers.

Please let me know what is wrong and I can help rec= tify that.

 

Regards

Jayanth Raghuram=

DellEMC | Server Platform BIOS

office + 1 512 723 1470

 

From: Gao, Liming <liming.gao@intel.com&g= t;
Sent: Monday, August 26, 2019 8:57 PM
To: devel@edk2.groups.io; Raghuram, Jayanth
Cc: Liu, Wei G
Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve err= or handling.

 

[EXTERNAL EMAIL]

Can you follow this p= rocess to send this patch again?

htt= ps://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Proce= ss

 

And, the commit messa= ge format is

https://= github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format

 

Thanks

Liming

From: devel@edk2.groups.io [mailto:= devel@edk2.groups.io] On Behalf Of Jayanth.R= aghuram@dell.com
Sent: Tuesday, August 27, 2019 3:55 AM
To: devel@edk2.groups.io
Cc: Wei.G.Liu@dell.com Subject: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to im= prove error handling.

 

Subject: [PATCH] MdePkg/DxeHstiLib: Added checks to= improve error handling.

Added checks for return parameters of LocateHandleB= uffer & GetSupportedTypes

function calls in InternalHstiFindAip to improve er= ror handling. An issue was

observed on Dell Poweredge R740, where the Dell PER= C H740P controller UEFI

driver returned InfoTypesBuffer =3D NULL, InfoTypes= BufferCount =3D 0 and caused

an FreePool assert.

 

Signed-off-by: Jayanth Raghuram <Jayanth.Raghuram@Dell.com><= /p>

Cc: Wei G Liu <Wei_G_Liu@Dell.com>

 

Attached: 0001-MdePkg-DxeHstiLib-Added-checks-to-im= prove-error-hand.patch

 

Regards

Jayanth Raghuram=

DellEMC | Server Platform BIOS

office + 1 512 723 1470

 

--_000_d8cca8f8601442fd97f68b96bd715b34ausx13mps324AMERDELLCOM_--