From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.4694.1671574784234822079 for ; Tue, 20 Dec 2022 14:19:44 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=XtBq3o+O; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id 2464520C335C; Tue, 20 Dec 2022 14:19:43 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2464520C335C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1671574783; bh=peo+D7wLzxJlUD2yQceby/epB6SBXtSZl4swSPLIj4g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=XtBq3o+OeDMAL1Pxh9X5xNfBWrZ8rG2QQieIzhUCqpeiCBNpzQcdz4NXjmwIWYkN2 M5wHwjMOHPXB02wyzYXbk1OnKVEVZ7MpeEewXaLQLGzDht3jdzGqBtlRKStjfgquJb F7WDW8Tt9V3KZM/47q0hIp1CZhNMFFp45v8oXU6M= Message-ID: Date: Tue, 20 Dec 2022 17:19:42 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [edk2-devel] [PATCH v3 01/14] PrmPkg: Fix new typos reported To: devel@edk2.groups.io, ankit.sinha@intel.com Cc: "Desimone, Nathaniel L" References: <20221214225252.1660-1-mikuback@linux.microsoft.com> <20221214225252.1660-2-mikuback@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks Ankit On 12/19/2022 10:09 PM, Ankit Sinha wrote: > Hi Michael, > > There is a typo that got missed in one of the modified comments. In file "b/PrmPkg/Include/Library/PrmModuleDiscoveryLib.h": > > - Each PRM Module discovered is placed into a linked list so the list can br processsed in the future. > + Each PRM Module discovered is placed into a linked list so the list can br processed in the future. > > 'br' should change to 'be' > > Thank you, > Ankit > >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Michael >> Kubacki >> Sent: Wednesday, December 14, 2022 2:53 PM >> To: devel@edk2.groups.io >> Cc: Michael Kubacki ; Desimone, Nathaniel >> L ; Sinha, Ankit >> Subject: [edk2-devel] [PATCH v3 01/14] PrmPkg: Fix new typos reported >> >> From: Michael Kubacki >> >> The SpellCheck plugin began reporting new typos that were previously >> missed. This change fixes those typos. >> >> Cc: Michael Kubacki >> Cc: Nate DeSimone >> Cc: Ankit Sinha >> Signed-off-by: Michael Kubacki >> --- >> PrmPkg/Application/PrmInfo/PrmInfo.c >> | 2 +- >> PrmPkg/Library/DxePrmModuleDiscoveryLib/DxePrmModuleDiscoveryLib.c >> | 2 +- >> PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c >> | 2 +- >> >> UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTestU >> efiBootServicesTableLibImage.c | 2 +- >> >> UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTestU >> efiBootServicesTableLibProtocol.c | 2 +- >> PrmPkg/Include/Library/PrmModuleDiscoveryLib.h >> | 2 +- >> PrmPkg/PrmLoaderDxe/PrmAcpiTable.h >> | 4 ++-- >> PrmPkg/PrmPkg.ci.yaml | 9 >> +++++++++ >> >> UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTestU >> efiBootServicesTableLib.h | 4 ++-- >> 9 files changed, 19 insertions(+), 10 deletions(-) >> >> diff --git a/PrmPkg/Application/PrmInfo/PrmInfo.c >> b/PrmPkg/Application/PrmInfo/PrmInfo.c >> index 0cde2fad3b4b..178d4810f498 100644 >> --- a/PrmPkg/Application/PrmInfo/PrmInfo.c >> +++ b/PrmPkg/Application/PrmInfo/PrmInfo.c >> @@ -148,7 +148,7 @@ PrintMmioRuntimeRangeInfo ( >> Gathers the PRM handler (and by extension module) information >> discovered on this system. >> >> This function must be called to build up the discovered context for other >> functions in the application. The >> - function will optionally print results as determed by the value of the >> PrintInformation parameter. >> + function will optionally print results as determined by the value of the >> PrintInformation parameter. >> >> @param[in] PrintInformation Indicates whether to print information >> as discovered in the function. >> >> diff --git >> a/PrmPkg/Library/DxePrmModuleDiscoveryLib/DxePrmModuleDiscoveryLib. >> c >> b/PrmPkg/Library/DxePrmModuleDiscoveryLib/DxePrmModuleDiscoveryLib. >> c >> index e6bea47bc583..34373effd4cd 100644 >> --- >> a/PrmPkg/Library/DxePrmModuleDiscoveryLib/DxePrmModuleDiscoveryLib. >> c >> +++ >> b/PrmPkg/Library/DxePrmModuleDiscoveryLib/DxePrmModuleDiscoveryLib. >> c >> @@ -149,7 +149,7 @@ IsAddressInMmram ( >> /** >> Discovers all PRM Modules loaded during boot. >> >> - Each PRM Module discovered is placed into a linked list so the list can br >> processsed in the future. >> + Each PRM Module discovered is placed into a linked list so the list can br >> processed in the future. >> >> @param[out] ModuleCount An optional pointer parameter that, if >> provided, is set to the number >> of PRM modules discovered. >> diff --git a/PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c >> b/PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c >> index 5a223d783d80..7b0042f133ef 100644 >> --- a/PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c >> +++ b/PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c >> @@ -295,7 +295,7 @@ PublishPrmAcpiTable ( >> time of this function invocation. >> >> The main responsibilities of the PRM Loader are executed from this >> function which include 3 phases: >> - 1.) Disover PRM Modules - Find all PRM modules loaded during DXE >> dispatch and insert a PRM Module >> + 1.) Discover PRM Modules - Find all PRM modules loaded during DXE >> + dispatch and insert a PRM Module >> Context entry into a linked list to be handed off to phase 2. >> 2.) Process PRM Modules - Build a GUID to PRM handler mapping for each >> module that is described in the >> PRM ACPI table so the OS can resolve a PRM Handler GUID to the >> corresponding PRM Handler physical address. >> diff --git >> a/UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTest >> UefiBootServicesTableLibImage.c >> b/UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTest >> UefiBootServicesTableLibImage.c >> index 144cc33e25c0..7c1c4b854b65 100644 >> --- >> a/UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTest >> UefiBootServicesTableLibImage.c >> +++ b/UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/Unit >> +++ TestUefiBootServicesTableLibImage.c >> @@ -130,7 +130,7 @@ UnitTestExit ( >> @retval EFI_SUCCESS The image has been unloaded. >> @retval EFI_UNSUPPORTED The image has been started, and does not >> support >> unload. >> - @retval EFI_INVALID_PARAMPETER ImageHandle is not a valid image >> handle. >> + @retval EFI_INVALID_PARAMETER ImageHandle is not a valid image >> handle. >> >> **/ >> EFI_STATUS >> diff --git >> a/UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTest >> UefiBootServicesTableLibProtocol.c >> b/UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTest >> UefiBootServicesTableLibProtocol.c >> index 437082d516ea..3d8110c8f8cd 100644 >> --- >> a/UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTest >> UefiBootServicesTableLibProtocol.c >> +++ b/UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/Unit >> +++ TestUefiBootServicesTableLibProtocol.c >> @@ -723,7 +723,7 @@ UnitTestReinstallProtocolInterface ( } >> >> /** >> - Uninstalls all instances of a protocol:interfacer from a handle. >> + Uninstalls all instances of a protocol from a handle. >> If the last protocol interface is remove from the handle, the >> handle is freed. >> >> diff --git a/PrmPkg/Include/Library/PrmModuleDiscoveryLib.h >> b/PrmPkg/Include/Library/PrmModuleDiscoveryLib.h >> index 341b9b26a0f8..9df8d4d02370 100644 >> --- a/PrmPkg/Include/Library/PrmModuleDiscoveryLib.h >> +++ b/PrmPkg/Include/Library/PrmModuleDiscoveryLib.h >> @@ -34,7 +34,7 @@ GetNextPrmModuleEntry ( >> /** >> Discovers all PRM Modules loaded during boot. >> >> - Each PRM Module discovered is placed into a linked list so the list can br >> processsed in the future. >> + Each PRM Module discovered is placed into a linked list so the list can br >> processed in the future. >> >> @param[out] ModuleCount An optional pointer parameter that, if >> provided, is set to the number >> of PRM modules discovered. >> diff --git a/PrmPkg/PrmLoaderDxe/PrmAcpiTable.h >> b/PrmPkg/PrmLoaderDxe/PrmAcpiTable.h >> index e2034d4738bd..fdb708c2a112 100644 >> --- a/PrmPkg/PrmLoaderDxe/PrmAcpiTable.h >> +++ b/PrmPkg/PrmLoaderDxe/PrmAcpiTable.h >> @@ -72,7 +72,7 @@ typedef struct { >> // >> // Todo: Revisit whether to use; currently both macros are not used // >> -#define PRM_MODULE_INFORMATION_STRUCTURE(ModuleGuid, >> ModuleRevision, HandlerCount, PrmHanderInfoStructureArray) { >> \ >> +#define PRM_MODULE_INFORMATION_STRUCTURE(ModuleGuid, >> ModuleRevision, HandlerCount, PrmHandlerInfoStructureArray) { >> \ >> { \ >> PRM_MODULE_INFORMATION_STRUCT_REVISION, >> /* UINT16 StructureRevision; */ \ >> (OFFSET_OF (PRM_MODULE_INFORMATION_STRUCT, >> HandlerInfoStructure) + (HandlerCount * sizeof >> (PRM_HANDLER_INFORMATION_STRUCT))) /* UINT16 StructureLength; >> */ \ >> @@ -80,7 +80,7 @@ typedef struct { >> ModuleRevision, >> /* UINT16 ModuleRevision */ \ >> HandlerCount, >> /* UINT16 HandlerCount */ \ >> OFFSET_OF (PRM_MODULE_INFORMATION_STRUCT, HandlerInfoOffset), >> /* UINT32 HandlerInfoOffset */ \ >> - PrmHanderInfoStructureArray >> /* PRM_HANDLER_INFORMATION_STRUCT HandlerInfoStructure */ \ >> + PrmHandlerInfoStructureArray >> /* PRM_HANDLER_INFORMATION_STRUCT HandlerInfoStructure */ \ >> } \ >> } >> >> diff --git a/PrmPkg/PrmPkg.ci.yaml b/PrmPkg/PrmPkg.ci.yaml index >> 2d4d12815d6b..521d95a2620f 100644 >> --- a/PrmPkg/PrmPkg.ci.yaml >> +++ b/PrmPkg/PrmPkg.ci.yaml >> @@ -94,10 +94,19 @@ >> # in matching files >> "ExtendWords": [ # words to extend to the dictionary for this >> package >> "buffe", # note: appears in buffer ascii dump in >> documentation >> + "dbgmsgid", >> + "devicepath", >> "iptor", # note: appears in buffer ascii dump in >> documentation >> "keepoptionalheader", >> "odule", # note: appears in buffer ascii dump in >> documentation >> "oemid", >> + "packagelist", >> + "pecoff", >> + "prmconfig", >> + "prmcontextbufferlib", >> + "prminfo", >> + "prmloader", >> + "prmmodulediscoverylib", >> "prmopreg", >> "prmpecofflib", >> "prmpkg", >> diff --git >> a/UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTest >> UefiBootServicesTableLib.h >> b/UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTest >> UefiBootServicesTableLib.h >> index 82853bb61a1c..20958589b254 100644 >> --- >> a/UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTest >> UefiBootServicesTableLib.h >> +++ b/UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/Unit >> +++ TestUefiBootServicesTableLib.h >> @@ -354,7 +354,7 @@ UnitTestReinstallProtocolInterface ( >> ); >> >> /** >> - Uninstalls all instances of a protocol:interfacer from a handle. >> + Uninstalls all instances of a protocol from a handle. >> If the last protocol interface is remove from the handle, the >> handle is freed. >> >> @@ -600,7 +600,7 @@ UnitTestExit ( >> @retval EFI_SUCCESS The image has been unloaded. >> @retval EFI_UNSUPPORTED The image has been started, and does not >> support >> unload. >> - @retval EFI_INVALID_PARAMPETER ImageHandle is not a valid image >> handle. >> + @retval EFI_INVALID_PARAMETER ImageHandle is not a valid image >> handle. >> >> **/ >> EFI_STATUS >> -- >> 2.28.0.windows.1 >> >> >> >> -=-=-=-=-=-= >> Groups.io Links: You receive all messages sent to this group. >> View/Reply Online (#97382): https://edk2.groups.io/g/devel/message/97382 >> Mute This Topic: https://groups.io/mt/95678199/1772825 >> Group Owner: devel+owner@edk2.groups.io >> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ankit.sinha@intel.com] >> -=-=-=-=-=-= >> > > > > >