From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.41]) by mx.groups.io with SMTP id smtpd.web09.12449.1639167065215792456 for ; Fri, 10 Dec 2021 12:11:06 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=OO2b03qK; spf=pass (domain: arm.com, ip: 40.107.21.41, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P8117gQ8CQefIDiglexsOb02TzET+YdiRArvTBMqOEM=; b=OO2b03qKFkqOqoQiM0xWA6p9DmShCiSKj9hpdaocnHAT6RaGY7GW2z7siNnHGAHcC2rQ9XHBVtscyIaKBARd6Jn0Pcp/j1XrgQ1JYTylcBDmCbFOIm78Ndcs2QhRsVEb2gY6NHrBR+cuFdNPFe0GXwoUBB1vT2Yv3lp8LoSHEMo= Received: from AS8PR04CA0203.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::28) by AS8PR08MB7157.eurprd08.prod.outlook.com (2603:10a6:20b:403::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.19; Fri, 10 Dec 2021 20:11:02 +0000 Received: from VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f3:cafe::6f) by AS8PR04CA0203.outlook.office365.com (2603:10a6:20b:2f3::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14 via Frontend Transport; Fri, 10 Dec 2021 20:11:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT061.mail.protection.outlook.com (10.152.19.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend Transport; Fri, 10 Dec 2021 20:11:02 +0000 Received: ("Tessian outbound 157533e214a9:v110"); Fri, 10 Dec 2021 20:11:01 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3db607e2cb2ec581 X-CR-MTA-TID: 64aa7808 Received: from 5f29cd1b0d09.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 42930F0B-29AD-4FE9-91D9-1FEA86132C64.1; Fri, 10 Dec 2021 20:10:55 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5f29cd1b0d09.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 10 Dec 2021 20:10:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e98CS5XkLsdGo6QHC4aOLbi2wGNuVPz2aXOfK4/cgpIuVJvg2piksvL6y9MJGQnVZuat/pEFsd2e40IlAZzUwYwLQc3oeLj55a7QM7zmEMhkWL7WMliUZ2ytXQ22w03aQ0/iyDR5TSIOBM9SQLrrjw/csdQNhheJlbmhqJeoup9cY9DMl0YueCgG9J2oEH7nSo9ybl0s/0dXVIjb6zG8fz/FCDv3cU8r52zPn6Zj7P62uQFzqlN0Yms7vp7uSfEF8SMJ3Yh8fGpQ31PO/28r6vreJnb8QyVXSjaZxUb/YCGlew3l3DnMjbyPxdGxnRylrCM28W3a6Hc58oCALH1AqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P8117gQ8CQefIDiglexsOb02TzET+YdiRArvTBMqOEM=; b=dCV009+T5vzGmnc9Xx8I4IwSTe+f+yeyIRDmiH8y5pk+YeoTUOszvtS5BduYKMmdI4IrkM68mY+etWRPZAhKtGNIR3ZPXBkUjQRv6rVSC9Kny0TPzkBNaDGvzA+4dIfVCXPdhPn/DNOLi4cN3Nhg9X5x+TY9HMdcpVBu/8RHe43hrk1BBIVIo9yIGUH/5Aq9hfL8rAORy8eaAeBGJXfXKenqiQqytLffKvs9OLIruj4qlXykY2L72OC9+NoawRri3LNN9K7nkqdbiQM9m25Lm1YofK+2jjspkisZzutW4ZEqYz8uGYUjmyWfHKQuK9yCA8J3fxGY1xEoRN4Qj5IMPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P8117gQ8CQefIDiglexsOb02TzET+YdiRArvTBMqOEM=; b=OO2b03qKFkqOqoQiM0xWA6p9DmShCiSKj9hpdaocnHAT6RaGY7GW2z7siNnHGAHcC2rQ9XHBVtscyIaKBARd6Jn0Pcp/j1XrgQ1JYTylcBDmCbFOIm78Ndcs2QhRsVEb2gY6NHrBR+cuFdNPFe0GXwoUBB1vT2Yv3lp8LoSHEMo= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM7PR08MB5384.eurprd08.prod.outlook.com (2603:10a6:20b:10c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Fri, 10 Dec 2021 20:10:42 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac%6]) with mapi id 15.20.4755.021; Fri, 10 Dec 2021 20:10:42 +0000 Subject: Re: [edk2-devel] [PATCH v3 0/7] Support ACPI 6.4 PPTT changes To: devel@edk2.groups.io, Chris Jones Cc: michael.d.kinney@intel.com, gaoliming@byosoft.com.cn, zhiguang.liu@intel.com, ray.ni@intel.com, zhichao.gao@intel.com, Alexei.Fedorov@arm.com, nd@arm.com References: <20211208160630.10923-1-christopher.jones@arm.com> <16BF24D08620153C.20064@groups.io> From: "Sami Mujawar" Message-ID: Date: Fri, 10 Dec 2021 20:10:44 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <16BF24D08620153C.20064@groups.io> X-ClientProxiedBy: LO2P265CA0419.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::23) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.50) by LO2P265CA0419.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20 via Frontend Transport; Fri, 10 Dec 2021 20:10:41 +0000 X-MS-Office365-Filtering-Correlation-Id: 49c23169-8a99-41fa-c1d5-08d9bc193071 X-MS-TrafficTypeDiagnostic: AM7PR08MB5384:EE_|VE1EUR03FT061:EE_|AS8PR08MB7157:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6430;OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ODoYlAOBxZLwZPDKo6M9u89mHSUb4jAvwTGZsSBCD1JouQHgcbzDBGw4YBU5pKqgGl0BKDO+NQUo/OFFx3KlKSBAZjheKn+9EZcshNGMnwDwcBKGANaYNLUgZ96ATKCxGuRu4470xFns3YizRzt0ujFgkAw1Q6EhFkf1XQbalqhVeRR6HF+KEpPeoOwtfkuyE4ns4gHRwLDW/GATrMIReaI6UQn1IkBL6fqN+BCrsoUnLEC2XrQsQzaUAZkP+ajl0YzC9mi8P5flFmhxKDGvnQDgZATpvbfxNrfZyZ14jBQL0PzlbGKg1YkHsENPWo+fdzxtmnUkH+qICtX+4N3+D3lyJ1Eyk6Pt6z1kTfX/iAXiYPiE0vhDzdaeDX4eZJKcYzghG07iKcDH74w8OiJZF6HOVPAHWAZQHCyVdZOXF0VuXzyYXfGdlGxheuoyXflIuJBmuQj2cOjTcOye1f7QjYdicvs4uWF9kZRe4f0LmNeIeHMj1BvgiMACDv4hGmFK8o6H2woa0332MwLLjaMxYN6gV+jsZqG8PnN3Yzlk8ODJpbMDHDDOl+qnwNsLGhQG4dUe/fqnueimIUxoQ3qEpcLvm5vnlKai7DQvHq/vKG2706llzikQ9cXSQvJRpTOKuDv0RrBW67UQtA5mKxTkTMZtfrD/XW2USLb8zxTSMNSj+H1cOdc10Cq2o4CQf1r0c5XRRALJLT+0aiqGePZ440PKAls1I3jxxUbwkHg14tLrFbhWw99ZkJT+Xns76wRoPXkRpRJOQ22SZcAR6BrfhHY4fCA67o+F4Rpa+OXT/XsAOgnUIMCxmDdI84qDcGAynOUcfn3NndjguWkNIX2QRtom5ayQDFLPHcFDEQfYqeyF260Wa5j7mQr+8di5UpxxDvSKqDPr10b9JbYf+OmvqA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38350700002)(38100700002)(26005)(8676002)(66946007)(66476007)(66556008)(5660300002)(6636002)(8936002)(966005)(52116002)(86362001)(508600001)(53546011)(956004)(19627235002)(83380400001)(186003)(31696002)(4326008)(6486002)(37006003)(316002)(16576012)(31686004)(44832011)(2616005)(36756003)(6862004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5384 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 199cba0d-b215-4300-578f-08d9bc192462 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lM21IKgczxyD8d5h+bcLvoG3a0pRiw/x6xw2pCjUww/1nayXcL/yxW8xR2Mg0OuL50gTWpSIWr2TtJUyueKbNwsSDIm3nZZhxgrqiCykYOveIus/m+TuvVinHejv05tmm8YjZK31A/d+b3vMO6Y/ug+K78GN+QGVOkRW95rdZg462gIe7iNjXCyJrWVmm2tK6t+czAdc5P7w9y6h7E7w/8zPMSWCikyOaBuXAzmx0O2dON1iyd/84kOcbj47y+ffgeqPSNPyZY7PmmuJXRuuoDEctI2LahU7yPIZUBCEaLyU3gGMunfNs4k9+70QcdET+B3WnCuiuIKo7Dqk8SF5C5Vec6nXgWo0x+z6o5agm9y0HKRH3k5HRt5XZ2LYL1ULSjjz8WTBib97JlUKi6FKdR56EnokFQNz3qIp5FCNgMPTTTeOvuZOBu7J/SpMXGh+jpgA7xAguacvGNEV06YyzHyqjJf5pUnQQEgPWqpjDtz391qflCsQqwPNY/sKJQv8S24ok2cfFcGZXGUoPOIyaQHR7OdduXDgYup7RoG6kbb+Qtvsw04lpU2+XnVifHIdRtvp8X+MpOeKs6i8P5MzUtdCgLZWgr302C2BNfNuU0O46PZbrJ0GycPLyDXPxup2LqYWZMWvsGv23z4warY9+t2gVC4+vMvaMCMNEfffMUVf+cOYfVC1VmmzhGe18GxKSSJQzbblp0EaltqePYB7m0JwUBh/pgbZEs3wvY4OIOrdvMVvBsMqMtyFTnaxtX9BaMOMJN8SuVVf3VuKHHADsNdjQA3mvQNLdZcO6TVrydVjGD1iP5zueuBV7ojyk1PjRi+mHw5XP1au0sMbbVhz3LQYpp9WMPku5/vnrjXAOTva31XG83sRJ38bL646r7wclIxpZijyK1e09n751xVNjpqKGo7FteDyzL66ykv47ls= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(31696002)(356005)(40460700001)(86362001)(44832011)(186003)(2616005)(83380400001)(82310400004)(6862004)(36756003)(16576012)(70586007)(956004)(36860700001)(6486002)(4326008)(336012)(31686004)(19627235002)(508600001)(37006003)(5660300002)(47076005)(8936002)(70206006)(966005)(316002)(2906002)(6636002)(8676002)(53546011)(81166007)(26005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 20:11:02.1538 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 49c23169-8a99-41fa-c1d5-08d9bc193071 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7157 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Merged as 0f1d7477c0a8..e81a81e5846e Regards, Sami Mujawar On 09/12/2021 05:00 PM, Sami Mujawar via groups.io wrote: > Hi Chris, > > Thank you for this patch series. > > Other than my feedback for optimisation in patch 7/7 (which I will > address before merging), this patch series looks good to me. > > For this series, > > Reviewed-by: Sami Mujawar > > Regards, > > Sami Mujawar > > On 08/12/2021 04:06 PM, Chris Jones wrote: >> Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) >> >> This patch series updates the Acpiview PPTT parser and DynamicTablesPkg >> PPTT generator to support ACPI 6.4. This consists of two main changes: >> - The addition of the 'Cache ID' field. >> - The removal of the PPTT ID (type 2) structure. >> >> In addition add two 'Cache ID' defines and remove the type 2 PPTT >> structure from Acpi64.h as these changes were missing when Acpi64.h was >> introduced. >> >> Changes since v2: >> 1. Added mantis ID for PPTT type 2 structure removal on relevant commit >> messages. No change to code. >> 2. Applied uncrustify to all patches. No other changes to code. >> >> Changes since v1: >> 1. Patch 3/7 ShellPkg: >> - Changed PPTT ID error message to say "removed" instead of >> "deprecated". >> 2. Patch 4/7 ShellPkg: >> - Fixed a bug where 'CacheFlags' and 'CacheId' were only set >> after the >> validation function had finished. Instead set them inside the >> validation function using the first 'Ptr' parameter. >> 3. Patch 7/7 DynamicTablesPkg: >> - Make IsCacheIdUnique() return BOOLEAN instead of EFI_STATUS. >> - Added a missing space to the definition of 'IsCacheIdUnique'. >> >> The changes can be seen at: >> https://github.com/chris-jones-arm/edk2/tree/1632_64_acpi_cache_id_v3 >> >> >> Chris Jones (7): >> MdePkg: Add missing Cache ID (in)valid define >> MdePkg: Remove PPTT ID type structure >> ShellPkg: Update Acpiview PPTT parser to ACPI 6.4 >> ShellPkg: Add Cache ID to PPTT parser >> DynamicTablesPkg: Remove PPTT ID structure from ACPI 6.4 generator >> DynamicTablesPkg: Update PPTT generator to ACPI 6.4 >> DynamicTablesPkg: Add CacheId to PPTT generator >> >> .../Include/ArmNameSpaceObjects.h | 27 +- >> .../Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 296 +++++++----------- >> .../Acpi/Arm/AcpiPpttLibArm/PpttGenerator.h | 4 - >> MdePkg/Include/IndustryStandard/Acpi64.h | 18 +- >> .../Parsers/Pptt/PpttParser.c | 214 +++++++++---- >> .../UefiShellAcpiViewCommandLib.c | 2 +- >> 6 files changed, 272 insertions(+), 289 deletions(-) >> > > > > > >