From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Gao, Zhichao" <zhichao.gao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [PATCH 0/2] ShellPkg: Document the use of EFI_INVALID_PARAMETER by two functions
Date: Thu, 19 Dec 2019 15:09:48 +0100 [thread overview]
Message-ID: <d937aa32-2ca9-e6bd-78f1-f63589d6abd1@redhat.com> (raw)
In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B8A3B13@SHSMSX101.ccr.corp.intel.com>
On 12/19/19 6:00 AM, Gao, Zhichao wrote:
> Sorry for missing do the script check. The patch #1 's title length is too long. We should make sure the title length is less than 72 (not include 72).
> Can you change that and resend the patch set?
Will do.
>
> Thanks,
> Zhichao
>
>> -----Original Message-----
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>> Gao, Zhichao
>> Sent: Wednesday, December 4, 2019 9:47 AM
>> To: Philippe Mathieu-Daude <philmd@redhat.com>; devel@edk2.groups.io
>> Cc: Ni, Ray <ray.ni@intel.com>
>> Subject: Re: [edk2-devel] [PATCH 0/2] ShellPkg: Document the use of
>> EFI_INVALID_PARAMETER by two functions
>>
>> Series, Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
>>
>> Thanks,
>> Zhichao
>>
>>> -----Original Message-----
>>> From: Philippe Mathieu-Daude [mailto:philmd@redhat.com]
>>> Sent: Tuesday, December 3, 2019 1:41 AM
>>> To: devel@edk2.groups.io
>>> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
>>> Philippe Mathieu-Daude <philmd@redhat.com>
>>> Subject: [PATCH 0/2] ShellPkg: Document the use of
>>> EFI_INVALID_PARAMETER by two functions
>>>
>>> Complete the list of values the functios ParseCommandLineToArgs() and
>>> UpdateArgcArgv() can return.
>>>
>>> The documentation was found to be incomplete while reviewing BZ#2395:
>>> https://edk2.groups.io/g/devel/message/51512
>>>
>>> Regards,
>>>
>>> Phil.
>>>
>>> Philippe Mathieu-Daude (2):
>>> ShellPkg: Document ParseCommandLineToArgs returns
>>> EFI_INVALID_PARAMETER
>>> ShellPkg: Document UpdateArgcArgv returns EFI_INVALID_PARAMETER
>>>
>>> ShellPkg/Application/Shell/ShellParametersProtocol.h | 2 ++
>>> ShellPkg/Application/Shell/ShellParametersProtocol.c | 2 ++
>>> 2 files changed, 4 insertions(+)
>>>
>>> --
>>> 2.21.0
>>
>>
>>
>
prev parent reply other threads:[~2019-12-19 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 17:40 [PATCH 0/2] ShellPkg: Document the use of EFI_INVALID_PARAMETER by two functions Philippe Mathieu-Daudé
2019-12-02 17:40 ` [PATCH 1/2] ShellPkg: Document ParseCommandLineToArgs returns EFI_INVALID_PARAMETER Philippe Mathieu-Daudé
2019-12-02 17:40 ` [PATCH 2/2] ShellPkg: Document UpdateArgcArgv " Philippe Mathieu-Daudé
2019-12-04 1:46 ` [PATCH 0/2] ShellPkg: Document the use of EFI_INVALID_PARAMETER by two functions Gao, Zhichao
[not found] ` <15DD07CBE3EDEC2C.30367@groups.io>
2019-12-19 5:00 ` [edk2-devel] " Gao, Zhichao
2019-12-19 14:09 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d937aa32-2ca9-e6bd-78f1-f63589d6abd1@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox