From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web09.9774.1576764596327660675 for ; Thu, 19 Dec 2019 06:09:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ILt7ZO44; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576764595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VxvTxHae+es4s8LlYAGUB+P9CisKhbTgvxqIBa0G7Bg=; b=ILt7ZO44U5cYkwj4cnMvHollfhUw1rnctfZWhC9XYUK4BaJE36sStWV0bKS7wucdPVsGS2 3lkWG+HBOUxUcRxfSLZynfT3fr43b0bnNk2YXQKq7kAn/Tw4uZW12qTVJu+3BFEDL9Plbu qckSu6N5BAOR+yHGsviOM+V5FjhtVSc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-311-Ta3vP-0xMi2H5xy2pKOmzw-1; Thu, 19 Dec 2019 09:09:51 -0500 Received: by mail-wm1-f69.google.com with SMTP id c4so1402528wmb.8 for ; Thu, 19 Dec 2019 06:09:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VxvTxHae+es4s8LlYAGUB+P9CisKhbTgvxqIBa0G7Bg=; b=TXDE1ArywV9Eu+mChaXG6tUi1+cfzuZsR8l2AgR/I3yT25D3oLy/cyPylX2wu283Uw ZfwsJMyWAKacirM8aqrCbr2MboRNCpom7nWXAOXK1RhafqyT764vD4N+zthsYrnp20i1 j5wIPCa3L5GbQyjsWKpncLwc/XNCn1IX17xAf5r66lYOs5gMYJHFSdMgisaZWZIxMrsl gBIkj6BgZhMbdkE81IxO446nFH2SbyP5+i3ordDyxU04BF0Zj+eNzPkSmOBKWdwomPOc UIdmhIdbhR+wMj8nygZ4Tx5su5TnT8Wq5ON6wGb21rcMx+Strh4zSl9B2BBnV+QdydIF 1VQg== X-Gm-Message-State: APjAAAW3fuBsC0Uy5XrfgBd8sZ3pyqmpRM4qQeYxx0M4rYqvpXxA2hfg 0E08TpCILUpLK6v+OHYXacDNWc4oXQqX02AC+eKfWLeqmA4bHordkq7DqTu2EYt8jLG64WxFBow 4klwF21JDUQBRAw== X-Received: by 2002:a5d:5491:: with SMTP id h17mr9941027wrv.374.1576764590333; Thu, 19 Dec 2019 06:09:50 -0800 (PST) X-Google-Smtp-Source: APXvYqyUZnZqAQ0Zqo63ITg/0V9+W8kmQ99VxNxWUSxVsy9yieRbCrax8mdFZDt96WsOVj5NU9hfjA== X-Received: by 2002:a5d:5491:: with SMTP id h17mr9941013wrv.374.1576764590125; Thu, 19 Dec 2019 06:09:50 -0800 (PST) Return-Path: Received: from [192.168.1.35] (34.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.34]) by smtp.gmail.com with ESMTPSA id e12sm6586422wrn.56.2019.12.19.06.09.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Dec 2019 06:09:49 -0800 (PST) Subject: Re: [edk2-devel] [PATCH 0/2] ShellPkg: Document the use of EFI_INVALID_PARAMETER by two functions To: "Gao, Zhichao" , "devel@edk2.groups.io" Cc: "Ni, Ray" References: <20191202174051.11062-1-philmd@redhat.com> <15DD07CBE3EDEC2C.30367@groups.io> <3CE959C139B4C44DBEA1810E3AA6F9000B8A3B13@SHSMSX101.ccr.corp.intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Thu, 19 Dec 2019 15:09:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B8A3B13@SHSMSX101.ccr.corp.intel.com> X-MC-Unique: Ta3vP-0xMi2H5xy2pKOmzw-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 12/19/19 6:00 AM, Gao, Zhichao wrote: > Sorry for missing do the script check. The patch #1 's title length is too long. We should make sure the title length is less than 72 (not include 72). > Can you change that and resend the patch set? Will do. > > Thanks, > Zhichao > >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Gao, Zhichao >> Sent: Wednesday, December 4, 2019 9:47 AM >> To: Philippe Mathieu-Daude ; devel@edk2.groups.io >> Cc: Ni, Ray >> Subject: Re: [edk2-devel] [PATCH 0/2] ShellPkg: Document the use of >> EFI_INVALID_PARAMETER by two functions >> >> Series, Reviewed-by: Zhichao Gao >> >> Thanks, >> Zhichao >> >>> -----Original Message----- >>> From: Philippe Mathieu-Daude [mailto:philmd@redhat.com] >>> Sent: Tuesday, December 3, 2019 1:41 AM >>> To: devel@edk2.groups.io >>> Cc: Ni, Ray ; Gao, Zhichao ; >>> Philippe Mathieu-Daude >>> Subject: [PATCH 0/2] ShellPkg: Document the use of >>> EFI_INVALID_PARAMETER by two functions >>> >>> Complete the list of values the functios ParseCommandLineToArgs() and >>> UpdateArgcArgv() can return. >>> >>> The documentation was found to be incomplete while reviewing BZ#2395: >>> https://edk2.groups.io/g/devel/message/51512 >>> >>> Regards, >>> >>> Phil. >>> >>> Philippe Mathieu-Daude (2): >>> ShellPkg: Document ParseCommandLineToArgs returns >>> EFI_INVALID_PARAMETER >>> ShellPkg: Document UpdateArgcArgv returns EFI_INVALID_PARAMETER >>> >>> ShellPkg/Application/Shell/ShellParametersProtocol.h | 2 ++ >>> ShellPkg/Application/Shell/ShellParametersProtocol.c | 2 ++ >>> 2 files changed, 4 insertions(+) >>> >>> -- >>> 2.21.0 >> >> >> >