public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, edk2-devel@lists.01.org
Cc: lersek@redhat.com
Subject: Re: [PATCH RFT] ArmVirtPkg/ArmVirtXen: move from Intel to generic BDS
Date: Mon, 4 Dec 2017 15:19:52 +0000	[thread overview]
Message-ID: <d99c0a4e-11e4-df72-c094-13dc720e2a55@linaro.org> (raw)
In-Reply-To: <20171130203114.19464-1-ard.biesheuvel@linaro.org>

Hi Ard,

On 30/11/17 20:31, Ard Biesheuvel wrote:
> ArmVirtXen is the only remaining consumer of ArmPlatformPkg's
> PlatformIntelBdsLib implementation, which is tightly coupled to the
> deprecated Intel BDS. So move ArmVirtXen to the generic BDS as well,
> allowing us to get rid of PlatformIntelBdsLib entirely.

It was in my list of UEFI part I wanted to look next :).
I tested it and hit the following assert:

ASSERT [BdsDxe] /home/julieng/works/edk2/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c(502): 0 == 4

Looking at the ArmVirtQemu.dsc, I made the below modification.
When I tried the version protected by TTY_ENABLE, the ASSERT was
still present.

diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc
index ae43d59901..bc76a780be 100644
--- a/ArmVirtPkg/ArmVirtXen.dsc
+++ b/ArmVirtPkg/ArmVirtXen.dsc
@@ -81,6 +81,10 @@
   # Size of the region used by UEFI in permanent memory (Reserved 64MB)
   gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000
 
+  ## Default Terminal Type^M
+  ## 0-PCANSI, 1-VT100, 2-VT00+, 3-UTF8, 4-TTYTERM^M
+  gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4^M
+^M
   #
   # ARM Virtual Architectural Timer
   #

My knowledge in UEFI is still limited, so I would appreciate any
feedbacks here.

Cheers,

-- 
Julien Grall


  parent reply	other threads:[~2017-12-04 15:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30 20:31 [PATCH RFT] ArmVirtPkg/ArmVirtXen: move from Intel to generic BDS Ard Biesheuvel
2017-12-01 10:08 ` Laszlo Ersek
2017-12-04 16:15   ` Ard Biesheuvel
2017-12-04 15:19 ` Julien Grall [this message]
2017-12-04 15:52   ` Ard Biesheuvel
2017-12-04 15:55     ` Ard Biesheuvel
2017-12-04 16:08       ` Julien Grall
2017-12-04 16:09         ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d99c0a4e-11e4-df72-c094-13dc720e2a55@linaro.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox