From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::22b; helo=mail-wm0-x22b.google.com; envelope-from=julien.grall@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com [IPv6:2a00:1450:400c:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1B0F822152384 for ; Mon, 4 Dec 2017 07:15:25 -0800 (PST) Received: by mail-wm0-x22b.google.com with SMTP id 64so14908582wme.3 for ; Mon, 04 Dec 2017 07:19:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=abpr4ocFckZ9ChNViYOyQXIRMo0dqe5F5gNPWtM+yCk=; b=SNJyeMpcF5J4P0vPBWIRoqCU1rxu7jyJERYzyA4JDb0EsNrMBPGU4vzyV7XZed2k32 4TOSjyTdPQMYQ+Di8M3Ss9zcXgq/LdLxktsNDwsWjSvB++MGRO3+mtioenTAv3GR7XxL VNYMmhcgGfzT+4zvkECXRAHjvZQpoZOnJIlOc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=abpr4ocFckZ9ChNViYOyQXIRMo0dqe5F5gNPWtM+yCk=; b=tbma46HCTk+hdS7TwGoOzs92+I3zANXbcOKJ6rT0JGIR9q8BFSBeYrmJhIh5A9vMxQ 6yAVXB2clysG64aCXIoSKX+7hHi2HJfpLR1e8Z5kgWyDvXwfp6hAoRxAnXLLueTd7aqt lUd7XaRPHLEwXHeHutqsCHmL7NRWwzqZwBOSrPvh8E91wj6h0nJQ19YtlvEIuqNgSFUf c/DUjSdy7hriCXvky3ysGb8Ij99G0PVs9W4zBarnSxfbDmYhjpwgXKU42zaTsySYE5pq fX0fCFjyoR8Y7oJFbudqfeEbNkZmeekkjRYaztkQc8vTcpXMni0+9ef5UbscGvpDX4Z2 emNQ== X-Gm-Message-State: AKGB3mIEkq41jXPYr2aVl4h7QL2L1q4BZKVUFdPWrZ+7f5i6gxjBfclW NVNNauWE4ZlozX3YUHasJo1NWw== X-Google-Smtp-Source: AGs4zMYrlMqHrft9DBuLRKanKD6Ze4fw/K16A+wmUBGSWdT4/UcrEzovWRG2zDYStQzcaXdiYMMEAQ== X-Received: by 10.28.107.5 with SMTP id g5mr3610370wmc.125.1512400794406; Mon, 04 Dec 2017 07:19:54 -0800 (PST) Received: from ?IPv6:::1? ([2001:41d0:1:6c23::1]) by smtp.gmail.com with ESMTPSA id a126sm7938175wma.11.2017.12.04.07.19.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Dec 2017 07:19:53 -0800 (PST) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: lersek@redhat.com References: <20171130203114.19464-1-ard.biesheuvel@linaro.org> From: Julien Grall Message-ID: Date: Mon, 4 Dec 2017 15:19:52 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171130203114.19464-1-ard.biesheuvel@linaro.org> Subject: Re: [PATCH RFT] ArmVirtPkg/ArmVirtXen: move from Intel to generic BDS X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2017 15:15:26 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ard, On 30/11/17 20:31, Ard Biesheuvel wrote: > ArmVirtXen is the only remaining consumer of ArmPlatformPkg's > PlatformIntelBdsLib implementation, which is tightly coupled to the > deprecated Intel BDS. So move ArmVirtXen to the generic BDS as well, > allowing us to get rid of PlatformIntelBdsLib entirely. It was in my list of UEFI part I wanted to look next :). I tested it and hit the following assert: ASSERT [BdsDxe] /home/julieng/works/edk2/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c(502): 0 == 4 Looking at the ArmVirtQemu.dsc, I made the below modification. When I tried the version protected by TTY_ENABLE, the ASSERT was still present. diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc index ae43d59901..bc76a780be 100644 --- a/ArmVirtPkg/ArmVirtXen.dsc +++ b/ArmVirtPkg/ArmVirtXen.dsc @@ -81,6 +81,10 @@ # Size of the region used by UEFI in permanent memory (Reserved 64MB) gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000 + ## Default Terminal Type^M + ## 0-PCANSI, 1-VT100, 2-VT00+, 3-UTF8, 4-TTYTERM^M + gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4^M +^M # # ARM Virtual Architectural Timer # My knowledge in UEFI is still limited, so I would appreciate any feedbacks here. Cheers, -- Julien Grall