From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.5378.1581595114207071421 for ; Thu, 13 Feb 2020 03:58:34 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2020 03:58:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,436,1574150400"; d="scan'208";a="238015538" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga006.jf.intel.com with ESMTP; 13 Feb 2020 03:58:33 -0800 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 13 Feb 2020 03:58:30 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 13 Feb 2020 19:58:28 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Thu, 13 Feb 2020 19:58:28 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Gao, Liming" , Krzysztof Koch CC: "Kinney, Michael D" , "Matteo.Carlini@arm.com" , "Sami.Mujawar@arm.com" , "nd@arm.com" Subject: Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add PCCT table signature definition Thread-Topic: [edk2-devel] [PATCH v2 1/1] MdePkg: Add PCCT table signature definition Thread-Index: AQHV4cnNsG30QW/e0kGp1YyZAjlMJqgYTdtQgAC4V8A= Date: Thu, 13 Feb 2020 11:58:28 +0000 Message-ID: References: <20200212172739.20240-1-krzysztof.koch@arm.com> <15F2D05E08B7669A.10188@groups.io> In-Reply-To: <15F2D05E08B7669A.10188@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Push @a67efa3b22113cc9b52f8e56e50466d6da0ab11e > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Liming Ga= o > Sent: Thursday, February 13, 2020 8:59 AM > To: Krzysztof Koch ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Matteo.Carlini@arm.c= om; Sami.Mujawar@arm.com; nd@arm.com > Subject: Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add PCCT table signatur= e definition >=20 > Reviewed-by: Liming Gao >=20 > > -----Original Message----- > > From: Krzysztof Koch > > Sent: Thursday, February 13, 2020 1:28 AM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D ; Gao, Liming ; Matteo.Carlini@arm.com; > > Sami.Mujawar@arm.com; nd@arm.com > > Subject: [PATCH v2 1/1] MdePkg: Add PCCT table signature definition > > > > The Platform Communications Channel Table (PCCT) was defined in: > > ACPI Specification Version 5.0, Errata A - Published Nov. 13, 2013. > > > > Starting from the Acpi50.h header file, there are definitions > > describing the table but a macro with the table's signature is missing= . > > > > This patch adds the definition of Platform Communications Channel > > Table's signature to the relevant ACPI header files. > > > > Signed-off-by: Krzysztof Koch > > --- > > > > Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/61= 7_add_pcct_signature_def_v2 > > > > Notes: > > v2: > > - Replicate the definition from Acpi50.h onwards [Liming] > > > > v1: > > - Add definition of PCCT table signature [Krzysztof] > > > > MdePkg/Include/IndustryStandard/Acpi50.h | 6 ++++++ > > MdePkg/Include/IndustryStandard/Acpi51.h | 6 ++++++ > > MdePkg/Include/IndustryStandard/Acpi60.h | 6 ++++++ > > MdePkg/Include/IndustryStandard/Acpi61.h | 6 ++++++ > > MdePkg/Include/IndustryStandard/Acpi62.h | 6 ++++++ > > MdePkg/Include/IndustryStandard/Acpi63.h | 7 ++++++- > > 6 files changed, 36 insertions(+), 1 deletion(-) > > > > diff --git a/MdePkg/Include/IndustryStandard/Acpi50.h b/MdePkg/Include= /IndustryStandard/Acpi50.h > > index 46dcdb950741020420a5695a8577dde5ac409ed7..31a47e6a2c4276d5b1ad7b= 834af84844090b64c5 100644 > > --- a/MdePkg/Include/IndustryStandard/Acpi50.h > > +++ b/MdePkg/Include/IndustryStandard/Acpi50.h > > @@ -3,6 +3,7 @@ > > > > Copyright (c) 2014 Hewlett-Packard Development Company, L.P.
> > Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.<= BR> > > + Copyright (c) 2020, ARM Ltd. All rights reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > > > > @@ -2057,6 +2058,11 @@ typedef struct { > > /// > > #define EFI_ACPI_5_0_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M= ', 'S', 'D', 'M') > > > > +/// > > +/// "PCCT" Platform Communications Channel Table > > +/// > > +#define EFI_ACPI_5_0_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE = SIGNATURE_32('P', 'C', 'C', 'T') > > + > > /// > > /// "SLIC" MS Software Licensing Table Specification > > /// > > diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h b/MdePkg/Include= /IndustryStandard/Acpi51.h > > index 0132f25de8ce945135714e59b4b9e5bd286b2c22..fc28ffa18fc6a22e52fda8= 8fade6ad80b2817cc3 100644 > > --- a/MdePkg/Include/IndustryStandard/Acpi51.h > > +++ b/MdePkg/Include/IndustryStandard/Acpi51.h > > @@ -4,6 +4,7 @@ > > Copyright (c) 2014 Hewlett-Packard Development Company, L.P.
> > Copyright (c) 2014 - 2018, Intel Corporation. All rights reserved.<= BR> > > (C) Copyright 2015 Hewlett Packard Enterprise Development LP
> > + Copyright (c) 2020, ARM Ltd. All rights reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > > > > @@ -2078,6 +2079,11 @@ typedef struct { > > /// > > #define EFI_ACPI_5_1_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M= ', 'S', 'D', 'M') > > > > +/// > > +/// "PCCT" Platform Communications Channel Table > > +/// > > +#define EFI_ACPI_5_1_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE = SIGNATURE_32('P', 'C', 'C', 'T') > > + > > /// > > /// "SLIC" MS Software Licensing Table Specification > > /// > > diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h b/MdePkg/Include= /IndustryStandard/Acpi60.h > > index 94a30a81b369d96dc83dce7aa1e274ef54b315aa..5dcd73b6f1ec4bccc7fdae= 7d56c2963ab58764f9 100644 > > --- a/MdePkg/Include/IndustryStandard/Acpi60.h > > +++ b/MdePkg/Include/IndustryStandard/Acpi60.h > > @@ -3,6 +3,7 @@ > > > > Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.<= BR> > > (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP > > + Copyright (c) 2020, ARM Ltd. All rights reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > > > > @@ -2321,6 +2322,11 @@ typedef struct { > > /// > > #define EFI_ACPI_6_0_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M= ', 'S', 'D', 'M') > > > > +/// > > +/// "PCCT" Platform Communications Channel Table > > +/// > > +#define EFI_ACPI_6_0_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE = SIGNATURE_32('P', 'C', 'C', 'T') > > + > > /// > > /// "SLIC" MS Software Licensing Table Specification > > /// > > diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h b/MdePkg/Include= /IndustryStandard/Acpi61.h > > index 985c8273ce61c86d445e61d0d5c1d8ae7c00cb8d..8626833a794dfb4a6f19d4= 59d5214c6caefdbbee 100644 > > --- a/MdePkg/Include/IndustryStandard/Acpi61.h > > +++ b/MdePkg/Include/IndustryStandard/Acpi61.h > > @@ -3,6 +3,7 @@ > > > > Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<= BR> > > (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> > + Copyright (c) 2020, ARM Ltd. All rights reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > > > > @@ -2353,6 +2354,11 @@ typedef struct { > > /// > > #define EFI_ACPI_6_1_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M= ', 'S', 'D', 'M') > > > > +/// > > +/// "PCCT" Platform Communications Channel Table > > +/// > > +#define EFI_ACPI_6_1_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE = SIGNATURE_32('P', 'C', 'C', 'T') > > + > > /// > > /// "SLIC" MS Software Licensing Table Specification > > /// > > diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include= /IndustryStandard/Acpi62.h > > index 5a5e9b811247e11b7ba3c998fb1bd6419c67980f..1b2704e98e3703a4405075= 247432ec842e45021b 100644 > > --- a/MdePkg/Include/IndustryStandard/Acpi62.h > > +++ b/MdePkg/Include/IndustryStandard/Acpi62.h > > @@ -2,6 +2,7 @@ > > ACPI 6.2 definitions from the ACPI Specification Revision 6.2 May, = 2017. > > > > Copyright (c) 2017, Intel Corporation. All rights reserved.
> > + Copyright (c) 2020, ARM Ltd. All rights reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > > > > @@ -2879,6 +2880,11 @@ typedef struct { > > /// > > #define EFI_ACPI_6_2_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M= ', 'S', 'D', 'M') > > > > +/// > > +/// "PCCT" Platform Communications Channel Table > > +/// > > +#define EFI_ACPI_6_2_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE = SIGNATURE_32('P', 'C', 'C', 'T') > > + > > /// > > /// "SDEI" Software Delegated Exceptions Interface Table > > /// > > diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h b/MdePkg/Include= /IndustryStandard/Acpi63.h > > index eca1f9357b70f10887e680ff13c97c0beab3600b..b281b30155e90eba5169dc= 39bde9a3379e3b7005 100644 > > --- a/MdePkg/Include/IndustryStandard/Acpi63.h > > +++ b/MdePkg/Include/IndustryStandard/Acpi63.h > > @@ -2,7 +2,7 @@ > > ACPI 6.3 definitions from the ACPI Specification Revision 6.3 Jan, = 2019. > > > > Copyright (c) 2017, Intel Corporation. All rights reserved.
> > - Copyright (c) 2019, ARM Ltd. All rights reserved.
> > + Copyright (c) 2019 - 2020, ARM Ltd. All rights reserved.
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > > @@ -2880,6 +2880,11 @@ typedef struct { > > /// > > #define EFI_ACPI_6_3_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M= ', 'S', 'D', 'M') > > > > +/// > > +/// "PCCT" Platform Communications Channel Table > > +/// > > +#define EFI_ACPI_6_3_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE = SIGNATURE_32('P', 'C', 'C', 'T') > > + > > /// > > /// "SDEI" Software Delegated Exceptions Interface Table > > /// > > -- > > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20 >=20 >=20