From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2a00:1450:4864:20::541; helo=mail-ed1-x541.google.com; envelope-from=pete@akeo.ie; receiver=edk2-devel@lists.01.org Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1DEA821BADAB2 for ; Tue, 29 Jan 2019 04:54:36 -0800 (PST) Received: by mail-ed1-x541.google.com with SMTP id h15so15873006edb.4 for ; Tue, 29 Jan 2019 04:54:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NZ9G3BO9UwpIjSmP+gHFV+BSNh28M4jmGUWRIfgjxE4=; b=bHoU4op8v0riNNXDgIuV+Wla7fmuInzCvoEdmGM3K+RvciN+8TisuypNsKX5NvgTZ8 Uhs3++4wUxns70INmM7nQw9NwQVLkpSRUSJ+nYiBly4+/PpgDDfThTALelELW1v3w44B 0pkdftYjUW4yReK07aTpEkaTP8+UkqZruD5hY2MlvtKba3SDB5pomYEh+VGeDO4ypRKd qAGYHmKWB3GMVBIXgJSl197IJ8u/zhielMpSNu65bRyNORiToqjtSIpncQ85H0HE3q6O 3e8HGiRTMFF4dELrwSRdd0qNdrt1jl7nGZ1AeSj6Nsak26inp7SZVgCjw9IM7i2CU8nI ILRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NZ9G3BO9UwpIjSmP+gHFV+BSNh28M4jmGUWRIfgjxE4=; b=d7x0BvyQOxHOAIm8pgGgfBb4a5vrVH1TlRLr6G7l6Uc5MCarjpAwrBwlk2pxEMmWZ1 Wmp/Pw0I0BcJ9UsP0UPHeVHifDRCvlPk6q/l/24iVo1hq9XigBZDFQEEF75MQsJV9YwY A5AgiWUn3ZBdxzrducJAsvzrHLZrRjuc1/cygHHVC5ef4LrnpJqpMipi3Vo9nf+XG8ry 9wp6xH6MAokmQegXzPFu0ziaURGVFHlfc7YLiBmti99my9Ja1rOh5nhFIaRbMvwCqpR9 vKdzVa5m/PEbgcqLw2bwLKZsJQgVfsL2CXCQK2dUw++05mfuSyig1Tu2XzFMXM/8hYur NYIg== X-Gm-Message-State: AJcUukfeMiDDjPQspZnz8mqQ5yyM4H/s0VcDFyiowezsp95c9lEjeARN 3xG9dF9I4f0ptMjQMWruvdgeNw== X-Google-Smtp-Source: ALg8bN63pZNFD4VSlCOFok75xxERkXUDsVzy+lpH4Otuy5iJLEbPBJgz6ZUriFDGcDD0/8RrcAKwsw== X-Received: by 2002:a50:9ac4:: with SMTP id p62mr25593911edb.179.1548766474702; Tue, 29 Jan 2019 04:54:34 -0800 (PST) Received: from [10.0.0.102] ([84.203.95.186]) by smtp.googlemail.com with ESMTPSA id h1sm2024854ejx.41.2019.01.29.04.54.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 04:54:32 -0800 (PST) To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Leif Lindholm References: <20190128124445.9868-1-pete@akeo.ie> <20190128124445.9868-4-pete@akeo.ie> From: Pete Batard Message-ID: Date: Tue, 29 Jan 2019 12:54:31 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH v3 edk2-platforms 03/23] Platform/Raspberry/Pi3: Add ACPI tables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2019 12:54:37 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ard, thanks for the reviews, On 2019.01.28 13:24, Ard Biesheuvel wrote: > A couple of general remarks on these tables. > > - AFAICT (but is is difficult to tell from the binary dumps), these > are based on ACPI 5.0, which predates the introduction of ARM support > into the spec. That essentially makes them Windows-only, and not spec > based, which is unfortunate. However, since this SoC does not have an > interrupt controller permitted by ACPI, that actually does not matter > a lot in practice. Publicly, these tables are only meant to boot Windows and we got them from Microsoft. So they are not exactly meant to be ACPI compliant (for instance, AFAIK, there's no definition of ACPI that includes the RPI interrupt controller). As such, we really don't want to touch these because we have run into nightmarish situation where Windows wouldn't boot at all after we tried to alter them. In other words, if we are to try to change much in here, we will probably need to have Microsoft's involvement... > - _CID fields should be properly formatted ACPI or PNP handles, you > can't put arbitrary strings in there (like BCMAUXSPI or VC4) The Microsoft Windows drivers expect those exact IDs, so that's not something we can alter either. Once again, these ACPI tables were not designed to be ACPI compliant, and making them so that late in the game is going to break a lot of things downstream, so we don't believe that we can do that at this stage. I will apply your other request for ACPI (drop the "-mcmodel=tiny" workaround in [BuildOptions]), as well as the changes you requested for 1/2/19 and, if you are okay with having our hands tied with regards to ACPI compliance, submit a v4 later on today. Regards, /Pete