Re: [edk2-devel] [PATCH V2 2/2] MdeModulePkg PeiCore: Improve comment semantics

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 11/27/19 8:57 PM, Kubacki, Michael A via Groups.Io wrote:
> This patch clarifies wording in several PeiCore comments to improve
> reading comprehension.
> 
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> ---
>   MdeModulePkg/Core/Pei/FwVol/FwVol.h           |  9 ++++----
>   MdeModulePkg/Core/Pei/PeiMain.h               | 11 +++++----
>   MdeModulePkg/Core/Pei/Dependency/Dependency.c |  4 ++--
>   MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c |  4 ++--
>   MdeModulePkg/Core/Pei/FwVol/FwVol.c           | 24 +++++++++++---------
>   MdeModulePkg/Core/Pei/Memory/MemoryServices.c |  4 ++--
>   6 files changed, 30 insertions(+), 26 deletions(-)
> 
[...]
> diff --git a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
> index 838a003baa..e713e6811a 100644
> --- a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
> +++ b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
> @@ -759,7 +759,7 @@ PeiFreePages (
>   /**
>   
>     Pool allocation service. Before permanent memory is discovered, the pool will
> -  be allocated the heap in the temporary memory. Generally, the size of heap in temporary
> +  be allocated in the heap in temporary memory. Generally, the size of the heap in temporary
>     memory does not exceed to 64K, so the biggest pool size could be allocated is

"does not exceed 64K" here too?

>     64K.
>   
> @@ -789,7 +789,7 @@ PeiAllocatePool (
>     //
>   
>     //
> -  // Generally, the size of heap in temporary memory does not exceed to 64K,
> +  // Generally, the size of heap in temporary memory does not exceed 64K,
>     // HobLength is multiples of 8 bytes, so the maximum size of pool is 0xFFF8 - sizeof (EFI_HOB_MEMORY_POOL)
>     //
>     if (Size > (0xFFF8 - sizeof (EFI_HOB_MEMORY_POOL))) {
>