From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web10.6066.1574946381889426451 for ; Thu, 28 Nov 2019 05:06:22 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=f4+wTFVw; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574946380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dLWZpnGKPEQQ4pIn+zSy64o+YLsMzby/Ujc37kpU8hg=; b=f4+wTFVwPdfbenNzvSBYIu2ncyB+C330VceomCn9/S0jQG4UmgbynOhcdSf/aQMLQ1/mmF ha+RdV6rfikjgWDFL6mzGAuRBt8AOxxd1egIE395OOViWBgX5UJSOPM7G0CEdxO9I8aNvp PYOKgrnOi3RVLDc7q2TKtCuOHcM8mgc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-180-ToREO6k5OUq2lh_LiRqreA-1; Thu, 28 Nov 2019 08:06:19 -0500 Received: by mail-wr1-f71.google.com with SMTP id h30so244491wrh.5 for ; Thu, 28 Nov 2019 05:06:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dLWZpnGKPEQQ4pIn+zSy64o+YLsMzby/Ujc37kpU8hg=; b=HepbF0fKQXXILITZTXCYkHXM9wvt2Gn2i/U//N94Mbj6s3ctW2gcUsTQ2esiIAvcz2 dcg8Zcg9fBqPP/DlLtQsN5pSM/ONa3vyPl5qQg3Nv97bBAX/GIhEEhavZD56KBBz7GHV LjZgRnL/Uit544xyzFAQgC0WRRLSCnzwb1aNHK6TiBKzm+pZJlpjvDTp5VH5sfT/GA5t wqY0YpazSC+gyj/1bou82TmzkQtEb5csQdPHmWUC/hbEsw/FDahDQBrNJyRkqTeskr5S VLK+mCsHzeTdau37X350jrOtv8ziNyr5HOfzyXEolzfFa0tZmbRCXM5FKJlXLMIE5bDD I1ig== X-Gm-Message-State: APjAAAWRYUJzWL1dHb4XbeFvMJZgFs9eOyPPWXkSngt2mdjtC+aQjE0f +Pw2CTcWzJ3pJp8FNCSDwFecBzMAiIRRGwkYWDLUs+sgHV74s9iscSQKYEytz2Bo2thFYnPWKDC 4LzVDBuxYm92NgQ== X-Received: by 2002:a1c:40c1:: with SMTP id n184mr10033468wma.116.1574946377782; Thu, 28 Nov 2019 05:06:17 -0800 (PST) X-Google-Smtp-Source: APXvYqwkxDJ3Uq892xNiYEMKKslb/f5hxNJ3tyEmiJONNvYXSaCDozRH/zRmosTPA8vM1/UMqCii5g== X-Received: by 2002:a1c:40c1:: with SMTP id n184mr10033443wma.116.1574946377592; Thu, 28 Nov 2019 05:06:17 -0800 (PST) Return-Path: Received: from [192.168.1.35] (182.red-88-21-103.staticip.rima-tde.net. [88.21.103.182]) by smtp.gmail.com with ESMTPSA id k8sm1246886wrl.3.2019.11.28.05.06.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Nov 2019 05:06:16 -0800 (PST) Subject: Re: [edk2-devel] [PATCH V2 2/2] MdeModulePkg PeiCore: Improve comment semantics To: devel@edk2.groups.io, michael.a.kubacki@intel.com Cc: Dandan Bi , Liming Gao , Jian J Wang , Hao A Wu References: <20191127195747.3192-1-michael.a.kubacki@intel.com> <20191127195747.3192-3-michael.a.kubacki@intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Thu, 28 Nov 2019 14:06:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191127195747.3192-3-michael.a.kubacki@intel.com> X-MC-Unique: ToREO6k5OUq2lh_LiRqreA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 11/27/19 8:57 PM, Kubacki, Michael A via Groups.Io wrote: > This patch clarifies wording in several PeiCore comments to improve > reading comprehension. > > Cc: Dandan Bi > Cc: Liming Gao > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Michael Kubacki > --- > MdeModulePkg/Core/Pei/FwVol/FwVol.h | 9 ++++---- > MdeModulePkg/Core/Pei/PeiMain.h | 11 +++++---- > MdeModulePkg/Core/Pei/Dependency/Dependency.c | 4 ++-- > MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 4 ++-- > MdeModulePkg/Core/Pei/FwVol/FwVol.c | 24 +++++++++++--------- > MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 4 ++-- > 6 files changed, 30 insertions(+), 26 deletions(-) > [...] > diff --git a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c > index 838a003baa..e713e6811a 100644 > --- a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c > +++ b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c > @@ -759,7 +759,7 @@ PeiFreePages ( > /** > > Pool allocation service. Before permanent memory is discovered, the pool will > - be allocated the heap in the temporary memory. Generally, the size of heap in temporary > + be allocated in the heap in temporary memory. Generally, the size of the heap in temporary > memory does not exceed to 64K, so the biggest pool size could be allocated is "does not exceed 64K" here too? > 64K. > > @@ -789,7 +789,7 @@ PeiAllocatePool ( > // > > // > - // Generally, the size of heap in temporary memory does not exceed to 64K, > + // Generally, the size of heap in temporary memory does not exceed 64K, > // HobLength is multiples of 8 bytes, so the maximum size of pool is 0xFFF8 - sizeof (EFI_HOB_MEMORY_POOL) > // > if (Size > (0xFFF8 - sizeof (EFI_HOB_MEMORY_POOL))) { >