From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.10886.1589974866271692214 for ; Wed, 20 May 2020 04:41:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hAMItm2o; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589974865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U4qhUjONQEAoBIYCFKYjgMHWyuBh+g9u+AkiRnp0aA4=; b=hAMItm2oo56Cs1GNSzMbo67UNUqXWFHpVAQwxNVWGMG8mWO5FpkMf24gKtD774Opw2PAcE UdBEPi1Rpz84/hd8MHC2WjO62NApQz1vK7Z1jUNr2QPqm+YpqcXdJLxg5aNaSwRnnbYvfm aNhCsZd9byLq/O5c2dMYNY62eShXdCY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-414-TIDBENx2PVSAkitGnqWsyA-1; Wed, 20 May 2020 07:41:03 -0400 X-MC-Unique: TIDBENx2PVSAkitGnqWsyA-1 Received: by mail-wm1-f72.google.com with SMTP id l26so811332wmh.3 for ; Wed, 20 May 2020 04:41:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=U4qhUjONQEAoBIYCFKYjgMHWyuBh+g9u+AkiRnp0aA4=; b=OxYm9rD5P1SUDW4YK8RekkImauXr6d9V/8w6V9Ji9P7vrNKI6UnntEzbs1Pb2bhInh Xcy/mdX4EfXu4k+R/kz/poK21UWak0oeiJ8WwnYSWG0tjn5Np62XkKtdHk1cp38b/DUU AYlZpDbYPqNP0PjHjbMQU6XU97nmio5xKOf4qEIV2Wmbro7o9ZkijHWpfwj+o2GdoujA jvtPxOxSn72gxDkLGzkTnMAM9ELOBMicvaCnFKx+Gg8c1WTuAd9DNlYSpLZaqUxIT/cj qe41FBjrAbhl746L78I5CKNVfb+4xmaalgvhAYrutoysoy0hI9vBhdJDynNkXqyTWjxm gwEw== X-Gm-Message-State: AOAM532xvZMVaXVPWXmBGiWhFM/Ud+rZPSKq4zYILG/B5wnJIfv1j7ui tnzTtI5XNBg9I+PBHbCcN4/+olZmTGJnpuk05/NIv7lpSVVErcF2LzAgIbZVPJBvkOa9xvQzDfU y4GEAXWVOmCfEpw== X-Received: by 2002:a05:600c:29c2:: with SMTP id s2mr4304918wmd.33.1589974862516; Wed, 20 May 2020 04:41:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy0s5lTfPRwm5YvMhqnFYLoqSv8UEa/7XECIlaxmGhFr1LWqvWspuIyI879GfR7PJ0BX75Qtw== X-Received: by 2002:a05:600c:29c2:: with SMTP id s2mr4304907wmd.33.1589974862350; Wed, 20 May 2020 04:41:02 -0700 (PDT) Return-Path: Received: from [192.168.1.38] (17.red-88-21-202.staticip.rima-tde.net. [88.21.202.17]) by smtp.gmail.com with ESMTPSA id p23sm2800395wma.17.2020.05.20.04.41.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2020 04:41:01 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH v2] NetworkPkg/DxeNetLib: Change the order of conditions in IF statement To: devel@edk2.groups.io, shenglei.zhang@intel.com Cc: Maciej Rabeda , Siyuan Fu , Jiaxin Wu References: <20200520030847.11416-1-shenglei.zhang@intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Wed, 20 May 2020 13:41:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200520030847.11416-1-shenglei.zhang@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 5/20/20 5:08 AM, Zhang, Shenglei wrote: > The condition, NET_HEADSPACE(&(Nbuf->BlockOp[Index])) < Len, is > meaningless if Index = 0. So checking 'Index != 0' should be > performed first in the if statement. > > Cc: Maciej Rabeda > Cc: Siyuan Fu > Cc: Jiaxin Wu > Signed-off-by: Shenglei Zhang > --- > > v2: Update 'Index > 0' to 'Index != 0' > > NetworkPkg/Library/DxeNetLib/NetBuffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/NetworkPkg/Library/DxeNetLib/NetBuffer.c b/NetworkPkg/Library/DxeNetLib/NetBuffer.c > index a232802c9a21..329a17623d94 100644 > --- a/NetworkPkg/Library/DxeNetLib/NetBuffer.c > +++ b/NetworkPkg/Library/DxeNetLib/NetBuffer.c > @@ -1063,7 +1063,7 @@ NetbufAllocSpace ( > } else { > NetbufGetByte (Nbuf, 0, &Index); > > - if ((NET_HEADSPACE(&(Nbuf->BlockOp[Index])) < Len) && (Index > 0)) { > + if ((Index != 0) && (NET_HEADSPACE(&(Nbuf->BlockOp[Index])) < Len)) { Reviewed-by: Philippe Mathieu-Daude > Index--; > } > } >