From: "Ni, Ray" <ray.ni@Intel.com>
To: Shenglei Zhang <shenglei.zhang@intel.com>, edk2-devel@lists.01.org
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
Mike Turner <miketur@microsoft.com>,
Liming Gao <liming.gao@intel.com>
Subject: Re: [PATCH v5] MdePkg/BaseLib: Add Base64Encode() and Base64Decode()
Date: Thu, 31 Jan 2019 15:44:11 +0800 [thread overview]
Message-ID: <d9f0b61b-6b09-80b2-4b00-16ab4cc02044@Intel.com> (raw)
In-Reply-To: <20190131073724.12420-1-shenglei.zhang@intel.com>
Even ECC doesn't complain, I still suggest to change
Encoding_table/Decoding_table to a proper name, e.g.:
EncodingTable/DecodingTable.
With the rename applied in V5 patch,
Reviewed-by: Ray Ni <ray.ni@intel.com>
next prev parent reply other threads:[~2019-01-31 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 7:37 [PATCH v5] MdePkg/BaseLib: Add Base64Encode() and Base64Decode() Shenglei Zhang
2019-01-31 7:44 ` Ni, Ray [this message]
2019-01-31 8:07 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9f0b61b-6b09-80b2-4b00-16ab4cc02044@Intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox