From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=ray.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AE9442194D3B8 for ; Wed, 30 Jan 2019 23:41:49 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 23:41:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,543,1539673200"; d="scan'208";a="315113408" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.3]) ([10.239.9.3]) by fmsmga006.fm.intel.com with ESMTP; 30 Jan 2019 23:41:48 -0800 To: Shenglei Zhang , edk2-devel@lists.01.org Cc: Michael D Kinney , Mike Turner , Liming Gao References: <20190131073724.12420-1-shenglei.zhang@intel.com> From: "Ni, Ray" Message-ID: Date: Thu, 31 Jan 2019 15:44:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190131073724.12420-1-shenglei.zhang@intel.com> Subject: Re: [PATCH v5] MdePkg/BaseLib: Add Base64Encode() and Base64Decode() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 07:41:49 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Even ECC doesn't complain, I still suggest to change Encoding_table/Decoding_table to a proper name, e.g.: EncodingTable/DecodingTable. With the rename applied in V5 patch, Reviewed-by: Ray Ni