Re: [PATCH] UefiCpuPkg/SecCore: Use %x to print stack information

[Laszlo Ersek <lersek@redhat.com>]

On 11/15/16 09:32, Jeff Fan wrote:
> SecCoreData->StackBase is VOID * type and SecCoreData->StackSize is UINTN type.
> We should use %x to dump their value instead of %lx.
> 
> Cast pointer type to UINTN before print it.
> 
> Cc: Feng Tian <feng.tian@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jeff Fan <jeff.fan@intel.com>
> ---
>  UefiCpuPkg/SecCore/SecMain.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/UefiCpuPkg/SecCore/SecMain.c b/UefiCpuPkg/SecCore/SecMain.c
> index 2ebbc22..4d08f48 100644
> --- a/UefiCpuPkg/SecCore/SecMain.c
> +++ b/UefiCpuPkg/SecCore/SecMain.c
> @@ -239,9 +239,9 @@ SecStartupPhase2(
>  
>    DEBUG ((
>      DEBUG_INFO,
> -    "%a() Stack Base: 0x%lx, Stack Size: 0x%lx\n",
> +    "%a() Stack Base: 0x%x, Stack Size: 0x%x\n",
>      __FUNCTION__,
> -    SecCoreData->StackBase,
> +    (UINTN) SecCoreData->StackBase,
>      SecCoreData->StackSize
>      ));
>  
> 

Not disagreeing, just mentioning for completeness: we can also use %p
for printing (VOID*) directly.

Thanks
Laszlo