Re: [edk2-devel] [PATCH] OvmfPkg/GenericQemuLoadImageLib: log "Not Found" at INFO level

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 6/10/20 10:00 AM, Laszlo Ersek wrote:
> On 06/09/20 12:54, Laszlo Ersek wrote:
>> gBS->LoadImage() returning EFI_NOT_FOUND is an expected condition; it
>> means that QEMU wasn't started with "-kernel". Log this status code as
>> INFO rather than ERROR.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>
>> Notes:
>>     Repo:   https://pagure.io/lersek/edk2.git
>>     Branch: gqlil_not_found
>>
>>  OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c b/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c
>> index 14c8417d43e7..114db7e8441f 100644
>> --- a/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c
>> +++ b/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c
>> @@ -106,7 +106,8 @@ QemuLoadKernelImage (
>>      goto UnloadImage;
>>  
>>    default:
>> -    DEBUG ((DEBUG_ERROR, "%a: LoadImage(): %r\n", __FUNCTION__, Status));
>> +    DEBUG ((Status == EFI_NOT_FOUND ? DEBUG_INFO : DEBUG_ERROR,
>> +      "%a: LoadImage(): %r\n", __FUNCTION__, Status));
>>      return Status;
>>    }
>>  
>>
> 
> Merged as commit 14c7ed8b51f6 via
> <https://github.com/tianocore/edk2/pull/678>.

Sorry for being too late here, thanks Ard for the review.

> 
> Thanks
> Laszlo
>