From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web11.2451.1591860365529911363 for ; Thu, 11 Jun 2020 00:26:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=frepErRN; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591860364; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5Ks7NXkq4hANZncHqsV8ICMfRstf1wQclaHDwrftpbY=; b=frepErRNO+71esz5mzmOoQ7eEU5Zr6JhINzuwVxRSZ9z5bSkFc0Y+s6RllbcWFoVCNsMTJ +6l5JMKx4VjrfET1UkvM3mU7Ow18tSA9Zc34ePp70pdAq0NwXFamzUVKvYsEIOvZ1BNxKj VSMVVyBOHY1QthsZt/0JQebOE8vxe88= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-506-evu8R6C8PLyb2bUf6EOgPA-1; Thu, 11 Jun 2020 03:25:59 -0400 X-MC-Unique: evu8R6C8PLyb2bUf6EOgPA-1 Received: by mail-wr1-f71.google.com with SMTP id i6so2194866wrr.23 for ; Thu, 11 Jun 2020 00:25:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=5Ks7NXkq4hANZncHqsV8ICMfRstf1wQclaHDwrftpbY=; b=TKKDIwGhtY9VSQP1tfPERgkDDi5dH5qfexBqW/KRopx5TAiZEqVs85Rnk/e5XTDWzo GeQ2OnRn8r1s1ubdNKOQnEUco4zvQKGXPX0apBILfP0D+oDJoP1/CjkwDfk7CeGcjpCK 775GX2E1UUBof00H2KGSPGgJb0IcxtyWUOwr1Lq2PiS4eelv+lBKExTJUVCrOCSFdkHt P9lKoC7H3symNdwCuSGk0x32VZ3mj3WLcnMhaZsvLdRrOgRcrB4/ubjyq3SeKs7xYcYQ e1RKyYj6MTodvwDZN5xlRozENrmnkd1kYJzxfzbrEZpZnEOcjIyxe1eyIaWpn3BSPrVW a7Pg== X-Gm-Message-State: AOAM533Sv2ngO04TFo80XWQgP1AgK/tSV9lUDTYhdzthex9LC7BVPjIq wtpAnMxOfKp75jPWZilkFIt38aR/DnaeWkXZX/zQscMLbdsoksG4jwbU/iImXKYp5NPXx672u9v PUgogeUzp4RZNQA== X-Received: by 2002:a1c:62d6:: with SMTP id w205mr6390303wmb.97.1591860357759; Thu, 11 Jun 2020 00:25:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBes/9zBYPZTokdzNBTwkOfY8Jhz3MYV2Kem0UNc2+0WoEID/TnEhVW1FHktaORgzFNvzFPQ== X-Received: by 2002:a1c:62d6:: with SMTP id w205mr6390283wmb.97.1591860357570; Thu, 11 Jun 2020 00:25:57 -0700 (PDT) Return-Path: Received: from [192.168.1.38] (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id c5sm3734402wrb.72.2020.06.11.00.25.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2020 00:25:57 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH] OvmfPkg/GenericQemuLoadImageLib: log "Not Found" at INFO level To: devel@edk2.groups.io, lersek@redhat.com Cc: Ard Biesheuvel , Jordan Justen References: <20200609105414.12474-1-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: Date: Thu, 11 Jun 2020 09:25:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 6/10/20 10:00 AM, Laszlo Ersek wrote: > On 06/09/20 12:54, Laszlo Ersek wrote: >> gBS->LoadImage() returning EFI_NOT_FOUND is an expected condition; it >> means that QEMU wasn't started with "-kernel". Log this status code as >> INFO rather than ERROR. >> >> Cc: Ard Biesheuvel >> Cc: Jordan Justen >> Cc: Philippe Mathieu-Daudé >> Signed-off-by: Laszlo Ersek >> --- >> >> Notes: >> Repo: https://pagure.io/lersek/edk2.git >> Branch: gqlil_not_found >> >> OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c b/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c >> index 14c8417d43e7..114db7e8441f 100644 >> --- a/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c >> +++ b/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c >> @@ -106,7 +106,8 @@ QemuLoadKernelImage ( >> goto UnloadImage; >> >> default: >> - DEBUG ((DEBUG_ERROR, "%a: LoadImage(): %r\n", __FUNCTION__, Status)); >> + DEBUG ((Status == EFI_NOT_FOUND ? DEBUG_INFO : DEBUG_ERROR, >> + "%a: LoadImage(): %r\n", __FUNCTION__, Status)); >> return Status; >> } >> >> > > Merged as commit 14c7ed8b51f6 via > . Sorry for being too late here, thanks Ard for the review. > > Thanks > Laszlo >