From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c01::243; helo=mail-pl0-x243.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pl0-x243.google.com (mail-pl0-x243.google.com [IPv6:2607:f8b0:400e:c01::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 717BB21962301 for ; Wed, 8 Aug 2018 17:35:36 -0700 (PDT) Received: by mail-pl0-x243.google.com with SMTP id b90-v6so1765740plb.0 for ; Wed, 08 Aug 2018 17:35:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=NMH8DATmrRnC/lX91XAdHKTGrcOqTzq2YNDpH20Q0No=; b=Sn11OkFufANQI2WejdgBWvx0PDYCWlMN5fnd5MC39Q/lphSq+/28YjGszzHiIFb3w5 MDjM07OLvUuYlVeRmk6VlOKoJG14QAiZ+zF44tE+dgyrae5j7n1I7t65xewWOhkrr328 RjZCF4rMQBVUZr+bsKV6ytFcq5nVW/7eoEBAI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=NMH8DATmrRnC/lX91XAdHKTGrcOqTzq2YNDpH20Q0No=; b=P+6okDSGkzhQs6uA4UiueKgkkJGA5NVgw4hDostilwrrltKqbd28ph7LzAEKHZ2t76 RTt/Trbr4fiv6hk1UlzcuOjp6V5wWDAaMIZV+VWUuvRBn5Ul60DNweUH/svJhbbvTOLp w57CrXq8Kx/OHXzVTs9fEzMzQ+s0ZgjRRmUnCv0wkRR4AEk4v/CkGvLXM3meuGO1D74m zKKu3Py18xtoco/OhA309vS6d866A1MyumgN+4FWZAe9MgEVzxvm/SZq/G3px6fLlWmG ylyhrRe8wNIbvsBZiP5OAuY1Y5zWiG62LglJaxwTO+4LOTOXr1JDOIk5VHyNuPUYivOQ Ib9w== X-Gm-Message-State: AOUpUlGuMomaXeZTBzGzNH1rM7hxuHegmy0rDcfMe5EbXtOZU6B3iSnN WrsKOZ13BF95AkY8o05zZgTIVg== X-Google-Smtp-Source: AA+uWPz9eEcqQ1s8BdFK+OTdK8oYMUEW3oM6WslD9vYtUW3hDfUFAdtP7AGJH8p45WmNZGPjDl/zUw== X-Received: by 2002:a17:902:6ac7:: with SMTP id i7-v6mr4581160plt.288.1533774936016; Wed, 08 Aug 2018 17:35:36 -0700 (PDT) Received: from [10.199.0.182] ([64.64.108.224]) by smtp.gmail.com with ESMTPSA id p19-v6sm10022596pgk.28.2018.08.08.17.35.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Aug 2018 17:35:35 -0700 (PDT) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, Yang XinYi , Heyi Guo References: <20180724070922.63362-1-ming.huang@linaro.org> <20180724070922.63362-19-ming.huang@linaro.org> <20180803133238.2m3fgnytxvgeviy2@bivouac.eciton.net> From: Ming Message-ID: Date: Thu, 9 Aug 2018 08:35:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180803133238.2m3fgnytxvgeviy2@bivouac.eciton.net> Subject: Re: [PATCH edk2-platforms v1 18/38] Silicon/Hisilicon/Setup: Add Setup Item "EnableGOP" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 00:35:36 -0000 Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit ÔÚ 8/3/2018 9:32 PM, Leif Lindholm дµÀ: > On Tue, Jul 24, 2018 at 03:09:02PM +0800, Ming Huang wrote: >> From: Yang XinYi >> >> Add Setup Item "EnableGOP" for D06, This Item only takes >> effect on SM750 > > What is SM750? Please add more detail to commit message. > SM750 is a VGA device on board. Add it in v2. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Yang XinYi >> Signed-off-by: Ming Huang >> Signed-off-by: Heyi Guo >> --- >> Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr | 7 +++++++ >> Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni | 8 ++++---- >> Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c | 2 +- >> Silicon/Hisilicon/Include/Library/OemConfigData.h | 1 + >> 4 files changed, 13 insertions(+), 5 deletions(-) >> >> diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr >> index 9e3ac73116..c0b6e294a6 100644 >> --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr >> +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr >> @@ -38,4 +38,11 @@ form formid = MISC_CONFIG_FORM_ID, >> option text = STRING_TOKEN(STR_ENABLED), value = 1, flags = 0; >> endoneof; >> >> + oneof varid = OEM_CONFIG_DATA.EnableGOP, >> + prompt = STRING_TOKEN(STR_ENABLE_GOP_FRAME_BUFFER), >> + help = STRING_TOKEN(STR_ENABLE_GOP_FRAME_BUFFER_HELP), >> + option text = STRING_TOKEN(STR_DISABLED), value = 0, flags = DEFAULT; >> + option text = STRING_TOKEN(STR_ENABLED), value = 1, flags = 0; >> + endoneof; >> + >> endform; >> diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni >> index 5ad1d1df30..0170c84ff6 100644 >> --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni >> +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni >> @@ -30,7 +30,7 @@ >> #language fr-FR "Support SPCR" >> #string STR_ENABLE_SPCR_HELP #language en-US "Enable or Disable SPCR Table." >> #language fr-FR "Activer ou d¨¦sactiver la table SPCR." >> -#string STR_ENABLE_GOP_FRAME_BUFFER #language en-US "Support GOP FB" >> - #language fr-FR "Support GOP FB" >> -#string STR_ENABLE_GOP_FRAME_BUFFER_HELP #language en-US "Enable or Disable GOP frame buffer." >> - #language fr-FR "Activer ou d¨¦sactiver Buffer de frame GOP." >> +#string STR_ENABLE_GOP_FRAME_BUFFER #language en-US "Support GOP FB for SM750" >> + #language fr-FR "Soutien GOP FB pour SM750" >> +#string STR_ENABLE_GOP_FRAME_BUFFER_HELP #language en-US "Enable or Disable GOP frame buffer for SM750." >> + #language fr-FR "Activer ou d¨¦sactiver Buffer de frame GOP pour SM750." >> diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c >> index 586094dfbf..88051493cf 100644 >> --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c >> +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c >> @@ -311,7 +311,7 @@ OemConfigUiLibConstructor ( >> Configuration.EnableSmmu = 1; >> Configuration.EnableFdtTable = 0; >> Configuration.EnableSpcr = 0; >> - //Configuration.EnableGOP=0; >> + Configuration.EnableGOP = 0; > > I _think_ I commented to delete that line on a previous patch. If not, > please delete the commented out line from wherever it was introduced. > OK, do it in v2. Thanks. > / > Leif > >> // >> //Set the default value of the Ras option >> // >> diff --git a/Silicon/Hisilicon/Include/Library/OemConfigData.h b/Silicon/Hisilicon/Include/Library/OemConfigData.h >> index 478821ae2c..e4d5917046 100644 >> --- a/Silicon/Hisilicon/Include/Library/OemConfigData.h >> +++ b/Silicon/Hisilicon/Include/Library/OemConfigData.h >> @@ -61,6 +61,7 @@ typedef struct { >> UINT8 EnableSmmu; >> UINT8 EnableFdtTable; >> UINT8 EnableSpcr; >> + UINT8 EnableGOP; >> /*RAS Config*/ >> UINT8 EnRasSupport; >> UINT8 EnPoison; >> -- >> 2.17.0 >>