public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Taylor Beebe" <taylor.d.beebe@gmail.com>
To: devel@edk2.groups.io, mike.maslenkin@gmail.com, ardb@kernel.org
Cc: Michael Kubacki <mikuback@linux.microsoft.com>,
	Taylor Beebe <t@taylorbeebe.com>,
	Michael Kinney <michael.d.kinney@intel.com>,
	Oliver Smith-Denny <osde@linux.microsoft.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>
Subject: Re: [edk2-devel] another PR rejected by CI
Date: Mon, 28 Aug 2023 11:19:48 -0700	[thread overview]
Message-ID: <da19f878-4fbe-47a7-b0ff-4265970cf0d2@gmail.com> (raw)
In-Reply-To: <CAL77WPAsw20zxUFUrjeP7ahm6K4ruYxbY7UQDZFAbCNK2ufMew@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1734 bytes --]

Here's a git-patch so you can easily fix it:

---
  OvmfPkg/IoMmuDxe/IoMmuBuffer.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/IoMmuDxe/IoMmuBuffer.c b/OvmfPkg/IoMmuDxe/IoMmuBuffer.c
index 2764c35044ac..d66763263784 100644
--- a/OvmfPkg/IoMmuDxe/IoMmuBuffer.c
+++ b/OvmfPkg/IoMmuDxe/IoMmuBuffer.c
@@ -434,7 +434,7 @@ IoMmuFreeBounceBuffer (
        mReservedMemBitmap,
        mReservedMemBitmap & ((UINT32)(~MapInfo->ReservedMemBitmap))
        ));
-    MapInfo->PlainTextAddress  = 0;
+    MapInfo->PlainTextAddress = 0;
      ClearReservedMemBit (MapInfo->ReservedMemBitmap);
      MapInfo->ReservedMemBitmap = 0;
    }
-- 
On 8/28/2023 11:16 AM, Mike Maslenkin wrote:
> Hello!
>
> https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=100301&view=ms.vss-test-web.build-test-results-tab&runId=877528&resultId=100006&paneView=attachments
>
> Uncrustify found formatting errors in IoMmuDxe/IoMmuBuffer.c
> See Standard_Error_Output.log in "attachments"
>
> It doesn't like two spaces at assignment
> MapInfo->PlainTextAddress_ _= 0;
>
> Best Regards,
> Mike
>
>
> On Mon, Aug 28, 2023 at 8:58 PM Ard Biesheuvel<ardb@kernel.org>  wrote:
>> Could someone please explain to me how I can figure out why this PR
>> was rejected by the CI?
>>
>> https://github.com/tianocore/edk2/pull/4763
>>
>>
>>
>>
>>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108062): https://edk2.groups.io/g/devel/message/108062
Mute This Topic: https://groups.io/mt/101015386/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 4121 bytes --]

  reply	other threads:[~2023-08-28 18:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-28 17:57 [edk2-devel] another PR rejected by CI Ard Biesheuvel
2023-08-28 18:16 ` Mike Maslenkin
2023-08-28 18:19   ` Taylor Beebe [this message]
2023-08-28 18:43     ` Oliver Smith-Denny
2023-08-28 18:37 ` Michael D Kinney
2023-08-28 19:04   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da19f878-4fbe-47a7-b0ff-4265970cf0d2@gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox