From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B5611941C3D for ; Mon, 28 Aug 2023 18:19:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=N40vFYL5WjkpRI0wfM/wSxCSIDa8q61c3mLLmX7i4xs=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20140610; t=1693246791; v=1; b=WYDO0qvrJB5J3VVvz2Y+I/mTNcDHkWkOx9kofQmXgDcI6ygFX2VXiVToaMOwiJ5XWZHTd3ZG enJ5twAhgrJnyG4dD0GOpUxsZAqTHOSRghHz/ErSp38+BV3wSLoVxLC6tloYwYWbEJtWmzQ2SSL shl3PYt/JPPhNWB68jUbnEYw= X-Received: by 127.0.0.2 with SMTP id a04HYY7687511xCCZvPJg86o; Mon, 28 Aug 2023 11:19:51 -0700 X-Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mx.groups.io with SMTP id smtpd.web10.577.1693246790703058721 for ; Mon, 28 Aug 2023 11:19:50 -0700 X-Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-26814e27a9eso1807172a91.0 for ; Mon, 28 Aug 2023 11:19:50 -0700 (PDT) X-Gm-Message-State: wGZ8pSp8y28MjLk6KMSC4Dk4x7686176AA= X-Google-Smtp-Source: AGHT+IHEsFfMkw03C76G7Sqsi9sMoEhJaoXEnMlosZrFaBme0THJY1T4GYIMlfsCKkF4vb3FBtsf5Q== X-Received: by 2002:a17:90b:e8b:b0:268:1355:b03e with SMTP id fv11-20020a17090b0e8b00b002681355b03emr21115118pjb.38.1693246789742; Mon, 28 Aug 2023 11:19:49 -0700 (PDT) X-Received: from [192.168.0.125] ([50.46.253.1]) by smtp.gmail.com with ESMTPSA id j15-20020a17090a2a8f00b00262ca945cecsm9882114pjd.54.2023.08.28.11.19.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Aug 2023 11:19:49 -0700 (PDT) Message-ID: Date: Mon, 28 Aug 2023 11:19:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] another PR rejected by CI To: devel@edk2.groups.io, mike.maslenkin@gmail.com, ardb@kernel.org Cc: Michael Kubacki , Taylor Beebe , Michael Kinney , Oliver Smith-Denny , Leif Lindholm References: From: "Taylor Beebe" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,taylor.d.beebe@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: multipart/alternative; boundary="------------I0ffF6GZe0kbfEnOidXA0JQk" Content-Language: en-US X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=WYDO0qvr; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------I0ffF6GZe0kbfEnOidXA0JQk Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Here's a git-patch so you can easily fix it: ---  OvmfPkg/IoMmuDxe/IoMmuBuffer.c | 2 +-  1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/IoMmuDxe/IoMmuBuffer.c b/OvmfPkg/IoMmuDxe/IoMmuBuffer.c index 2764c35044ac..d66763263784 100644 --- a/OvmfPkg/IoMmuDxe/IoMmuBuffer.c +++ b/OvmfPkg/IoMmuDxe/IoMmuBuffer.c @@ -434,7 +434,7 @@ IoMmuFreeBounceBuffer (        mReservedMemBitmap,        mReservedMemBitmap & ((UINT32)(~MapInfo->ReservedMemBitmap))        )); -    MapInfo->PlainTextAddress  = 0; +    MapInfo->PlainTextAddress = 0;      ClearReservedMemBit (MapInfo->ReservedMemBitmap);      MapInfo->ReservedMemBitmap = 0;    } -- On 8/28/2023 11:16 AM, Mike Maslenkin wrote: > Hello! > > https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=100301&view=ms.vss-test-web.build-test-results-tab&runId=877528&resultId=100006&paneView=attachments > > Uncrustify found formatting errors in IoMmuDxe/IoMmuBuffer.c > See Standard_Error_Output.log in "attachments" > > It doesn't like two spaces at assignment > MapInfo->PlainTextAddress_ _= 0; > > Best Regards, > Mike > > > On Mon, Aug 28, 2023 at 8:58 PM Ard Biesheuvel wrote: >> Could someone please explain to me how I can figure out why this PR >> was rejected by the CI? >> >> https://github.com/tianocore/edk2/pull/4763 >> >> >> >> >> > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108062): https://edk2.groups.io/g/devel/message/108062 Mute This Topic: https://groups.io/mt/101015386/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --------------I0ffF6GZe0kbfEnOidXA0JQk Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Here's a git-patch so you can easily fix it:

---
 OvmfPkg/IoMmuDxe/IoMmuBuffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/IoMmuDxe/IoMmuBuffer.c b/OvmfPkg/IoMmuDxe/IoMmuBuffer.c
index 2764c35044ac..d66763263784 100644
--- a/OvmfPkg/IoMmuDxe/IoMmuBuffer.c
+++ b/OvmfPkg/IoMmuDxe/IoMmuBuffer.c
@@ -434,7 +434,7 @@ IoMmuFreeBounceBuffer (
       mReservedMemBitmap,
       mReservedMemBitmap & ((UINT32)(~MapInfo->ReservedMemBitmap))
       ));
-    MapInfo->PlainTextAddress  = 0;
+    MapInfo->PlainTextAddress = 0;
     ClearReservedMemBit (MapInfo->ReservedMemBitmap);
     MapInfo->ReservedMemBitmap = 0;
   }
--
On 8/28/2023 11:16 AM, Mike Maslenkin wrote:
Hello!

https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=100301&view=ms.vss-test-web.build-test-results-tab&runId=877528&resultId=100006&paneView=attachments

Uncrustify found formatting errors in IoMmuDxe/IoMmuBuffer.c
See Standard_Error_Output.log in "attachments"

It doesn't like two spaces at assignment
MapInfo->PlainTextAddress_ _= 0;

Best Regards,
Mike


On Mon, Aug 28, 2023 at 8:58 PM Ard Biesheuvel <ardb@kernel.org> wrote:

Could someone please explain to me how I can figure out why this PR
was rejected by the CI?

https://github.com/tianocore/edk2/pull/4763
_._,_._,_
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#108062) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------I0ffF6GZe0kbfEnOidXA0JQk--