From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 53199D80A5F for ; Tue, 26 Sep 2023 16:02:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=tzdNifJofW6P3opRP7aKcRuCol5YFuPiRP0y1aOGAlc=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695744167; v=1; b=jM95CTC3hGOE8rvMbOkSMnlYcfsghKCuS4k/1gy3EynE9HqedqehG4EWtsYAr/mkUq39MRi+ XJ0O8+hWxbzqsWQtzkVZZmmiGLcDN7K6XQIR0UguoN4+o/+f2dWmrVa5qcmTFyjc43DIVibPN36 LAxn6AbNzRl9St8oHEyjK/1Y= X-Received: by 127.0.0.2 with SMTP id u4xCYY7687511xb9At2OmEUc; Tue, 26 Sep 2023 09:02:47 -0700 X-Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mx.groups.io with SMTP id smtpd.web11.22967.1695744166347366144 for ; Tue, 26 Sep 2023 09:02:46 -0700 X-Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-6910ea9cddbso8006492b3a.0 for ; Tue, 26 Sep 2023 09:02:46 -0700 (PDT) X-Gm-Message-State: xONniekluxLUUGX7hNWTrYf1x7686176AA= X-Google-Smtp-Source: AGHT+IHZ6sGniUsTUKHEVKoF6NCGnqwdD1VqsbRvHWHtFscWc27IVKrKcTcgEIGLTTGMH78YKIQ6qQ== X-Received: by 2002:a05:6a00:134b:b0:68a:3b39:a486 with SMTP id k11-20020a056a00134b00b0068a3b39a486mr12314303pfu.24.1695744165688; Tue, 26 Sep 2023 09:02:45 -0700 (PDT) X-Received: from [192.168.0.233] ([50.46.253.1]) by smtp.gmail.com with ESMTPSA id 22-20020aa79216000000b00690dbab1623sm10094687pfo.81.2023.09.26.09.02.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Sep 2023 09:02:45 -0700 (PDT) Message-ID: Date: Tue, 26 Sep 2023 09:02:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v4 00/14] Add ImagePropertiesRecordLib and Fix MAT Bugs To: Ard Biesheuvel Cc: devel@edk2.groups.io, Andrew Fish , Ard Biesheuvel , Dandan Bi , Eric Dong , Gerd Hoffmann , Guo Dong , Gua Guo , James Lu , Jian J Wang , Jiewen Yao , Jordan Justen , Leif Lindholm , Liming Gao , Rahul Kumar , Ray Ni , Sami Mujawar , Sean Rhodes References: <177845D072580598.19347@groups.io> <177BEFB7EF58B50B.8497@groups.io> From: "Taylor Beebe" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,taylor.d.beebe@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=jM95CTC3; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) Reviews on this patch series would be much appreciated :) On 8/28/23 9:38 AM, Ard Biesheuvel wrote: > I was hoping to get around to this before the end of the week (but I > am not a MdeModulePkg maintainer) > > > On Mon, 28 Aug 2023 at 18:27, Taylor Beebe wro= te: >> Can I please get reviews/feedback on this patch series? >> >> On 8/16/23 11:14 AM, Taylor Beebe via groups.io wrote: >>> Can I please get reviews/feedback on this patch series? >>> >>> On 8/4/2023 12:46 PM, Taylor Beebe via groups.io wrote: >>>> From: Taylor Beebe >>>> >>>> v4: >>>> - Expose additional functions in the Library API >>>> - Add NULL checks to library functions and return a >>>> status where applicable. >>>> >>>> v3: >>>> - Refactor patch series so the transition of logic from the DXE >>>> MAT logic to the new library is more clear. >>>> - Update function headers to improve clarity and follow EDK2 >>>> standards. >>>> - Add Create and Delete functions for Image Properties Records >>>> and redirect some of the SMM and DXE MAT code to use these >>>> functions. >>>> - Update/Add DumpImageRecords() to print the image name and code >>>> sections of each runtime image which will be put in the MAT. >>>> The DXE and SMM MAT logic will now invoke the DumpImageRecords() >>>> on DEBUG builds at the EndOfDxe event to install the MAT. >>>> >>>> v2: >>>> - A one-line change in patch 3 was moved to patch 9 for correctness. >>>> >>>> Reference: https://github.com/tianocore/edk2/pull/4590 >>>> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4492 >>>> >>>> The UEFI and SMM MAT logic contains duplicate logic for manipulating >>>> image >>>> properties records which is used to track runtime images. >>>> This patch series adds a new library, ImagePropertiesRecordLib, >>>> which consolidates this logic and fixes the bugs which currently >>>> exist in >>>> the MAT logic. >>>> >>>> The first patch adds the ImagePropertiesRecordLib implementation which >>>> is a copy of the UEFI MAT logic with minor modifications to remove the >>>> reliance on globabl variables and make the code unit testable. >>>> >>>> The second patch adds a unit test for the ImagePropertiesRecordLib. Th= e >>>> logic tests various potential layouts of the EFI memory map and runtim= e >>>> images. 3/4 of these tests will fail which demonstrates the MAT logic >>>> bugs. >>>> >>>> The third patch fixes the logic in the ImagePropertiesRecordLib so >>>> that all of the unit tests pass and the MAT logic can be fixed by >>>> using the library. >>>> >>>> The remaining patches add library instances to DSC files and remove >>>> the image properties record logic from the SMM and UEFI MAT logic. >>>> >>>> Cc: Andrew Fish >>>> Cc: Ard Biesheuvel >>>> Cc: Dandan Bi >>>> Cc: Eric Dong >>>> Cc: Gerd Hoffmann >>>> Cc: Guo Dong >>>> Cc: Gua Guo >>>> Cc: James Lu >>>> Cc: Jian J Wang >>>> Cc: Jiewen Yao >>>> Cc: Jordan Justen >>>> Cc: Leif Lindholm >>>> Cc: Liming Gao >>>> Cc: Rahul Kumar >>>> Cc: Ray Ni >>>> Cc: Sami Mujawar >>>> Cc: Sean Rhodes >>>> >>>> Taylor Beebe (14): >>>> MdeModulePkg: Add ImagePropertiesRecordLib >>>> ArmVirtPkg: Add ImagePropertiesRecordLib Instance >>>> EmulatorPkg: Add ImagePropertiesRecordLib Instance >>>> OvmfPkg: Add ImagePropertiesRecordLib Instance >>>> UefiPayloadPkg: Add ImagePropertiesRecordLib Instance >>>> MdeModulePkg: Update MemoryAttributesTable.c to Reduce Global >>>> Variable >>>> Use >>>> MdeModulePkg: Move Some DXE MAT Logic to ImagePropertiesRecordLib >>>> MdeModulePkg: Add ImagePropertiesRecordLib Host-Based Unit Test >>>> MdeModulePkg: Fix Bugs in MAT Logic >>>> MdeModulePkg: Add NULL checks and Return Status to >>>> ImagePropertiesRecordLib >>>> UefiCpuPkg: Use Attribute From SMM MemoryAttributesTable if Nonzer= o >>>> MdeModulePkg: Transition SMM MAT Logic to Use >>>> ImagePropertiesRecordLib >>>> MdeModulePkg: Add Logic to Create/Delete Image Properties Records >>>> MdeModulePkg: Update DumpImageRecord() in ImagePropertiesRecordLib >>>> >>>> MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c | 967 >>>> +---------------- >>>> MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 24 +- >>>> MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c | 958 >>>> +--------------- >>>> MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib= .c >>>> | 1144 ++++++++++++++++++++ >>>> MdeModulePkg/Library/ImagePropertiesRecordLib/UnitTest/ImageProperties= RecordLibUnitTestHost.c >>>> | 938 ++++++++++++++++ >>>> UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 19 +- >>>> ArmVirtPkg/ArmVirt.dsc.inc | 1 + >>>> EmulatorPkg/EmulatorPkg.dsc | 1 + >>>> MdeModulePkg/Core/Dxe/DxeMain.h | 20 - >>>> MdeModulePkg/Core/Dxe/DxeMain.inf | 1 + >>>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 1 + >>>> MdeModulePkg/Include/Library/ImagePropertiesRecordLib.h | 234 ++++ >>>> MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib= .inf >>>> | 31 + >>>> MdeModulePkg/Library/ImagePropertiesRecordLib/UnitTest/ImageProperties= RecordLibUnitTestHost.inf >>>> | 35 + >>>> MdeModulePkg/MdeModulePkg.dec | 5 + >>>> MdeModulePkg/MdeModulePkg.dsc | 2 + >>>> MdeModulePkg/Test/MdeModulePkgHostTest.dsc | 6 + >>>> OvmfPkg/AmdSev/AmdSevX64.dsc | 1 + >>>> OvmfPkg/Bhyve/BhyveX64.dsc | 1 + >>>> OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + >>>> OvmfPkg/IntelTdx/IntelTdxX64.dsc | 1 + >>>> OvmfPkg/Microvm/MicrovmX64.dsc | 1 + >>>> OvmfPkg/OvmfPkgIa32.dsc | 1 + >>>> OvmfPkg/OvmfPkgIa32X64.dsc | 1 + >>>> OvmfPkg/OvmfPkgX64.dsc | 1 + >>>> OvmfPkg/OvmfXen.dsc | 1 + >>>> OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc | 1 + >>>> UefiPayloadPkg/UefiPayloadPkg.dsc | 1 + >>>> 28 files changed, 2524 insertions(+), 1874 deletions(-) >>>> create mode 100644 >>>> MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib= .c >>>> create mode 100644 >>>> MdeModulePkg/Library/ImagePropertiesRecordLib/UnitTest/ImageProperties= RecordLibUnitTestHost.c >>>> create mode 100644 >>>> MdeModulePkg/Include/Library/ImagePropertiesRecordLib.h >>>> create mode 100644 >>>> MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib= .inf >>>> create mode 100644 >>>> MdeModulePkg/Library/ImagePropertiesRecordLib/UnitTest/ImageProperties= RecordLibUnitTestHost.inf >>>> -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109072): https://edk2.groups.io/g/devel/message/109072 Mute This Topic: https://groups.io/mt/100553430/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-