From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mx.groups.io with SMTP id smtpd.web10.2154.1632942909990975315 for ; Wed, 29 Sep 2021 12:15:10 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@ibm.com header.s=pp1 header.b=aEZBPdCW; spf=pass (domain: linux.ibm.com, ip: 148.163.156.1, mailfrom: stefanb@linux.ibm.com) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18TIX0aD015722; Wed, 29 Sep 2021 15:15:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=8bfIh3xaPoykU+yFQwdbJ+G+/C1aUyrZCrD9fVhP0P0=; b=aEZBPdCWKXzBAfUmT83G5NcavIxrnfrFiIKQUQHj1QQWS6DPoIWtdSm/ztkVxDIkBGLr ibYwv0bO+38t2UAxLrZl/WBkZInVjD5iCxOIDEQkYfNFi3H16NfkkBs1zRIwjxlE84o0 PEnvXU3U9sdBEC6wRQOVTIj6j6JAffdpAe/OxABvHUR88oh+t+m+WdwmxfeWquNeN9WL am1IeraMz+Wc36DWUhcA8UuzI/zdqtMveDmdfZPMZWV/+4eqmHEXt6neuKY6F7I58Vxt AxaquDz2UoCOLV0NvWifHFer2AFriucz2gRh6iPUVBUVJ6rMxnHr9ZSQVK2d6V5Tk6gK IQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3bcueucm16-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Sep 2021 15:15:09 -0400 Received: from m0098396.ppops.net (m0098396.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 18TImrwd006369; Wed, 29 Sep 2021 15:15:08 -0400 Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com with ESMTP id 3bcueucm0p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Sep 2021 15:15:08 -0400 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 18TJ9NwP002782; Wed, 29 Sep 2021 19:15:07 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma03wdc.us.ibm.com with ESMTP id 3b9udbg65k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Sep 2021 19:15:07 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 18TJF6Av54395136 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Sep 2021 19:15:06 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E8B6878064; Wed, 29 Sep 2021 19:15:05 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9B19E78063; Wed, 29 Sep 2021 19:15:05 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 29 Sep 2021 19:15:05 +0000 (GMT) Subject: Re: [edk2-devel] [PATCH v2 0/4] OvmfPkg: Disable the TPM 2 platform hierarchy To: devel@edk2.groups.io, jiewen.yao@intel.com Cc: "mhaeuser@posteo.de" , "spbrogan@outlook.com" , "marcandre.lureau@redhat.com" , "kraxel@redhat.com" References: <20210914141818.2583900-1-stefanb@linux.ibm.com> From: "Stefan Berger" Message-ID: Date: Wed, 29 Sep 2021 15:15:05 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 4Z78J2iRWVc7bFoHGcvXeYlKGYPrO467 X-Proofpoint-GUID: YySdmpOeybNkAJ8wIvOihLnZaZ_23VzS X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-29_07,2021-09-29_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 phishscore=0 spamscore=0 priorityscore=1501 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2109290111 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-001b2d01.pphosted.com id 18TIX0aD015722 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 9/14/21 6:26 PM, Yao, Jiewen wrote: > Reviewed-by: Jiewen Yao > > I will wait for a week, to see if there is any feedback from AMD or Bhyve= reviewer. I didn't see any more comments to v3=20 (https://listman.redhat.com/archives/edk2-devel-archive/2021-September/msg0= 0641.html)=20 So maybe you can apply it to the repo. =C2=A0=C2=A0 Stefan > > Thank you > Yao Jiewen > > >> -----Original Message----- >> From: Stefan Berger >> Sent: Tuesday, September 14, 2021 10:18 PM >> To: devel@edk2.groups.io >> Cc: mhaeuser@posteo.de; spbrogan@outlook.com; >> marcandre.lureau@redhat.com; kraxel@redhat.com; Yao, Jiewen >> ; Stefan Berger >> Subject: [PATCH v2 0/4] OvmfPkg: Disable the TPM 2 platform hierarchy >> >> This series of patches adds support for disabling the TPM 2 platform >> hierarchy to Ovmf. To be able to do this we have to handle TPM 2 >> physical presence interface (PPI) opcodes before the TPM 2 platform >> hierarchy is disabled otherwise TPM 2 commands that are sent due to the >> PPI opcodes may fail if the platform hierarchy is already disabled. >> Therefore, we need to invoke the handler function >> Tcg2PhysicalPresenceLibProcessRequest from within >> PlatformBootManagerBeforeConsole. Since handling of PPI opcodes may >> require >> interaction with the user, we also move PlatformInitializeConsole >> to before the handling of PPI codes so that the keyboard is available >> when needed. The PPI handling code will activate the default consoles >> only if it requires user interaction. >> >> Regards, >> Stefan >> >> v2: >> - 1/4: Added missing link library >> - 2/4: Modified other BdsPlatform.c files as well >> - Added Yao's comments to 1/2 and 2/2 >> >> Stefan Berger (4): >> OvmfPkg/TPM PPI: Connect default consoles for user interaction >> OvmfPkg: Handle TPM 2 physical presence opcodes much earlier >> OvmfPkg: Reference new Tcg2PlatformDxe in the build system for >> compilation >> OvmfPkg: Reference new Tcg2PlatformPei in the build system >> >> OvmfPkg/AmdSev/AmdSevX64.dsc | 8 ++++++++ >> OvmfPkg/AmdSev/AmdSevX64.fdf | 2 ++ >> .../PlatformBootManagerLib/BdsPlatform.c | 19 +++++++++++-------- >> .../PlatformBootManagerLibBhyve/BdsPlatform.c | 16 +++++++++------- >> .../PlatformBootManagerLibGrub/BdsPlatform.c | 16 +++++++++------- >> .../DxeTcg2PhysicalPresenceLib.c | 5 +++++ >> .../DxeTcg2PhysicalPresenceLib.inf | 1 + >> OvmfPkg/OvmfPkgIa32.dsc | 8 ++++++++ >> OvmfPkg/OvmfPkgIa32.fdf | 2 ++ >> OvmfPkg/OvmfPkgIa32X64.dsc | 8 ++++++++ >> OvmfPkg/OvmfPkgIa32X64.fdf | 2 ++ >> OvmfPkg/OvmfPkgX64.dsc | 8 ++++++++ >> OvmfPkg/OvmfPkgX64.fdf | 2 ++ >> 13 files changed, 75 insertions(+), 22 deletions(-) >> >> -- >> 2.31.1 > > >=20 > >