* [edk2-devel][PATCH] ArmPkg/ArmPciCpuIo2Dxe: Correct pci io memmap address
@ 2020-09-15 9:35 Yu Liu
2020-09-15 9:38 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Yu Liu @ 2020-09-15 9:35 UTC (permalink / raw)
To: ard.biesheuvel, leif; +Cc: devel, LiuYu
Since the device addresss has been translated in PciRootBridgeIo.c
so shuldn't translate it twice in ArmPciCpuIo2Dxe.c
Signed-off-by: LiuYu <liuyu@greatwall.com.cn>
---
ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.c b/ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.c
index d8625e1593..8c46a2778b 100644
--- a/ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.c
+++ b/ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.c
@@ -399,7 +399,6 @@ CpuIoServiceRead (
return Status;
}
- Address += PcdGet64 (PcdPciIoTranslation);
//
// Select loop based on the width of the transfer
@@ -485,7 +484,6 @@ CpuIoServiceWrite (
return Status;
}
- Address += PcdGet64 (PcdPciIoTranslation);
//
// Select loop based on the width of the transfer
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [edk2-devel][PATCH] ArmPkg/ArmPciCpuIo2Dxe: Correct pci io memmap address
2020-09-15 9:35 [edk2-devel][PATCH] ArmPkg/ArmPciCpuIo2Dxe: Correct pci io memmap address Yu Liu
@ 2020-09-15 9:38 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2020-09-15 9:38 UTC (permalink / raw)
To: LiuYu, leif; +Cc: devel
On 9/15/20 11:35 AM, LiuYu wrote:
> Since the device addresss has been translated in PciRootBridgeIo.c
> so shuldn't translate it twice in ArmPciCpuIo2Dxe.c
>
> Signed-off-by: LiuYu <liuyu@greatwall.com.cn>
Nack. The I/O translation in the I/O domain and the mapping of the I/O
window in the physical memory space are two different translations, and
they both need to be applied.
PciRootBridgeIo.c deals with the former, whereas this driver deals with
the latter.
> ---
> ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.c b/ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.c
> index d8625e1593..8c46a2778b 100644
> --- a/ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.c
> +++ b/ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.c
> @@ -399,7 +399,6 @@ CpuIoServiceRead (
> return Status;
> }
>
> - Address += PcdGet64 (PcdPciIoTranslation);
>
> //
> // Select loop based on the width of the transfer
> @@ -485,7 +484,6 @@ CpuIoServiceWrite (
> return Status;
> }
>
> - Address += PcdGet64 (PcdPciIoTranslation);
>
> //
> // Select loop based on the width of the transfer
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-15 9:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-15 9:35 [edk2-devel][PATCH] ArmPkg/ArmPciCpuIo2Dxe: Correct pci io memmap address Yu Liu
2020-09-15 9:38 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox