From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4CDED941CCE for ; Tue, 30 Jan 2024 16:45:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9nzp1Y4B3YMVD5dfqydw0QF2vPuhYrp2MFZUqjY9l1U=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706633144; v=1; b=XUnv4+5Lg6v+79NOPEXdrKIaik7mDZsBwd8YWSOxcwZgaYVPC+G5v8ZzStFchjusQBQyEpDn zxTVk9AEbdIO7PtXkErV5KOOSeXkIDisMG8VxHVjrENU/h0uzcLUyigXYBBNjSjY8EmM7PDPeue 9xQv3nnxUEYWKvf5bS+V7lKU= X-Received: by 127.0.0.2 with SMTP id SkkeYY7687511x03m6FKJ8oU; Tue, 30 Jan 2024 08:45:44 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.968.1706633143459820988 for ; Tue, 30 Jan 2024 08:45:43 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-499-wQcUq9u-Mw22HKOe0iu2cw-1; Tue, 30 Jan 2024 11:45:38 -0500 X-MC-Unique: wQcUq9u-Mw22HKOe0iu2cw-1 X-Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 487F5185A786; Tue, 30 Jan 2024 16:45:37 +0000 (UTC) X-Received: from [10.39.192.28] (unknown [10.39.192.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F0984492BC6; Tue, 30 Jan 2024 16:45:35 +0000 (UTC) Message-ID: Date: Tue, 30 Jan 2024 17:45:34 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v8 24/37] ArmVirtPkg: Move two PCD variables into OvmfPkg To: Chao Li , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Gerd Hoffmann , Jiewen Yao References: <20240126062715.3099433-1-lichao@loongson.cn> <20240126063017.3102349-1-lichao@loongson.cn> <9bb8c832-7791-40af-89a4-ca5794c026de@loongson.cn> From: "Laszlo Ersek" In-Reply-To: <9bb8c832-7791-40af-89a4-ca5794c026de@loongson.cn> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ra5dM8RS2nnnd77AFA4Wgy4Fx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=XUnv4+5L; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/30/24 02:24, Chao Li wrote: > On 2024/1/30 03:49, Laszlo Ersek wrote: >> I suggest adding the following to your edk2 git config: >> >> [core] >> attributesFile =3D BaseTools/Conf/gitattributes >> >> [diff "ini"] >> xfuncname =3D ^\\[[A-Za-z0-9_., ]+] > Next time I will add these two configures in my git config file, it will > be reflected in V9 if it needed to commit. Thanks -- yes, that was what I meant. Certainly no need to repost the series just because of that; it's just that getting these settings in place "eventually" is good. > Ha, yes, patch 18 is added a new type, and I just add them under this > new type and it worked. Do you recommend these two PCDs keep the type > with PcdsFixedAtBuild only? If yes, in V9 I would move them under > PcdsFixedAtBuild. No, I think you did the right thing. The original permitted storage type list was [PcdsFixedAtBuild, PcdsPatchableInModule], and IIRC at least the ArmVirtQemuKernel platform relies on patchable PCDs. So restricting the storage type list to just [PcdsFixedAtBuild] across the move could cause a regression, at least in theory -- so it's best not to disturb that. Indeed, thus far we've not needed PcdsPatchableInModule in OVMF, but now that OvmfPkg accommodates more widely used artifacts, we do! Thanks! Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114803): https://edk2.groups.io/g/devel/message/114803 Mute This Topic: https://groups.io/mt/103971670/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-