From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "Gao, Liming" <liming.gao@intel.com>,
Star Zeng <star.zeng@intel.com>,
"Jordan Justen (Intel address)" <jordan.l.justen@intel.com>,
edk2-devel-01 <edk2-devel@lists.01.org>
Subject: Re: dynamic PCD impact on temporary PEI memory
Date: Fri, 20 Oct 2017 11:43:52 +0200 [thread overview]
Message-ID: <da4bb2b3-f81c-090e-38a1-c303a6486f7a@redhat.com> (raw)
In-Reply-To: <CAKv+Gu8e9LK4acfoDAU0r2BYwKY7P_p_ynys-HvHfSweMrtAaQ@mail.gmail.com>
On 10/20/17 09:57, Ard Biesheuvel wrote:
> On 19 October 2017 at 23:08, Laszlo Ersek <lersek@redhat.com> wrote:
>> * Symptom #1:
>>
>> I built OVMF for IA32, IA32X64 and X64, both "before" and "after". Then
>> I compared the log files, to see the impact of the addition of exactly
>> one UINT32 dynamic PCD to the PCD HOB, on temporary PEI memory usage.
>>
>> - Diff between "before" and "after", for IA32:
>>
>>> Temp Stack : BaseAddress=0x814000 Length=0x4000
>>> Temp Heap : BaseAddress=0x810000 Length=0x4000
>>> Total temporary memory: 32768 bytes.
>>> temporary memory stack ever used: 16384 bytes.
>
> The code that performs this check looks broken to me btw: it looks for
> INIT_CAR_VALUE on the stack, but it is not clear to me where the stack
> is initialised with this value, and that fact that we always seem to
> use exactly the entire stack looks suspicious as well.
>
> So perhaps you could reuse some of that space for the heap as well?
>
> #define INIT_CAR_VALUE 0x5AA55AA5
Possibly. Two observations hold me back:
- I did notice that "temporary memory stack ever used" was always the
full size. It seemed wrong (as you say), but without the actual usage
being reported, I wouldn't know how much to reassign from stack to heap.
- OVMF SEC currently halves the temp RAM between stack and heap. It
doesn't look hard to update. But, I'm not attracted to tracking down
other occurrences (if any) of same assumption in other (non-OvmfPkg)
parts of edk2.
Thanks!
Laszlo
next prev parent reply other threads:[~2017-10-20 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 22:08 dynamic PCD impact on temporary PEI memory Laszlo Ersek
2017-10-20 7:57 ` Ard Biesheuvel
2017-10-20 9:43 ` Laszlo Ersek [this message]
2017-10-20 10:22 ` Ard Biesheuvel
2017-10-20 10:33 ` Laszlo Ersek
2017-10-20 10:39 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da4bb2b3-f81c-090e-38a1-c303a6486f7a@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox