Re: [edk2-devel] [EXTERNAL] Re: [PATCH v9 00/13] Add the VariablePolicy feature

["Laszlo Ersek" <lersek@redhat.com>]

On 11/19/20 17:35, Ard Biesheuvel wrote:
> On 11/19/20 5:26 PM, Bret Barkelew wrote:
>> I should clarify that it wasn’t an official process. It was just a
>> suggestion that reached some consensus.
>>
> 
> Fair enough. I haven't been as active on the mailing list recently, so I
> may have missed some of this.

Right, I remember at some point there was a big influx of new BZs for
adopting VariablePolicy in edk2-platforms platforms... In fact if I run
a search in the TianoCore bugzilla for "variablepolicy", 15 open bugs
are returned -- from which 14 exist for various components (DSC/FDF
files) in the "Edk2 Platforms" project. Most seem to originate from
mid-to-end of May 2020.

Anyway, *if* I wanted to assign blame here, I'd absolutely assign it to
the fact that edk2-platforms exists separately from edk2... I don't have
a *clue* how we could catch breakage like this *in the general case*,
even with CI.

I don't know if I'll ever find my peace with edk2-platforms *not* being
covered by any git-grep that I run in edk2...

> I was just slightly shocked that every single platform got broken by
> this change.

Hopefully fixing up the platforms won't be very difficult. IIRC, it was
one of the design goals to restrict platform level changes to lib
classes / lib instance hooking into drivers / maybe some PCD changes.

Thanks,
Laszlo

> 
> 
>> ------------------------------------------------------------------------
>> *From:* devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Bret
>> Barkelew via groups.io <bret.barkelew=microsoft.com@groups.io>
>> *Sent:* Thursday, November 19, 2020 8:23:45 AM
>> *To:* Ard Biesheuvel <ard.biesheuvel@arm.com>; Bret Barkelew
>> <debtech@gmail.com>
>> *Cc:* Bret Barkelew <bret@corthon.com>; devel@edk2.groups.io
>> <devel@edk2.groups.io>; Yao, Jiewen <jiewen.yao@intel.com>; Dandan Bi
>> <dandan.bi@intel.com>; Jian J Wang <jian.j.wang@intel.com>; Hao A Wu
>> <hao.a.wu@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Jordan
>> Justen <jordan.l.justen@intel.com>; Laszlo Ersek <lersek@redhat.com>;
>> Andrew Fish <afish@apple.com>; Ni, Ray <ray.ni@intel.com>
>> *Subject:* Re: [edk2-devel] [EXTERNAL] Re: [PATCH v9 00/13] Add the
>> VariablePolicy feature
>> I followed the process that was agreed upon in this list: I opened
>> bugs to every platform maintainer with explicit details of what needed
>> to be changed and waited a full month before making any further
>> progress with the main patches (adding a month to the completion time).
>>
>> I’m wrapping things up to take a vacation next week, but if there are
>> still problems when I return, I can probably contribute to one or two
>> platforms.
>>
>> - Bret
>> ------------------------------------------------------------------------
>> *From:* Ard Biesheuvel <ard.biesheuvel@arm.com>
>> *Sent:* Thursday, November 19, 2020 8:19:37 AM
>> *To:* Bret Barkelew <debtech@gmail.com>
>> *Cc:* Bret Barkelew <bret@corthon.com>; devel@edk2.groups.io
>> <devel@edk2.groups.io>; Yao, Jiewen <jiewen.yao@intel.com>; Dandan Bi
>> <dandan.bi@intel.com>; Jian J Wang <jian.j.wang@intel.com>; Hao A Wu
>> <hao.a.wu@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Jordan
>> Justen <jordan.l.justen@intel.com>; Laszlo Ersek <lersek@redhat.com>;
>> Andrew Fish <afish@apple.com>; Ni, Ray <ray.ni@intel.com>; Bret
>> Barkelew <Bret.Barkelew@microsoft.com>
>> *Subject:* [EXTERNAL] Re: [PATCH v9 00/13] Add the VariablePolicy feature
>> On 11/19/20 5:15 PM, Bret Barkelew wrote:
>>> Those bugs and recommendations were sent out months ago. Several
>>> platforms have staged the changes already.
>>>
>>> You need to add the library class to your DSC.
>>>
>>
>> I know it has been painful to get these changes in, and I am glad that
>> you stuck with it. But that does not make it OK to simply break every
>> platform in edk2-platforms/ and not take any responsibility whatsoever
>> for fixing it. If it is such a trivial fix, why didn't you fix it
>> yourself?
>>
>> 
>