From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web08.23456.1605868484327414326 for ; Fri, 20 Nov 2020 02:34:44 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aJ6xjnGq; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605868483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mUO2m271j9+yUL44nS0REjHDGcWlWu/o3WGe7nW35es=; b=aJ6xjnGq9yrYvwtEsnN9lL7kjqi7GZqx4BkiFT+lPcQBylJ9WCRycaYYEzUrueMtCgXtzX FZ2XtmCA5Zhj1ReTaGsxtlB18kAGvgCSSOS4MKZxDIeAtjKSaHGhj8Wn3aG3AglsVGjgy9 L2LRDE9RkyICGsWN1Tw5FqJNPiGoLDQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-155-hxUhVKGiO2WryRo40IXGJA-1; Fri, 20 Nov 2020 05:34:37 -0500 X-MC-Unique: hxUhVKGiO2WryRo40IXGJA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2427E801B20; Fri, 20 Nov 2020 10:34:33 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-10.ams2.redhat.com [10.36.115.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id B6EFF10016DB; Fri, 20 Nov 2020 10:34:29 +0000 (UTC) Subject: Re: [edk2-devel] [EXTERNAL] Re: [PATCH v9 00/13] Add the VariablePolicy feature To: Ard Biesheuvel , Bret Barkelew , "devel@edk2.groups.io" , Bret Barkelew Cc: Bret Barkelew , "Yao, Jiewen" , Dandan Bi , Jian J Wang , Hao A Wu , Liming Gao , Jordan Justen , Andrew Fish , "Ni, Ray" References: <0c1ea26d-e7f2-11d7-b7d1-66cd5def51b3@arm.com> <345CC9C5-CCDB-4F76-A636-238B116DE217@gmail.com> <8dbfbe5a-3346-5df9-d2da-668a94b45e32@arm.com> <1648F558ACA0C0F8.8629@groups.io> <36cc776e-172d-de03-2378-23f4564ed8f0@arm.com> From: "Laszlo Ersek" Message-ID: Date: Fri, 20 Nov 2020 11:34:28 +0100 MIME-Version: 1.0 In-Reply-To: <36cc776e-172d-de03-2378-23f4564ed8f0@arm.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit On 11/19/20 17:35, Ard Biesheuvel wrote: > On 11/19/20 5:26 PM, Bret Barkelew wrote: >> I should clarify that it wasn’t an official process. It was just a >> suggestion that reached some consensus. >> > > Fair enough. I haven't been as active on the mailing list recently, so I > may have missed some of this. Right, I remember at some point there was a big influx of new BZs for adopting VariablePolicy in edk2-platforms platforms... In fact if I run a search in the TianoCore bugzilla for "variablepolicy", 15 open bugs are returned -- from which 14 exist for various components (DSC/FDF files) in the "Edk2 Platforms" project. Most seem to originate from mid-to-end of May 2020. Anyway, *if* I wanted to assign blame here, I'd absolutely assign it to the fact that edk2-platforms exists separately from edk2... I don't have a *clue* how we could catch breakage like this *in the general case*, even with CI. I don't know if I'll ever find my peace with edk2-platforms *not* being covered by any git-grep that I run in edk2... > I was just slightly shocked that every single platform got broken by > this change. Hopefully fixing up the platforms won't be very difficult. IIRC, it was one of the design goals to restrict platform level changes to lib classes / lib instance hooking into drivers / maybe some PCD changes. Thanks, Laszlo > > >> ------------------------------------------------------------------------ >> *From:* devel@edk2.groups.io on behalf of Bret >> Barkelew via groups.io >> *Sent:* Thursday, November 19, 2020 8:23:45 AM >> *To:* Ard Biesheuvel ; Bret Barkelew >> >> *Cc:* Bret Barkelew ; devel@edk2.groups.io >> ; Yao, Jiewen ; Dandan Bi >> ; Jian J Wang ; Hao A Wu >> ; Liming Gao ; Jordan >> Justen ; Laszlo Ersek ; >> Andrew Fish ; Ni, Ray >> *Subject:* Re: [edk2-devel] [EXTERNAL] Re: [PATCH v9 00/13] Add the >> VariablePolicy feature >> I followed the process that was agreed upon in this list: I opened >> bugs to every platform maintainer with explicit details of what needed >> to be changed and waited a full month before making any further >> progress with the main patches (adding a month to the completion time). >> >> I’m wrapping things up to take a vacation next week, but if there are >> still problems when I return, I can probably contribute to one or two >> platforms. >> >> - Bret >> ------------------------------------------------------------------------ >> *From:* Ard Biesheuvel >> *Sent:* Thursday, November 19, 2020 8:19:37 AM >> *To:* Bret Barkelew >> *Cc:* Bret Barkelew ; devel@edk2.groups.io >> ; Yao, Jiewen ; Dandan Bi >> ; Jian J Wang ; Hao A Wu >> ; Liming Gao ; Jordan >> Justen ; Laszlo Ersek ; >> Andrew Fish ; Ni, Ray ; Bret >> Barkelew >> *Subject:* [EXTERNAL] Re: [PATCH v9 00/13] Add the VariablePolicy feature >> On 11/19/20 5:15 PM, Bret Barkelew wrote: >>> Those bugs and recommendations were sent out months ago. Several >>> platforms have staged the changes already. >>> >>> You need to add the library class to your DSC. >>> >> >> I know it has been painful to get these changes in, and I am glad that >> you stuck with it. But that does not make it OK to simply break every >> platform in edk2-platforms/ and not take any responsibility whatsoever >> for fixing it. If it is such a trivial fix, why didn't you fix it >> yourself? >> >> >