From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Aditya Angadi <aditya.angadi@arm.com>, devel@edk2.groups.io
Cc: Leif Lindholm <leif@nuviainc.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Thomas Abraham <thomas.abraham@arm.com>,
Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
Subject: Re: [PATCH][edk2-platforms 0/5] Add support for RD-N2 platform
Date: Mon, 4 Jan 2021 18:48:23 +0100 [thread overview]
Message-ID: <da60493e-47a7-bc2c-fba6-0ce5972a94df@arm.com> (raw)
In-Reply-To: <20201218140726.23670-1-aditya.angadi@arm.com>
On 12/18/20 3:07 PM, Aditya Angadi wrote:
> This patch series refactors existing code to support addition of
> upcoming derivatives of RD platforms. It also adds support for the new
> RD-N2 platform.
>
> The upcoming derivative platforms that are being added have a different
> memory map from the existing ones. In order to accomodate this change,
> the macros that define base addresses have been refactored into PCDs.
> This allows defining a different base addresses for newer platforms.
>
> The second patch removes the use SMSC Lan91x controller from all the supported
> platforms under SgiPkg as all the platforms have been migrated to use VirtIO.
>
> The last three patches in the series add support for RD-N2 platform
>
> Aditya Angadi (5):
> Platform/ARM/SgiPkg: Use PCD for base addresses
> Platform/ARM/SgiPkg: remove the use of SMSC Lan91x controller
> Platform/ARM/SgiPkg: Define base address PCD for derivative platforms
> Platform/ARM/SgiPkg: Add ACPI tables for RD-N2 platform
> Platform/ARM/SgiPkg: Add initial support for RD-N2 platform
>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Pushed as e5b67b60b7e9..3ada6025ce23
Thanks,
Ard.
> Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl | 112 ++++++++++++++
> Platform/ARM/SgiPkg/AcpiTables/RdN2/Madt.aslc | 137 ++++++++++++++++++
> .../ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf | 60 ++++++++
> Platform/ARM/SgiPkg/AcpiTables/SsdtRos.asl | 19 +--
> Platform/ARM/SgiPkg/Include/SgiPlatform.h | 32 ----
> .../SgiPkg/Library/NorFlashLib/NorFlashLib.c | 12 +-
> .../Library/NorFlashLib/NorFlashLib.inf | 7 +-
> .../Library/PlatformLib/PlatformLib.inf | 6 +
> .../Library/PlatformLib/PlatformLibMem.c | 34 ++---
> Platform/ARM/SgiPkg/RdE1Edge/RdE1Edge.dsc | 1 +
> Platform/ARM/SgiPkg/RdN1Edge/RdN1Edge.dsc | 1 +
> Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc | 1 +
> .../SgiPkg/{RdV1/RdV1.dsc => RdN2/RdN2.dsc} | 11 +-
> Platform/ARM/SgiPkg/RdN2/RdN2.fdf.inc | 10 ++
> Platform/ARM/SgiPkg/RdV1/RdV1.dsc | 1 +
> Platform/ARM/SgiPkg/RdV1Mc/RdV1Mc.dsc | 1 +
> Platform/ARM/SgiPkg/Sgi575/Sgi575.dsc | 1 +
> Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc | 46 ++++++
> Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc | 46 ++++++
> Platform/ARM/SgiPkg/SgiPlatform.dec | 5 +
> Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 25 +---
> Platform/ARM/SgiPkg/SgiPlatform.fdf | 4 -
> 22 files changed, 462 insertions(+), 110 deletions(-)
> create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl
> create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN2/Madt.aslc
> create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf
> copy Platform/ARM/SgiPkg/{RdV1/RdV1.dsc => RdN2/RdN2.dsc} (80%)
> create mode 100644 Platform/ARM/SgiPkg/RdN2/RdN2.fdf.inc
> create mode 100644 Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc
> create mode 100644 Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc
>
prev parent reply other threads:[~2021-01-04 17:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 14:07 [PATCH][edk2-platforms 0/5] Add support for RD-N2 platform Aditya Angadi
2020-12-18 14:07 ` [PATCH][edk2-platforms 1/5] Platform/ARM/SgiPkg: Use PCD for base addresses Aditya Angadi
2020-12-18 14:07 ` [PATCH][edk2-platforms 2/5] Platform/ARM/SgiPkg: remove the use of SMSC Lan91x controller Aditya Angadi
2020-12-18 14:07 ` [PATCH][edk2-platforms 3/5] Platform/ARM/SgiPkg: Define base address PCD for derivative platforms Aditya Angadi
2020-12-18 14:07 ` [PATCH][edk2-platforms 4/5] Platform/ARM/SgiPkg: Add ACPI tables for RD-N2 platform Aditya Angadi
2020-12-18 14:07 ` [PATCH][edk2-platforms 5/5] Platform/ARM/SgiPkg: Add initial support " Aditya Angadi
2021-01-04 17:48 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da60493e-47a7-bc2c-fba6-0ce5972a94df@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox