From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.16945.1686759195450876096 for ; Wed, 14 Jun 2023 09:13:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=W7CpENb1; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.168.131, mailfrom: quic_llindhol@quicinc.com) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35ECADVw025879; Wed, 14 Jun 2023 16:13:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=a3Ajd9MTvCB4BdKzzhX5WBxA1u4OqPk52pGbq4pP+0c=; b=W7CpENb134rPbDZFfKuQ9n1PS+GrxMYMFLrnN0FQ0t3G+wbZS3Cgb/CA7O0F/8N8Eoaz q5kExNj1R7ImYfQKaYw5XFBUCM2N226QckLq6EVF04+b3RlAZFzbFHwXnuhflwIYXbDI 4OAf4Shx19GZ2f/hCj85m/yr+Ix+POWDRb/IWS5USXWjYG+qYX+DnIm/x2hpc/EpbPFK 5vQb/IWy+nxfDUBnpNGq6XxiXbIOk8UbblTX1bQeOXQz8zS2irIHfIw3/woRvuJ83f0U VSztraRun+WItEArY8qW1KNJ+kxKS8/Zw3jQ2G6KNe3C9EWkCw53XOA1wJxaz3zLYgzk ug== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3r6t0bu4kf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Jun 2023 16:13:13 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 35EGDDKr032379 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Jun 2023 16:13:13 GMT Received: from [10.111.135.64] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Wed, 14 Jun 2023 09:13:11 -0700 Message-ID: Date: Wed, 14 Jun 2023 17:13:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [edk2-devel] [edk2-platforms][PATCH] edk2-platform: Add Readme under Platform\AMD To: , CC: Michael D Kinney , Abdul Lateef Attar , Eric Xing , Jiangang He References: <20230614042231.339-1-abner.chang@amd.com> From: "Leif Lindholm" In-Reply-To: <20230614042231.339-1-abner.chang@amd.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: o71CIUk5tGxbg_uOcjbrfTQvSe9K80d3 X-Proofpoint-ORIG-GUID: o71CIUk5tGxbg_uOcjbrfTQvSe9K80d3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-14_11,2023-06-14_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 priorityscore=1501 clxscore=1011 mlxlogscore=999 spamscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 impostorscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306140141 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 2023-06-14 05:22, Chang, Abner via groups.io wrote: > From: Abner Chang > > For AMD edk2 opensource project and the needs > of opensource AMD platform common modules those can > be leverage across AMD business units, AMD server, > client and S3 (silicon strategic solution) BUs > have the consensus to propose AMD as the maintainer > of Platform/AMD folder. The folder and edk2 package > structure under Platform/AMD is defined in the > Readme for the further upstream works. > > We still leave the existing maintainers for > AMD OverdriveBoard which is no conflicts with this > change. > > Signed-off-by: Abner Chang > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Abdul Lateef Attar > Cc: Eric Xing > Cc: Jiangang He > --- > Platform/AMD/Readme.md | 85 ++++++++++++++++++++++++++++++++++++++++++ > Maintainers.txt | 10 ++--- > 2 files changed, 90 insertions(+), 5 deletions(-) > create mode 100644 Platform/AMD/Readme.md > > diff --git a/Platform/AMD/Readme.md b/Platform/AMD/Readme.md > new file mode 100644 > index 0000000000..f39b8140f5 > --- /dev/null > +++ b/Platform/AMD/Readme.md > @@ -0,0 +1,85 @@ > +# AMD EDK2 Platform > + > +This is AMD folder that provides the edk2 modules to support AMD edk2 firmware > +solution for the server, client (e.g., Notebook) and S3 (Strategic Silicon Solutions) > +platforms. The board packages under this folder are the firmware reference code for > +booting certain AMD platforms. The definition of sub-folders is described in below sections. > + > +## Term and Definitions > + > +* **AMD Platform** (platform in short) > + > + AMD platform refers to a platform that supports the particular AMD SoC (processor), such as AMD EPYC Milan and Genoa processors. > + > +* **AMD Board** (board in short) > + > + AMD board is a generic terminology refers to a board that is designed based on a > + specific AMD SoC architecture (also referred as AMD platform). More than one boards > + are possibly designed to support an AMD platform with different configuration, such as 1-processor socket or 2-processor sockets board. > + > +* **AMD edk2 Platform Package** (platform package in short) > + > + The folder has the AMD edk2 platform common modules. > + > +* **AMD edk2 Board Package** (board package in short) > + > + The folder has the edk2 meta files to build the necessary edk2 firmware modules > + and generate the binary to run on a board. > + > +## Package Definition > + > +* **AmdPlatformPkg** > + > + AMD platform edk2 package under this folder provides the common edk2 modules those > + are leverage by platforms. Usually those modules have no dependencies with > + particular platforms. The module under this scope can provides a common implementation > + for all platforms, or it may just provide a framework but the differences of implementation could be configured through the PCDs declared in AmdPlatformPkg.dec, or > + the board level library provided in the \Pkg. > + > +* **AmdMinBoardPkg** > + > + This package provides the common edk2 modules those can be leverage across AMD boards those use MinPlatformPkg framework. > + > +* **\Board** > + > + This is the folder named by SoC and accommodate one or multiple board packages those > + are designed base on the same SoC platform. Board folder may contain edk2 > + package meta files directly or the sub-folders named by \Pkg for a > + variety configurations of a platform. > + > +* **Pkg** > + > + This is the folder that contains edk2 package meta files for a board which is designed base on a platform. Besides the edk2 meta files, Pkg may also provides > + edk2 modules which are specifically to a board. > + > + ``` > + e.g. OverdriveBoard > + e.g. GenoaBoard > + |------Board1Pkg > + |------Board2Pkg > + ``` > + > + Below is the outline of folder structure under Platform/AMD > + > + ``` > + Platform/AMD > + |----AmdPlatformPkg > + |----AmdMinBoardPkg > + |----OverdriveBoard > + |----GenoaBoard > + | |------Common Modules for Genoa boards > + | |------Board1Pkg > + | | |-------Board specific modules > + | |------Board2Pkg > + | > + |----NextGenBoard > + |------Common Modules for the next generation > + platform boards > + |------Board1Pkg > + |------Board2Pkg > + |-------Board specific modules > + ``` > + > + > +## Board Support > +Under progress > \ No newline at end of file *cough* ^ > diff --git a/Maintainers.txt b/Maintainers.txt > index 020c72677a..d1d7613ef4 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -83,6 +83,11 @@ F: Platform/96Boards/ > M: Ard Biesheuvel > M: Leif Lindholm > > +AMD > +F: Platform/AMD > +M: Abner Chang > +M: Abdul Lateef Attar > + > AMD Seattle > F: Platform/AMD/OverdriveBoard/ > F: Platform/LeMaker/CelloBoard/ > @@ -91,11 +96,6 @@ F: Silicon/AMD/Styx/ > M: Ard Biesheuvel > M: Leif Lindholm > > -AMD MinBoard package for MinPlatformPkg > -F: Platform/AMD/AmdMinBoardPkg > -M: Abner Chang > -M: Abdul Lateef Attar > - I think this change is ideal, but can I just confirm that it is your intention to take on overall maintainership of Platform/AMD while leaving myself and Ard as additional maintainers for the OverDriveBoard? (If not, you could add an X: tag. But I'd be happier if you didn't :) / Leif > Ampere Computing > F: Platform/Ampere > F: Silicon/Ampere