From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by mx.groups.io with SMTP id smtpd.web10.3423.1606958958484868196 for ; Wed, 02 Dec 2020 17:29:18 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=xgVK/lZ0; spf=pass (domain: nuviainc.com, ip: 209.85.215.194, mailfrom: rebecca@nuviainc.com) Received: by mail-pg1-f194.google.com with SMTP id n10so379928pgv.8 for ; Wed, 02 Dec 2020 17:29:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=r3fB2ufGimBepPvzwUc2JJ3F8KOoBhb38P2+TdT7/zo=; b=xgVK/lZ0GRqqPM1XqzWx8vl/T18kA+9mivqb1IfbEsCTNzGn/TuUXYR4YxNZl69v7P SFcAl5dSycLBqhQDPSNp/1TL4iHq15HCGeveQ5EWPdelNWvdnpe3CUvL5ERymN2CLqM1 yTCgGz2sa2otF5kMF7xgU9h6xDx5PAA3qWDzj/HR2ZGTwy45f9nwzHtgbUUbhDY4XVy4 XUOUX479uzKdLJlIRHBlJzTrfdFJWcpyaxRtAAtLBqi4NhbGWjJyMqybrzZVFMHByYjD kkycaL2rooLFEbN3eGM0sy04yJa8PO2VprJjA8/dLmQbfbumSqMK73r5BdzOEBKpbcXP SipA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=r3fB2ufGimBepPvzwUc2JJ3F8KOoBhb38P2+TdT7/zo=; b=c0JWVOeQps/gQ/P+Mm8JHiWrmhh8/DGXhLsjUm83DjXLgAw8pBLBZqo8TwWK0WU08p s2uxZz2m8DzfTQBnI2FuotX7o28xen4wpIxD05AGndZeDnPZqzU3iZfWMIriJM/Ceyf4 kIImKQQSQzD/3wkkWvLfRKwQzgK/JNnoF0tQ8ja+iTQ3OuOcbiuKOarr5QjY9tn7bfYp 352SD3vrecKN3OQDUx01MNDcBJLWDx9oRzK83gm9ijakegSW/yN4fmG3AheMSGCqUWB2 hiVxh0j3bSF6rJJyfR+IFCuEnDgWRR0aZHl+6jr26k5zJolpcpwSbmMhSixq12kZjiMR 7JAw== X-Gm-Message-State: AOAM531bHgH6yeIBFw3oRLXr6DFtnW3H2gS6P2a7btPwyc+tptXRFe3+ x925kXgG6ibYKGAMrCFELOVKoA== X-Google-Smtp-Source: ABdhPJwnjQqvqgY5/VJfpho0Y0uVJFJu2HBsZFqLCFNZBVTLQkI7K0F4lYuKy506z+hlmZJzgXn2hA== X-Received: by 2002:a62:5c87:0:b029:197:5f13:b66c with SMTP id q129-20020a625c870000b02901975f13b66cmr787149pfb.73.1606958958014; Wed, 02 Dec 2020 17:29:18 -0800 (PST) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id 10sm123481pjt.35.2020.12.02.17.29.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Dec 2020 17:29:17 -0800 (PST) Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSCAwLzNdIE1kZVBrZzogZml4IHR5cG9zIGluIFNtQmlvcy5o?= To: devel@edk2.groups.io, gaoliming@byosoft.com.cn Cc: 'Michael D Kinney' , 'Zhiguang Liu' , 'Leif Lindholm' , 'Laszlo Ersek' References: <20201202190325.20310-1-rebecca@nuviainc.com> <005b01d6c912$2d94d050$88be70f0$@byosoft.com.cn> From: "Rebecca Cran" Message-ID: Date: Wed, 2 Dec 2020 18:29:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <005b01d6c912$2d94d050$88be70f0$@byosoft.com.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Liming, Yes lots of platforms use the structures, but most (all?) don't reference the fields themselves. For example, searching for "FirwareVersion" in edk2-platforms gives just one results: ../edk2-platforms/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c:576: 0,                    // FirwareVersion Same for 'Processor64BitCapble: ../edk2-platforms/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c:276: // Processor64BitCapble            :1; I did find a problem with this patch: SmbiosView in edk2 needs updated at the same time - so I'll send out a v2 shortly. -- Rebecca Cran On 12/2/20 6:18 PM, gaoliming wrote: > Rebecca: > I search SMBIOS_TABLE_TYPE4 and SMBIOS_TABLE_TYPE17 in edk2-platforms. > There are many platform SmbiosDxe driver to depend on them. > So, this change impacts widely. This change is just to rename field name. > There is no real functionality change. I suggest to add comments for those > typo fields instead of changing them. > > Thanks > Liming >> -----邮件原件----- >> 发件人: bounce+27952+68193+4905953+8761045@groups.io >> 代表 Rebecca Cran >> 发送时间: 2020年12月3日 3:03 >> 收件人: devel@edk2.groups.io >> 抄送: Rebecca Cran ; Michael D Kinney >> ; Liming Gao ; >> Zhiguang Liu >> 主题: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h >> >> Since the edk2-stable202011 tag has been created, I'm resubmitting the >> SmBios.h typo fixes. >> >> Rebecca Cran (3): >> MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS >> struct >> MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field >> ProcessorManufacturer >> MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field >> FirmwareVersion >> >> MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++---------- >> 1 file changed, 13 insertions(+), 13 deletions(-) >> >> -- >> 2.26.2 >> >> >> >> >> > > > > > > >