From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2BB151A1E28 for ; Fri, 21 Oct 2016 13:14:20 -0700 (PDT) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9E658C0567B1; Fri, 21 Oct 2016 20:14:19 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-45.phx2.redhat.com [10.3.116.45]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9LKEHeT010273; Fri, 21 Oct 2016 16:14:17 -0400 To: Jordan Justen , Ard Biesheuvel , edk2-devel-01 , "Kinney, Michael D" , Leif Lindholm , "afish@apple.com" References: <147707992484.13791.10042868456965197315@jljusten-ivb> Cc: "Gao, Liming" From: Laszlo Ersek Message-ID: Date: Fri, 21 Oct 2016 22:14:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <147707992484.13791.10042868456965197315@jljusten-ivb> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 21 Oct 2016 20:14:19 +0000 (UTC) Subject: Re: [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2016 20:14:20 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 10/21/16 21:58, Jordan Justen wrote: > On 2016-10-21 12:37:21, Ard Biesheuvel wrote: >> I don't remember seeing any discussion regarding >> DISABLE_NEW_DEPRECATED_INTERFACES on the list, so I am a bit surprised >> seeing these bugs being filed and assigned. >> > > I agree. > > Also, the terminology seems confusing. 'new deprecated' seems like a > contradiction. I guess it means 'newly deprecated', but that seems > like a term that is quickly going to become obsolete. Soon there will > be old deprecated items that are disabled with this switch. > DISABLE_DEPRECATED_INTERFACES sounds better. > > But, shouldn't we have platforms opt-in to using the deprecated > interfaces rather than adding DISABLE_NEW_DEPRECATED_INTERFACES to the > build command line for every EDK II platform? > > Not using deprecated items should be the default for EDK II platforms. > If a platform has to opt-in to the deprecated content in their .dsc, > then it is obvious that they are relying on deprecated functionality. > > So, I guess I'd propose adding ENABLE_DEPRECATED_INTERFACES instead. I'm about to post a ~20-part series for OvmfPkg and ArmVirtPkg together that solves these BZs. :/ The DISABLE_NEW_DEPRECATED_INTERFACES feature test macro is already being used in three MdePkg library class header files (and a number of library instances), so I thought it was a done deal. I don't want to stifle the discussion of course, but at this point I think I will post the patches for review. Thanks Laszlo > -Jordan > >> Before making any such changes, I would like a strong commitment from >> other package owners that deprecating an interface brings along with >> it the responsibility to update all existing callers, otherwise >> setting this define will only result in more breakage, and ARM has >> seen its share of inadvertent breakage in the past when changes to >> core code were made without taking other architectures into account. >> >> On 21 October 2016 at 02:21, wrote: >>> https://bugzilla.tianocore.org/show_bug.cgi?id=164 >>> >>> yonghong.zhu@intel.com changed: >>> >>> What |Removed |Added >>> ---------------------------------------------------------------------------- >>> Priority|Lowest |Normal >>> Status|UNCONFIRMED |CONFIRMED >>> Assignee|michael.d.kinney@intel.com |ard.biesheuvel@linaro.org >>> Ever confirmed|0 |1 >>> Release(s) the| |EDK II Trunk >>> issues must be| | >>> fixed| | >>> >>> --- Comment #1 from yonghong.zhu@intel.com --- >>> Assign to Package owner. >>> >>> -- >>> You are receiving this mail because: >>> You are the assignee for the bug. >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel